Page MenuHomePhabricator

[AA] Updates for D95543.
ClosedPublic

Authored by dfukalov on Wed, Apr 14, 1:10 AM.

Details

Summary

Addressing latter comments in D95543:

  • AliasResult::Result renamed to AliasResult::Kind
  • Offset printing added for PartialAlias case in -aa-eval
  • Removed VisitedPhiBBs check from BasicAA'

Diff Detail

Event Timeline

dfukalov created this revision.Wed, Apr 14, 1:10 AM
dfukalov requested review of this revision.Wed, Apr 14, 1:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Apr 14, 1:10 AM
dfukalov edited the summary of this revision. (Show Details)Wed, Apr 14, 1:12 AM
nikic added inline comments.Wed, Apr 14, 1:13 AM
llvm/lib/Analysis/AliasAnalysisEvaluator.cpp
56

Why not AR.swap(true);?

dfukalov updated this revision to Diff 337407.Wed, Apr 14, 4:45 AM

Addressing comment: using AliasResult::swap().

dfukalov marked an inline comment as done.Wed, Apr 14, 4:48 AM
dfukalov added inline comments.
llvm/lib/Analysis/AliasAnalysisEvaluator.cpp
56

Thanks, seems it was my mental fog )

nikic accepted this revision.Wed, Apr 14, 11:40 AM

LGTM, thanks!

llvm/lib/Analysis/AliasAnalysisEvaluator.cpp
57

Might make sense to make true the default.

This revision is now accepted and ready to land.Wed, Apr 14, 11:40 AM
This revision was automatically updated to reflect the committed changes.
dfukalov marked an inline comment as done.