This patch fixes rc and errno within nanosleep(). It also updates __rem parameter as well it introduces cast to handle conversions from long into unsigned int to avoid warnings.
- Group Reviewers
- rG916093f49faf: [SystemZ][z/OS] correct rc and errno within nanosleep()
This commit message is highly misleading. This is rewriting the function, not only tuning down warning levels. Can you please delimit more clearly what your change is doing if you want a meaningful review? It might be a good idea to break it down into more than one patch, too.
By the way, my comments are made in the spirit of encouraging good review practices more than anything. I otherwise don't have a stake in this patch, since this is z/OS which is not officially supported anyway (since it lacks CI).
Please use complete sentences starting with a capital and ending with a full stop.
I think I wasn't clear enough regarding what I meant with too large.
So I like the mentioning of the rounding up, but I would also like some information regarding ignoring the time slept.
@zibi Please do *not* commit patches when the libcxx review group is not green. The policy for committing to libc++ is clear - you have to wait for the libcxx group to be green, or you will get reverted.
This is OK for now and I'm sure you did not intend to do wrong, but please follow the process in the future.