- User Since
- Sep 14 2017, 10:33 AM (187 w, 4 d)
Fri, Apr 9
Tue, Apr 6
Thu, Apr 1
adding short comments about implementation
Sorry about that, I fixed the description so it should be clear now.
Fri, Mar 26
fixing CI failure
Fix issues with rc and errno as well adding cast for conversion warrnings.
Thu, Mar 25
Mar 16 2021
LTGM, thx for an extra mile, Abhina.
Mar 15 2021
LGTM, I just wonder if we can make an extra parameter to be default. I notice some places that is a default parameter but not in all instances. With default parameter some of the calls might be simplified if there is no need to override it.
Mar 8 2021
Mar 4 2021
Mar 2 2021
Feb 24 2021
Feb 23 2021
This LGTM from my end.
@ldionne can we get your approval?
Feb 18 2021
Feb 16 2021
ping - very minor change
Feb 12 2021
This has been reviewed before.
@ldionne Can I integrate this?
Feb 8 2021
I'm abending this since there is no interest and current implementation will work on z/OS.
FYI, @ldionne I'm looking for you approval.
Feb 5 2021
Moving to chrono.cpp is fine, otherwise please provide the exact suggestion for target_compile_definitions() .
Moving macro to chrono.cpp.
Oops, thx Hubert.
@ldionne You might also cancel these 2 builds:
- resubmitting to get clean CI, thank you Louis for finding the issue with previous builds
synch with __support rename
Feb 4 2021
Hopefully this time CI will be clean, the previous one never completed.
Feb 3 2021
Making _LARGE_TIME_API locale, renaming header guard and removing NR asm constriants.
adding none c++ libraries back even for -nostdlib++ for libcxx/libcxxabi/libunwind to check if this will make CI clean
Feb 2 2021
reverse previous fix and try something new to test CI
On MINGW we need to build libunwind with -nodefaultlibs on b/c LIBUNWIND_SUPPORTS_FUNWIND_TABLES_FLAG is not set,
otherwise we issue this error:
Default libunwind to be build with -nodefaultlibs on MINGW.
typo + patch with arc diff
pached created by arc diff
Jan 26 2021
Hubert, I incorporated your suggestions. Please note that currently pre-build checks fails because of unrelated issues with Apple back-deployment macosx10.9 test bucket.
Jan 25 2021
format + tidy
Please see a new patch according to the comments I received.
Thank you louis and Hubert for review and suggestions.
Jan 23 2021
Jan 14 2021
rebase and resubmit to fix the build
Jan 13 2021
The documentation Hubert pointed to clearly mentions that PATH_MAX can be used, so I don't understand the issue. If the issue is that you want to be able to compile libc++ on systems so old that they don't have PATH_MAX defined even though the documentation says it is provided, that doesn't sound compelling to me.
Removing trailing character and resubmitting.
Not sure why pre. build check failed with trailing spaces. I could not find any.
Resubmitting to check if it goes this time.
@ldionne which suggestion do you prefer?
Adding gettimeofday() equivalent for CLOCK_MONOTONIC for z/OS.
Jan 7 2021
Jan 6 2021
Jan 4 2021
We have to use _XOPEN_PATH_MAX instead of PATH_MAX on z/OS.
Dec 18 2020
Dec 16 2020
Dec 9 2020
On z/OS we have multiple file systems with different limits which does not allow to have just one constant for PATH_MAX. Same is true for other related limits like NAME_MAX. See the following references which justify the z/OS choice.