This is an archive of the discontinued LLVM Phabricator instance.

added section on CI system
ClosedPublic

Authored by kuhnel on Feb 24 2021, 7:34 AM.

Details

Summary

Add documentation for working with the CI systems.

This is based on the discussion in the Infrastructure Working Group:
https://github.com/ChristianKuehnel/iwg-workspace/issues/37

Diff Detail

Event Timeline

kuhnel requested review of this revision.Feb 24 2021, 7:34 AM
kuhnel created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2021, 7:34 AM
kuhnel updated this revision to Diff 326093.Feb 24 2021, 7:48 AM

added missing information on worker tab

kuhnel updated this revision to Diff 331893.Mar 19 2021, 8:42 AM

added screenshot

@reames I added a screenshot as you wanted. Please let me know if that addresses your usecase.

reames accepted this revision.Mar 19 2021, 9:27 AM

LGTM

This revision is now accepted and ready to land.Mar 19 2021, 9:27 AM
kuhnel added a comment.Apr 3 2021, 3:15 AM

@gkistanova are you OK with this documentation change?

Thanks for updating the LLVM Developer Policy, Christian.
It looks good with a couple nit picks.

llvm/docs/DeveloperPolicy.rst
572

There is a set of builders with the name suffix "-release", for example https://lab.llvm.org/buildbot/#/builders/clang-with-thin-lto-ubuntu-release. These builders track the commits on the release branches to do the release testing.

610

LNT is a performance tracking system, not quite a CI.

fhahn added a subscriber: fhahn.Apr 7 2021, 12:22 PM
fhahn added inline comments.
llvm/docs/DeveloperPolicy.rst
609

I'm not sure about the official status of green dragon, but I think in practice breaking one of those is considered similar to breaking bots at https://lab.llvm.org/buildbot/ (most bots for various Apple platforms are on green dragon rather than https://lab.llvm.org/buildbot)

kuhnel updated this revision to Diff 336336.Apr 9 2021, 1:10 AM
kuhnel marked 3 inline comments as done.

addressed Galinas comments

llvm/docs/DeveloperPolicy.rst
609

I'm also not aware of any official policy around green dragons. So as I did not find any policy, I would assume they are optional as well...

There is now an official revert policy:
https://reviews.llvm.org/D99305

kuhnel added a comment.Apr 9 2021, 1:37 AM

@tschuett, thx I missed that update, just added a link to that...

kuhnel updated this revision to Diff 336344.Apr 9 2021, 1:38 AM

added link to revert policy

Harbormaster completed remote builds in B97903: Diff 336344.
azharudd added inline comments.
llvm/docs/DeveloperPolicy.rst
566–567
572
606–612

I think it is best to just remove this part.

  • Issues reported by any CI system are to be fixed
  • LNT is not CI, whereas this section is talking about CI system
  • pre-merge testing is optional, covers only Phab reviews and already posts updates on the review
kuhnel marked 3 inline comments as done.Apr 21 2021, 12:36 AM
kuhnel added inline comments.
llvm/docs/DeveloperPolicy.rst
606–612

you're right, this does not really add value here.

kuhnel updated this revision to Diff 339128.Apr 21 2021, 12:37 AM
kuhnel marked an inline comment as done.

addressed azharudd's comments

This revision was landed with ongoing or failed builds.Apr 21 2021, 12:59 AM
This revision was automatically updated to reflect the committed changes.