Page MenuHomePhabricator

[StringExtras] Rename SubsequentDelim to ListSeparator
ClosedPublic

Authored by kazu on Jan 13 2021, 8:39 PM.

Details

Summary

This patch renames SubsequentDelim to ListSeparator to clarify the
purpose of the class.

Diff Detail

Event Timeline

kazu created this revision.Jan 13 2021, 8:39 PM
kazu requested review of this revision.Jan 13 2021, 8:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2021, 8:39 PM
dblaikie accepted this revision.Jan 13 2021, 8:49 PM

Sounds good to me - but give it a day or two. @MaskRay or others might want to weigh in.

This revision is now accepted and ready to land.Jan 13 2021, 8:49 PM
MaskRay accepted this revision.Jan 13 2021, 9:01 PM

Thanks. The new name looks better! I mentioned the patch on discord. Hope one day or two is sufficient for interested folks to weigh in.

llvm/unittests/ADT/StringExtrasTest.cpp
224

Not sure whether it should be committed separately:
using LS the third time is useful but untested.

This revision was automatically updated to reflect the committed changes.