Page MenuHomePhabricator
Differential D94463

[Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate are used together
ClosedPublic
Actions

Authored by MaskRay on Jan 11 2021, 6:27 PM.

Details

Reviewers
xur
Commits
rGcf45731f0eae: [Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate…
Summary

If conflicting -fprofile-generate -fcs-profile-generate are used together,
there is currently an assertion failure. Fix the failure.

Also add some driver tests.

Diff Detail

Unit TestsFailed
View All

TimeTest
110 msx64 windows > Clang.Driver::fcs-profile-generate.c
Script: -- : 'RUN: at line 1'; c:\ws\w32-1\llvm-project\premerge-checks\build\bin\clang.exe -### -c -fprofile-use=a.profdata -fcs-profile-generate C:\ws\w32-1\llvm-project\premerge-checks\clang\test\Driver\fcs-profile-generate.c 2>&1 | c:\ws\w32-1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w32-1\llvm-project\premerge-checks\clang\test\Driver\fcs-profile-generate.c

Event Timeline

MaskRay requested review of this revision.Jan 11 2021, 6:27 PM
MaskRay created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2021, 6:27 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B84785: Diff 315976.Jan 11 2021, 7:00 PM
MaskRay updated this revision to Diff 316233.Jan 12 2021, 2:02 PM
MaskRay retitled this revision from [Driver] Make -fcs-profile-generate require -fprofile-use to [Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate are used together.
MaskRay edited the summary of this revision. (Show Details)

.

xur accepted this revision.Jan 12 2021, 2:10 PM

looks good to me. Thanks for working on this.

This revision is now accepted and ready to land.Jan 12 2021, 2:10 PM
MaskRay updated this revision to Diff 316238.Jan 12 2021, 2:19 PM

Fix test on Windows

This revision was landed with ongoing or failed builds.Jan 12 2021, 2:20 PM
Closed by commit rGcf45731f0eae: [Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate… (authored by MaskRay). · Explain Why
This revision was automatically updated to reflect the committed changes.
MaskRay added a commit: rGcf45731f0eae: [Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate….
Harbormaster completed remote builds in B84917: Diff 316233.Jan 12 2021, 2:46 PM
Harbormaster completed remote builds in B84921: Diff 316238.Jan 12 2021, 2:53 PM

Revision Contents
Changeset List

PathSize
clang/
lib/
Driver/
ToolChains/
7 lines
test/
Driver/
12 lines

Diff 315976

View Options

clang/lib/Driver/ToolChains/Clang.cpp

Loading...
View Options

clang/test/Driver/fcs-profile-generate.c

Loading...