[Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate are used together
ClosedPublic
Actions

Authored by MaskRay on Jan 11 2021, 6:27 PM.

Details

Reviewers

xur

Commits

rGcf45731f0eae: [Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate…

Summary

If conflicting -fprofile-generate -fcs-profile-generate are used together,
there is currently an assertion failure. Fix the failure.

Also add some driver tests.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

MaskRay requested review of this revision.Jan 11 2021, 6:27 PM

MaskRay created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2021, 6:27 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Harbormaster completed remote builds in B84785: Diff 315976.Jan 11 2021, 7:00 PM

looks good to me. Thanks for working on this.

This revision is now accepted and ready to land.Jan 12 2021, 2:10 PM

Fix test on Windows

This revision was landed with ongoing or failed builds.Jan 12 2021, 2:20 PM

Closed by commit rGcf45731f0eae: [Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate… (authored by MaskRay). · Explain Why

This revision was automatically updated to reflect the committed changes.

MaskRay added a commit: rGcf45731f0eae: [Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate….

Harbormaster completed remote builds in B84917: Diff 316233.Jan 12 2021, 2:46 PM

Harbormaster completed remote builds in B84921: Diff 316238.Jan 12 2021, 2:53 PM

Revision Contents
Changeset List

Path

Size

clang/

lib/

Driver/

ToolChains/

Clang.cpp

4 lines

test/

Driver/

fcs-profile-generate.c

15 lines

Diff 316238

View Options

clang/lib/Driver/ToolChains/Clang.cpp