This is an archive of the discontinued LLVM Phabricator instance.

[mlir][vector] modified scatter/gather syntax, pass_thru mandatory
ClosedPublic

Authored by aartbik on Jan 8 2021, 4:34 PM.

Details

Summary

This change makes the scatter/gather syntax more consistent with
the syntax of all the other memory operations in the Vector dialect
(order of types, use of [] for index, etc.). This will make the MLIR
code easier to read. In addition, the pass_thru parameter of the
gather has been made mandatory (there is very little benefit in
using the implicit "undefined" values).

Diff Detail

Event Timeline

aartbik created this revision.Jan 8 2021, 4:34 PM
aartbik requested review of this revision.Jan 8 2021, 4:34 PM
nicolasvasilache accepted this revision.Jan 9 2021, 9:20 AM
This revision is now accepted and ready to land.Jan 9 2021, 9:20 AM