This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Add _e64 suffix to VOP3 Insts
ClosedPublic

Authored by Joe_Nash on Jan 8 2021, 2:06 PM.

Details

Summary

Previously, instructions which could be
expressed as VOP3 in addition to another
encoding had a _e64 suffix on the tablegen
record name, while those
only available as VOP3 did not. With this
patch, all VOP3s will have the _e64 suffix.
The assembly does not change, only the mir.

Diff Detail

Event Timeline

Joe_Nash created this revision.Jan 8 2021, 2:06 PM
Joe_Nash requested review of this revision.Jan 8 2021, 2:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2021, 2:06 PM
rampitec added a reviewer: dp.Jan 8 2021, 2:09 PM
rampitec added a reviewer: arsenm.
foad added a comment.Jan 11 2021, 5:50 AM

Maybe reword the description to make it clear that it only affects the names of pseudos, not real instructions, assuming I got that right?

foad accepted this revision.Jan 11 2021, 7:08 AM

Looks OK to me. Does this enable any immediate simplifications? Or is it just to help with future work?

llvm/lib/Target/AMDGPU/VOP3Instructions.td
122–127

Comments generally have a capital letter and full stop.

124

Two space indent.

387–389

Indent?

This revision is now accepted and ready to land.Jan 11 2021, 7:08 AM
Joe_Nash updated this revision to Diff 315889.Jan 11 2021, 11:42 AM
Joe_Nash marked 3 inline comments as done.

Address format comments of foad.

Looks OK to me. Does this enable any immediate simplifications? Or is it just to help with future work?

Just helps with future work. The idea is we can treat VOP3 Pseudos the same regardless of their origin.

llvm/lib/Target/AMDGPU/VOP3Instructions.td
387–389

The indentation is not very consistent in this file, but I added one here, and a few other spots I thought it helped clarity.

This revision was landed with ongoing or failed builds.Jan 12 2021, 3:40 PM
This revision was automatically updated to reflect the committed changes.