Page MenuHomePhabricator

[SLP] put verifyFunction call behind EXPENSIVE_CHECKS
ClosedPublic

Authored by spatel on Fri, Jan 8, 11:30 AM.

Details

Summary

A severe compile-time slowdown from this call is noted in:
https://llvm.org/PR48689
My naive fix was to put it under LLVM_DEBUG ( 267ff79 ), but that's not limiting in the way we want.
IIUC, this is an acceptable quick fix (or we could just remove the call completely and rely on some later pass to discover potentially wrong IR?).
A bigger/better fix would be to improve/limit verifyFunction() as noted in:
https://llvm.org/PR47712

Diff Detail

Event Timeline

spatel created this revision.Fri, Jan 8, 11:30 AM
spatel requested review of this revision.Fri, Jan 8, 11:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Jan 8, 11:30 AM
nikic accepted this revision.Fri, Jan 8, 11:52 AM

LGTM

This revision is now accepted and ready to land.Fri, Jan 8, 11:52 AM
This revision was automatically updated to reflect the committed changes.