Page MenuHomePhabricator

[RISCV] Don't print zext.b alias.
ClosedPublic

Authored by craig.topper on Dec 26 2020, 12:41 PM.

Details

Summary

This alias for andi x, 255 was recently added to the spec. If we
print it, code we output can't be compiled with -fno-integrated-as
unless the GNU assembler is also a version that supports alias.

Diff Detail

Event Timeline

craig.topper created this revision.Dec 26 2020, 12:41 PM
craig.topper requested review of this revision.Dec 26 2020, 12:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 26 2020, 12:41 PM
Herald added a subscriber: MaskRay. · View Herald Transcript
lenary accepted this revision.Jan 5 2021, 2:01 AM

LGTM. Thanks for fixing this, let's get it landed quickly.

This revision is now accepted and ready to land.Jan 5 2021, 2:01 AM
lenary added a comment.Jan 5 2021, 2:10 AM

Sidenote: I think LLVM recently got a way of specifying the binutils version in use - I don't know if we can use that info in this part of assembly printing, or whether it's best just to wait.

Note from gnu toolchain side, GCC will detect bintuils version and behavior during configure time and set different default behavior according the version or feature support test result, but I know clang/llvm doing different way on this part.

This revision was automatically updated to reflect the committed changes.