Page MenuHomePhabricator

[NFC] cleanup cg-profile emission on TargetLowerinng
ClosedPublic

Authored by zequanwu on Dec 11 2020, 5:35 PM.

Diff Detail

Event Timeline

zequanwu created this revision.Dec 11 2020, 5:35 PM
zequanwu requested review of this revision.Dec 11 2020, 5:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 11 2020, 5:35 PM
rnk accepted this revision.Dec 14 2020, 10:15 AM

Looks good, only one comment.

llvm/include/llvm/Target/TargetLoweringObjectFile.h
89

I think this doesn't need to be virtual, since there are no overrides.

This revision is now accepted and ready to land.Dec 14 2020, 10:15 AM
MaskRay accepted this revision.Dec 14 2020, 10:26 AM
zequanwu updated this revision to Diff 311679.Dec 14 2020, 1:07 PM
zequanwu marked an inline comment as done.

address comment.

This revision was landed with ongoing or failed builds.Dec 14 2020, 1:08 PM
This revision was automatically updated to reflect the committed changes.