Page MenuHomePhabricator

collect_and_build_with_pgo.py: adapt to monorepo
ClosedPublic

Authored by kristof.beyls on Nov 30 2020, 8:16 AM.

Details

Summary

This adapts the collect_and_build_with_pgo.py script so that it works with monorepo repositories, i.e. the default after the github move.

Diff Detail

Event Timeline

kristof.beyls created this revision.Nov 30 2020, 8:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2020, 8:16 AM
kristof.beyls requested review of this revision.Nov 30 2020, 8:16 AM

thanks for this!

i think the preferred way to PGO LLVM is cmake: https://llvm.org/docs/AdvancedBuilds.html

that said, while we have this script & the docs pointing to it, seems good to keep it up-to-date. LGTM

This revision is now accepted and ready to land.Nov 30 2020, 9:44 AM
This revision was automatically updated to reflect the committed changes.

thanks for this!

i think the preferred way to PGO LLVM is cmake: https://llvm.org/docs/AdvancedBuilds.html

that said, while we have this script & the docs pointing to it, seems good to keep it up-to-date. LGTM

Thanks for the quick response!
I had missed https://llvm.org/docs/AdvancedBuilds.html, so I just tried the instructions there to do a PGO build, but it seems it does not work (at least on ToT) currently.
ninja told me it doesn't know target stage2-instrumented-generate-profdata