Page MenuHomePhabricator

george.burgess.iv (George Burgess IV)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 15 2014, 12:28 PM (327 w, 5 d)

Recent Activity

Thu, Oct 22

george.burgess.iv added reviewers for D89988: adds basic -Wfree-nonheap-object functionality: rtrieu, aaron.ballman.

thanks for this! i like the idea of this warning; seems like a cheap way to catch ugly bugs early. +rtrieu and aaron.ballman, as this is a new diagnostic

Thu, Oct 22, 3:36 PM · Restricted Project

Thu, Oct 1

george.burgess.iv committed rG9d40fb808fd0: Allow to specify macro names for android-comparison-in-temp-failure-retry (authored by fmayer).
Allow to specify macro names for android-comparison-in-temp-failure-retry
Thu, Oct 1, 10:12 AM
george.burgess.iv closed D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry..
Thu, Oct 1, 10:12 AM · Restricted Project

Sep 25 2020

george.burgess.iv accepted D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry..
Sep 25 2020, 4:49 AM · Restricted Project

Sep 16 2020

george.burgess.iv added a comment to D87661: [MemorySSA] Rename uses in blocks with Phis..

(still lgtm. :) )

Sep 16 2020, 3:51 PM · Restricted Project

Sep 15 2020

george.burgess.iv accepted D87661: [MemorySSA] Rename uses in blocks with Phis..

but when prinitng we were still seeing an unoptimized access
as MustAlias due to the flag not being reset

Sep 15 2020, 5:27 PM · Restricted Project

Aug 3 2020

george.burgess.iv accepted D84905: [MemorySSA] Restrict optimizations after a PhiTranslation..

lgtm with a few tiny nits. thanks for working on this!

Aug 3 2020, 1:07 PM · Restricted Project

Jul 6 2020

george.burgess.iv added a reviewer for D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.: alexfh.

Concept and implementation LGTM. Please wait for comment from +alexfh before landing, since I think they have more ownership over clang-tidy in general than I do :)

Jul 6 2020, 12:57 PM · Restricted Project

Jun 9 2020

george.burgess.iv accepted D78932: [DSE,MSSA] Relax post-dom restriction for objs visible after return..

Eesh -- sorry for taking forever. :)

Jun 9 2020, 8:57 PM · Restricted Project

May 26 2020

george.burgess.iv added a comment to D80000: [MSSA] Doc: Clobbers, more info on Defs / Def chain.

thanks for this!

May 26 2020, 9:46 AM · Restricted Project

May 20 2020

george.burgess.iv added a comment to D78932: [DSE,MSSA] Relax post-dom restriction for objs visible after return..

Sorry for the latency :)

May 20 2020, 10:22 AM · Restricted Project

May 6 2020

george.burgess.iv added a comment to D78932: [DSE,MSSA] Relax post-dom restriction for objs visible after return..

Thanks for the patch :)

May 6 2020, 7:20 PM · Restricted Project

May 5 2020

george.burgess.iv accepted D79386: [MemorySSA] Make MemoryLocation unknown when phi translation cannot be performed..

lgtm with one nit. thanks!

May 5 2020, 9:41 AM · Restricted Project

May 4 2020

george.burgess.iv added a comment to D78932: [DSE,MSSA] Relax post-dom restriction for objs visible after return..

sorry for the latency -- a bit busy now, but I hope to get to this by EOD Wednesday :)

May 4 2020, 2:32 PM · Restricted Project

Apr 29 2020

george.burgess.iv accepted D79068: [MemorySSA] Pass DT to the upward iterator for proper PhiTranslation..

oof. thanks for this!

Apr 29 2020, 12:29 AM · Restricted Project

Apr 16 2020

george.burgess.iv committed rG94908088a831: [CodeGen] fix inline builtin-related breakage from D78162 (authored by george.burgess.iv).
[CodeGen] fix inline builtin-related breakage from D78162
Apr 16 2020, 12:15 PM
george.burgess.iv added a comment to D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them..

Thanks for the report! Looking now.

Apr 16 2020, 10:35 AM · Restricted Project

Apr 15 2020

george.burgess.iv committed rG2dd17ff08165: [CodeGen] only add nobuiltin to inline builtins if we'll emit them (authored by george.burgess.iv).
[CodeGen] only add nobuiltin to inline builtins if we'll emit them
Apr 15 2020, 11:32 AM
george.burgess.iv closed D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them..
Apr 15 2020, 11:31 AM · Restricted Project
george.burgess.iv added a comment to D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them..

thanks!

Apr 15 2020, 11:30 AM · Restricted Project

Apr 14 2020

george.burgess.iv created D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them..
Apr 14 2020, 3:45 PM · Restricted Project
george.burgess.iv committed rG91c8c74180ce: [CodeGen] clarify a comment; NFC (authored by george.burgess.iv).
[CodeGen] clarify a comment; NFC
Apr 14 2020, 2:40 PM
george.burgess.iv abandoned D78148: [CodeGen] make isTriviallyRecursive handle more trivial recursion.

Nothing in the real world :)

Apr 14 2020, 2:39 PM · Restricted Project
george.burgess.iv created D78148: [CodeGen] make isTriviallyRecursive handle more trivial recursion.
Apr 14 2020, 1:30 PM · Restricted Project

Apr 13 2020

george.burgess.iv accepted D77736: [DSE] Lift post-dominance for objs not accessible in caller..

LGTM. If no one else comments within a day or so, feel free to land.

Apr 13 2020, 1:34 PM · Restricted Project

Apr 10 2020

george.burgess.iv added a comment to D77736: [DSE] Lift post-dominance for objs not accessible in caller..

Thanks for this!

Apr 10 2020, 3:04 PM · Restricted Project

Apr 7 2020

george.burgess.iv committed rGff30d015222e: [TLI] fix a function's (commented) signature; NFC (authored by george.burgess.iv).
[TLI] fix a function's (commented) signature; NFC
Apr 7 2020, 1:37 PM

Apr 6 2020

george.burgess.iv added a comment to D73763: [DSE] Lift post-dominance restriction..

IIUC, the additional set would be used for the non-alloca cases, as we have to ensure that there are overwrites along all paths to the exit.

Apr 6 2020, 10:51 AM · Restricted Project

Apr 3 2020

george.burgess.iv added a comment to D71082: Allow system header to provide their own implementation of some builtin.

For a more direct comparison, I offer https://godbolt.org/z/fqAhUC . The lack of optimization in the later case is because we're forced to mark the call to __builtin_memcpy in the inline memcpy as nobuiltin. If we instead rename things, this issue doesn't happen: https://godbolt.org/z/FKNTWo.

Apr 3 2020, 4:16 PM · Restricted Project

Apr 1 2020

george.burgess.iv added a comment to D73763: [DSE] Lift post-dominance restriction..

I think there are 2 cases to distinguish:

  1. For accesses to non-alloca objects, this matches what the intrinsic achieves I think. We can only eliminate stores to objects that are visible after the function returns, if they are overwritten along all paths to the exit. So if we have determined a set of blocks that overwrite A (and there are no reads in between), we could check if all paths to the exit from A must go through one of the overwriting blocks. I think that matches your suggestion.
Apr 1 2020, 7:04 PM · Restricted Project

Mar 30 2020

george.burgess.iv added a comment to D73763: [DSE] Lift post-dominance restriction..

Thanks for working on this!

Mar 30 2020, 6:03 PM · Restricted Project

Mar 17 2020

george.burgess.iv accepted D76249: [AliasAnalysis] Misc fixes for checking aliasing with scalable types..

(I really need to circle back and finish the LocationSize migration...)

Mar 17 2020, 3:40 PM · Restricted Project

Mar 10 2020

george.burgess.iv accepted D75942: [x86][seses] No lfences in bb w/ 1 load and 0 stores.

Please wait for a stamp from another reviewer here, too.

Mar 10 2020, 6:05 PM · Restricted Project
george.burgess.iv accepted D75941: [x86][seses] No LFENCEs in basic blocks w/o loads.

LGTM modulo a few cosmetic nits. Similar to the previous review, please wait for approval from someone with more ownership here before landing.

Mar 10 2020, 5:33 PM · Restricted Project
george.burgess.iv accepted D75939: [x86][seses] Introduce SESES pass for LVI.

Thanks so much for working on this!

Mar 10 2020, 5:33 PM · Restricted Project

Mar 9 2020

george.burgess.iv added a comment to D75654: [x86][slh] Move isDataInvariant* functions.

Ack -- I'll do that in the future.

Mar 9 2020, 7:26 PM · Restricted Project
george.burgess.iv committed rG174c3eb69f19: [x86][slh] Move isDataInvariant* functions (authored by george.burgess.iv).
[x86][slh] Move isDataInvariant* functions
Mar 9 2020, 5:17 PM
george.burgess.iv committed rGbb0ec1daff1b: [x86][slh][NFC] Rm redundant liveness check (authored by george.burgess.iv).
[x86][slh][NFC] Rm redundant liveness check
Mar 9 2020, 5:17 PM
george.burgess.iv closed D75654: [x86][slh] Move isDataInvariant* functions.
Mar 9 2020, 5:17 PM · Restricted Project
george.burgess.iv closed D75650: [x86][slh][NFC] Rm redundant liveness check.
Mar 9 2020, 5:17 PM · Restricted Project
george.burgess.iv committed rGcfc3e7f458f8: [cmake] Strip quotes in compiler-rt/lib/crt; error if checks fail (authored by george.burgess.iv).
[cmake] Strip quotes in compiler-rt/lib/crt; error if checks fail
Mar 9 2020, 4:13 PM
george.burgess.iv committed rG20dfcf189d22: [cmake] By default do not build compiler-rt with PGO (authored by george.burgess.iv).
[cmake] By default do not build compiler-rt with PGO
Mar 9 2020, 4:13 PM
george.burgess.iv closed D75499: [cmake] By default do not build compiler-rt with PGO instrumentation or use.
Mar 9 2020, 4:13 PM · Restricted Project, Restricted Project
george.burgess.iv closed D75065: [cmake] Strip quotes in compiler-rt/lib/crt and explicitly throw error if check executable fails.
Mar 9 2020, 4:13 PM · Restricted Project, Restricted Project

Mar 5 2020

george.burgess.iv accepted D75654: [x86][slh] Move isDataInvariant* functions.

thanks for this!

Mar 5 2020, 3:21 PM · Restricted Project

Mar 3 2020

george.burgess.iv planned changes to D75492: [clang-tidy]: modernize-use-using: don't diagnose typedefs in `extern "C"` DeclContexts.

I see -- that seems like a much broader change, but also probably worthwhile. I have a few ideas about how to tackle that; let me see what I can come up with locally.

Mar 3 2020, 1:14 PM · Restricted Project, Restricted Project

Mar 2 2020

george.burgess.iv created D75492: [clang-tidy]: modernize-use-using: don't diagnose typedefs in `extern "C"` DeclContexts.
Mar 2 2020, 4:55 PM · Restricted Project, Restricted Project

Feb 24 2020

george.burgess.iv added a comment to D73994: [InlineCost] Relax bonus restrictions on uninlinable functions.

Friendly ping Gerolf (or anyone else who has opinions on standardish benchmarks) :)

Feb 24 2020, 5:21 PM · Restricted Project

Feb 14 2020

george.burgess.iv added a comment to D73994: [InlineCost] Relax bonus restrictions on uninlinable functions.

I have concerns on so much plumbing changes to make the small heuristic change.

Feb 14 2020, 2:48 PM · Restricted Project

Feb 13 2020

george.burgess.iv added a comment to D73994: [InlineCost] Relax bonus restrictions on uninlinable functions.

ping :)

Feb 13 2020, 11:19 AM · Restricted Project

Feb 8 2020

george.burgess.iv closed D74079: [SimplifyLibCalls] Simplify __strlen_chk.
Feb 8 2020, 12:07 PM · Restricted Project
george.burgess.iv committed rGf8c9ceb1ce9c: [SimplifyLibCalls] Add __strlen_chk. (authored by george.burgess.iv).
[SimplifyLibCalls] Add __strlen_chk.
Feb 8 2020, 11:58 AM
george.burgess.iv added a comment to D74079: [SimplifyLibCalls] Simplify __strlen_chk.

Thanks for the review!

Feb 8 2020, 11:58 AM · Restricted Project

Feb 6 2020

george.burgess.iv added a comment to D73994: [InlineCost] Relax bonus restrictions on uninlinable functions.

Oof, yeah, these look similar, but it's not clear to me if there's a good way to unify them as a part of this patch (or lift this out to there). Lemme poke it a bit and see :)

Feb 6 2020, 5:44 PM · Restricted Project
george.burgess.iv updated the diff for D73994: [InlineCost] Relax bonus restrictions on uninlinable functions.

Updated to plumb through the "are we doing ThinLTO || prelink LTO" bit in a way that makes sense to me. Suggestions for potentially better approaches is welcome :)

Feb 6 2020, 5:44 PM · Restricted Project

Feb 5 2020

george.burgess.iv added inline comments to D74079: [SimplifyLibCalls] Simplify __strlen_chk.
Feb 5 2020, 1:21 PM · Restricted Project
george.burgess.iv created D74079: [SimplifyLibCalls] Simplify __strlen_chk.
Feb 5 2020, 11:12 AM · Restricted Project
george.burgess.iv added a comment to D73994: [InlineCost] Relax bonus restrictions on uninlinable functions.

Yup - I also don't know of any location caching the cost. I wonder if this was a nerver-realized goal, and whether it is abandoned. May be worth checking with the author of the comment?

Feb 5 2020, 11:12 AM · Restricted Project
george.burgess.iv accepted D73853: [llvm-reduce] add ReduceAttribute delta pass.
Feb 5 2020, 10:05 AM · Restricted Project

Feb 4 2020

george.burgess.iv abandoned D49103: Lower llvm.objectsize earlier in our optimization pipeline.

Looks like this was done in https://reviews.llvm.org/D65280; closing

Feb 4 2020, 6:03 PM
george.burgess.iv added a comment to D73994: [InlineCost] Relax bonus restrictions on uninlinable functions.

On the first bullet, I'm trying to find where InlineCost values are cached. Are we doing that?

Feb 4 2020, 2:51 PM · Restricted Project
george.burgess.iv created D73994: [InlineCost] Relax bonus restrictions on uninlinable functions.
Feb 4 2020, 2:05 PM · Restricted Project
george.burgess.iv added a comment to D71082: Allow system header to provide their own implementation of some builtin.

Until recently, both CrOS and Android disabled FORTIFY wholesale when any of asan/msan/tsan were active. Bionic recently got support for FORTIFY playing nicely with sanitizers, but that support boils down to "turn off all the FORTIFY runtime checks, but leave the ones that generate compiler diags on."

Feb 4 2020, 1:28 PM · Restricted Project

Feb 3 2020

george.burgess.iv added a comment to D73853: [llvm-reduce] add ReduceAttribute delta pass.

LGTM after this last nit is addressed. Like said, I plan to leave the final stamp to someone with more context. Thanks again!

Feb 3 2020, 3:44 PM · Restricted Project

Feb 2 2020

george.burgess.iv added inline comments to D73679: [MemoryBuiltins] Determine the size of a global w/o initializer.
Feb 2 2020, 11:04 PM · Restricted Project
george.burgess.iv added a comment to D73853: [llvm-reduce] add ReduceAttribute delta pass.

Thanks for this! I'm always happy to see reduction tooling gain new powers :)

Feb 2 2020, 3:02 PM · Restricted Project
george.burgess.iv added a comment to D73679: [MemoryBuiltins] Determine the size of a global w/o initializer.

So there are existing test with 0 sized objects that would fail if we do not have the Size != 0 check but I'll add a few more to nail down what we expect as soon as I find the time. It might take a week or two though.

Feb 2 2020, 2:58 PM · Restricted Project

Jan 30 2020

george.burgess.iv added a comment to D73679: [MemoryBuiltins] Determine the size of a global w/o initializer.

Thanks for this!

Jan 30 2020, 5:28 PM · Restricted Project

Jan 25 2020

george.burgess.iv committed rG2f45a93edfe4: [Support] `const`ify a method; NFC (authored by george.burgess.iv).
[Support] `const`ify a method; NFC
Jan 25 2020, 9:55 PM

Jan 16 2020

george.burgess.iv added a comment to D71082: Allow system header to provide their own implementation of some builtin.

(It's interesting to me if gcc doesn't warn about that libcxx code, since the whole point of the gnuc 5.0 check there was "the compiler should check this for us now"...)

Jan 16 2020, 10:13 AM · Restricted Project

Dec 12 2019

george.burgess.iv added a comment to D71082: Allow system header to provide their own implementation of some builtin.

Just a few more nits, and this LGTM. Thanks again!

Dec 12 2019, 1:18 PM · Restricted Project

Dec 11 2019

george.burgess.iv added inline comments to D71082: Allow system header to provide their own implementation of some builtin.
Dec 11 2019, 1:42 PM · Restricted Project
george.burgess.iv added a comment to D71082: Allow system header to provide their own implementation of some builtin.

Should we also have a quick test-case in Sema/ verifying that we still get the warnings that Eli mentioned?

Dec 11 2019, 10:30 AM · Restricted Project

Dec 5 2019

george.burgess.iv committed rG9b9327fe3064: llvm-reduce: Add a space to an option's --help (authored by george.burgess.iv).
llvm-reduce: Add a space to an option's --help
Dec 5 2019, 7:48 PM
george.burgess.iv added a comment to D71082: Allow system header to provide their own implementation of some builtin.

Thanks for looking into this!

Dec 5 2019, 1:22 PM · Restricted Project

Dec 4 2019

george.burgess.iv added a comment to rG380a6452b2e9: [ASTMatchers] work around a miscompile; "NFC".

Thanks for reviewing!

Dec 4 2019, 9:23 AM

Nov 22 2019

george.burgess.iv committed rG380a6452b2e9: [ASTMatchers] work around a miscompile; "NFC" (authored by george.burgess.iv).
[ASTMatchers] work around a miscompile; "NFC"
Nov 22 2019, 8:20 PM
george.burgess.iv committed rG9f13a032b6d7: clang-tidy: don't use an absolute path in a test (authored by george.burgess.iv).
clang-tidy: don't use an absolute path in a test
Nov 22 2019, 6:13 PM

Oct 15 2019

george.burgess.iv added a comment to D68670: [Utils] Cleanup similar cases to MergeBlockIntoPredecessor..

I don't immediately see any issues with this patch, but it's outside of my area of expertise, so I'll defer to the other reviewers :)

Oct 15 2019, 11:26 AM · Restricted Project

Oct 10 2019

george.burgess.iv accepted D68809: [MemorySSA] Additional handling of unreachable blocks..

Thanks!

Oct 10 2019, 1:07 PM · Restricted Project

Oct 8 2019

george.burgess.iv accepted D68659: [MemorySSA] Make the use of moveAllAfterMergeBlocks consistent..

Thanks for this!

Oct 8 2019, 8:49 PM · Restricted Project

Sep 30 2019

george.burgess.iv added a comment to D38479: Make -mgeneral-regs-only more like GCC's.

Does this have any significant impact on -fsyntax-only performance?

Sep 30 2019, 5:36 PM · Restricted Project
george.burgess.iv updated the diff for D38479: Make -mgeneral-regs-only more like GCC's.

Addressed feedback

Sep 30 2019, 5:33 PM · Restricted Project

Sep 25 2019

george.burgess.iv accepted D67995: [MemorySSA] Avoid adding Phis in the presence of unreachable blocks..

Thanks!

Sep 25 2019, 2:23 PM · Restricted Project

Sep 23 2019

george.burgess.iv accepted D67927: [MemorySSA] Update Phi insertion..

LGTM, since this is a workaround to keep things rolling while we work on a more general fix.

Sep 23 2019, 3:24 PM · Restricted Project

Sep 16 2019

george.burgess.iv accepted D67637: [MemorySSA] Fix phi insertion when inserting a def..

thanks!

Sep 16 2019, 8:52 PM · Restricted Project
george.burgess.iv accepted D67562: [MemorySSA] Update MSSA for non-conventional AA..

Thanks!

Sep 16 2019, 8:49 PM · Restricted Project
george.burgess.iv added a comment to D38479: Make -mgeneral-regs-only more like GCC's.

Apologies for the latency of my updates.

Sep 16 2019, 6:25 PM · Restricted Project
george.burgess.iv updated the diff for D38479: Make -mgeneral-regs-only more like GCC's.

Chatted with Eli offline; updated here to reflect the conclusions of that.

Sep 16 2019, 6:25 PM · Restricted Project

Sep 13 2019

george.burgess.iv added a comment to D67562: [MemorySSA] Update MSSA for non-conventional AA..

thanks for this!

Sep 13 2019, 6:41 PM · Restricted Project

Sep 11 2019

george.burgess.iv accepted D67470: [MemorySSA] Pass (for update) MSSAU when hoisting instructions..

Thanks for this!

Sep 11 2019, 5:03 PM · Restricted Project

Sep 10 2019

george.burgess.iv accepted D67307: [MemorySSA] Do not create memoryaccesses for debug info intrinsics..

thanks!

Sep 10 2019, 3:12 PM · Restricted Project

Sep 6 2019

george.burgess.iv added a comment to D67296: [MemorySSA] Update defining access when instructions are not cloned..

(Now that we have D67307, is this still needed? Happy to review if so, but this seems to be addressing primarily debuginfo-related bits)

Sep 6 2019, 11:10 PM · Restricted Project
george.burgess.iv added a comment to D67307: [MemorySSA] Do not create memoryaccesses for debug info intrinsics..

Thanks for this!

Sep 6 2019, 11:08 PM · Restricted Project

Aug 20 2019

george.burgess.iv accepted D66495: [MemorySSA] Fix existing phis when inserting defs..

Thanks!

Aug 20 2019, 2:57 PM · Restricted Project
george.burgess.iv accepted D66454: [MemorySSA] Make Phi cleanups consistent..

Assuming the test in D66495 (in part) covers this, LGTM with an optional nit.

Aug 20 2019, 2:57 PM · Restricted Project

Aug 15 2019

george.burgess.iv accepted D66033: [MemorySSA] Rename uses when inserting memory uses..

lgtm with a few nits. Thanks!

Aug 15 2019, 5:18 PM · Restricted Project

Aug 5 2019

george.burgess.iv committed rGa5c25c5d469f: [Sema] attempt to appease buildbots after r367940 (authored by george.burgess.iv).
[Sema] attempt to appease buildbots after r367940
Aug 5 2019, 4:24 PM
george.burgess.iv committed rGf708f0a2430f: [Sema] Add -Wpointer-compare (authored by george.burgess.iv).
[Sema] Add -Wpointer-compare
Aug 5 2019, 3:18 PM

Aug 1 2019

george.burgess.iv accepted D65568: [AliasAnalysis] Initialize a member variable that may be used by unit test..

Thanks!

Aug 1 2019, 10:48 AM · Restricted Project