This is an archive of the discontinued LLVM Phabricator instance.

Differential D91934

[lldb] [Process/FreeBSD] Add missing 'override' kws to POSIXStopInfo
ClosedPublic

Authored by mgorny on Nov 22 2020, 8:43 AM.

Details

Reviewers
emaste
krytarowski
labath
Commits
rG7b7c372e3fca: [lldb] [Process/FreeBSD] Add missing 'override' kws to POSIXStopInfo

Diff Detail

Event Timeline

mgorny requested review of this revision.Nov 22 2020, 8:43 AM
mgorny created this revision.
krytarowski accepted this revision.Nov 23 2020, 12:16 AM
This revision is now accepted and ready to land.Nov 23 2020, 12:16 AM
labath accepted this revision.Nov 23 2020, 12:17 AM

I don't think you need to spin up reviews for trivial fixes such as this.

Closed by commit rG7b7c372e3fca: [lldb] [Process/FreeBSD] Add missing 'override' kws to POSIXStopInfo (authored by mgorny). · Explain WhyNov 23 2020, 12:24 AM
This revision was automatically updated to reflect the committed changes.
mgorny added a commit: rG7b7c372e3fca: [lldb] [Process/FreeBSD] Add missing 'override' kws to POSIXStopInfo.
Herald added a project: Restricted Project. · View Herald TranscriptNov 23 2020, 12:24 AM

Revision Contents

PathSize
lldb/
source/
Plugins/
Process/
FreeBSD/
16 lines

Diff 306963

lldb/source/Plugins/Process/FreeBSD/POSIXStopInfo.h

Show All 28 Lines
/// Represents the stop state of a process ready to exit. /// Represents the stop state of a process ready to exit.
/// ///
class POSIXLimboStopInfo : public POSIXStopInfo { class POSIXLimboStopInfo : public POSIXStopInfo {
public: public:
POSIXLimboStopInfo(FreeBSDThread &thread) : POSIXStopInfo(thread, 0) {} POSIXLimboStopInfo(FreeBSDThread &thread) : POSIXStopInfo(thread, 0) {}
~POSIXLimboStopInfo(); ~POSIXLimboStopInfo();
lldb::StopReason GetStopReason() const; lldb::StopReason GetStopReason() const override;
const char *GetDescription(); const char *GetDescription() override;
bool ShouldStop(lldb_private::Event *event_ptr); bool ShouldStop(lldb_private::Event *event_ptr) override;
bool ShouldNotify(lldb_private::Event *event_ptr); bool ShouldNotify(lldb_private::Event *event_ptr) override;
}; };
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
/// \class POSIXNewThreadStopInfo /// \class POSIXNewThreadStopInfo
/// Represents the stop state of process when a new thread is spawned. /// Represents the stop state of process when a new thread is spawned.
/// ///
class POSIXNewThreadStopInfo : public POSIXStopInfo { class POSIXNewThreadStopInfo : public POSIXStopInfo {
public: public:
POSIXNewThreadStopInfo(FreeBSDThread &thread) : POSIXStopInfo(thread, 0) {} POSIXNewThreadStopInfo(FreeBSDThread &thread) : POSIXStopInfo(thread, 0) {}
~POSIXNewThreadStopInfo(); ~POSIXNewThreadStopInfo();
lldb::StopReason GetStopReason() const; lldb::StopReason GetStopReason() const override;
const char *GetDescription(); const char *GetDescription() override;
bool ShouldStop(lldb_private::Event *event_ptr); bool ShouldStop(lldb_private::Event *event_ptr) override;
bool ShouldNotify(lldb_private::Event *event_ptr); bool ShouldNotify(lldb_private::Event *event_ptr) override;
}; };
#endif #endif