Page MenuHomePhabricator

[lldb] [test] Fix qRegisterInfo lldb-server test to handle missing registers
ClosedPublic

Authored by mgorny on Sat, Nov 21, 1:19 PM.

Details

Summary

Fix qRegisterInfo tests to handle Exx error response when querying
registers that are not supported on the platform in question. This
is how FreeBSD and NetBSD platforms reporting missing registers right
now, and there certainly is value from verifying the remaining
registers.

This change fixes the test for FreeBSD but NetBSD has other regressions
that still need to be researched.

Diff Detail

Event Timeline

mgorny created this revision.Sat, Nov 21, 1:19 PM
mgorny requested review of this revision.Sat, Nov 21, 1:19 PM
labath accepted this revision.Mon, Nov 23, 12:20 AM

Looks good. I'd rephrase the commit title to make it clearer this only changes the single test, and does not change behavior otherwise...

lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
588

Maybe add a TODO to remove this once we're able to actually make registers disappear.

This revision is now accepted and ready to land.Mon, Nov 23, 12:20 AM
mgorny retitled this revision from [lldb] Fix qRegisterInfo to handle missing registers to [lldb] [test] Fix qRegisterInfo lldb-server test to handle missing registers.Mon, Nov 23, 12:22 AM
mgorny marked an inline comment as done.Mon, Nov 23, 12:26 AM

Ok, will add the comment and push.

Herald added a project: Restricted Project. · View Herald TranscriptMon, Nov 23, 12:28 AM