Page MenuHomePhabricator

[12/N] [libcxx] Sanitize paths before creating symlinks on windows
AcceptedPublic

Authored by mstorsjo on Tue, Nov 10, 1:48 AM.

Details

Reviewers
ldionne
amccarth
Group Reviewers
Restricted Project
Summary

The STL does even more cleanup (corresponding to lexically_normal I think), but this seems to be the very minimum needed for making the symlinks work when the target path contains non-native paths.

I guess this could be squashed into patch 11, but this adds a test case for making sure the created symlinks really work.

Diff Detail

Event Timeline

mstorsjo created this revision.Tue, Nov 10, 1:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Nov 10, 1:49 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
ldionne accepted this revision.Tue, Nov 10, 4:31 AM
This revision is now accepted and ready to land.Tue, Nov 10, 4:31 AM
ldionne added a subscriber: EricWF.Tue, Nov 10, 4:32 AM

@EricWF can you have a look at this?

rnk removed a reviewer: rnk.Tue, Nov 10, 12:27 PM
amccarth accepted this revision.Thu, Dec 3, 2:25 PM

LGTM