Page MenuHomePhabricator

[libunwind] Add -Wno-dll-attribute-on-redeclaration when building for windows
ClosedPublic

Authored by mstorsjo on Oct 23 2020, 1:27 PM.

Details

Summary

It's not worth trying to fix these warnings within libunwind, instead silence them.

Diff Detail

Event Timeline

mstorsjo created this revision.Oct 23 2020, 1:27 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 23 2020, 1:27 PM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
mstorsjo requested review of this revision.Oct 23 2020, 1:27 PM
rnk accepted this revision.Oct 23 2020, 1:29 PM

Lgtm

compnerd accepted this revision.Oct 26 2020, 10:35 AM

I would be fine with adding the decoration to the headers as well, but this seems reasonable.

This revision is now accepted and ready to land.Oct 26 2020, 10:35 AM