Page MenuHomePhabricator

[NFC][Regalloc] Pass VirtRegMap by reference.
ClosedPublic

Authored by mtrofin on Oct 9 2020, 4:46 PM.

Details

Summary

It's never null - the reason it's modeled as a pointer is because the
pass can't init it in its ctor. Passing by ref simplifies the code, too,
as the null checks were unnecessary complexity.

Diff Detail

Event Timeline

mtrofin created this revision.Oct 9 2020, 4:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 9 2020, 4:46 PM
mtrofin requested review of this revision.Oct 9 2020, 4:46 PM
MaskRay accepted this revision.Oct 9 2020, 8:25 PM

Looks great!

This revision is now accepted and ready to land.Oct 9 2020, 8:25 PM
This revision was automatically updated to reflect the committed changes.