Page MenuHomePhabricator

gjain (Gaurav Jain)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 16 2020, 11:30 AM (38 w, 4 d)

Recent Activity

Dec 11 2020

gjain added a comment to D93139: Make debug dump more friendly to conditional debug compilation.

@mtrofin: Thanks that works. That being said do you think that's a suitable necessity for the entire binary? Seems like all those dump functions don't really need to be included in the binary.

Dec 11 2020, 10:09 PM · Restricted Project
gjain requested review of D93139: Make debug dump more friendly to conditional debug compilation.
Dec 11 2020, 11:59 AM · Restricted Project

Dec 2 2020

gjain added inline comments to D92341: [NFC][MC] TargetRegisterInfo::getSubReg is a MCRegister..
Dec 2 2020, 10:19 AM · Restricted Project

Nov 18 2020

gjain accepted D91759: [NFC][TFUtils] also include output specs lookup logic in loadOutputSpecs.
Nov 18 2020, 9:05 PM · Restricted Project
gjain committed rG06fcc4f06f14: [NFC] Use [MC]Register for Hexagon target (authored by gjain).
[NFC] Use [MC]Register for Hexagon target
Nov 18 2020, 8:20 AM
gjain closed D91160: [NFC] Use [MC]Register for Hexagon target.
Nov 18 2020, 8:19 AM · Restricted Project

Nov 10 2020

gjain committed rGa0b712976734: [NFC] Use [MC]Register in TwoAddressInstructionPass (authored by gjain).
[NFC] Use [MC]Register in TwoAddressInstructionPass
Nov 10 2020, 7:02 PM
gjain closed D90902: [NFC] Use [MC]Register in TwoAddressInstructionPass.
Nov 10 2020, 7:02 PM · Restricted Project
gjain committed rG3726b14428a6: [NFC] Use [MC]Register for x86 target (authored by gjain).
[NFC] Use [MC]Register for x86 target
Nov 10 2020, 3:50 PM
gjain closed D91161: [NFC] Use [MC]Register for x86 target.
Nov 10 2020, 3:50 PM · Restricted Project
gjain updated the diff for D91160: [NFC] Use [MC]Register for Hexagon target.

Fix Sub to be unsigned

Nov 10 2020, 3:34 PM · Restricted Project
gjain added a comment to D91160: [NFC] Use [MC]Register for Hexagon target.

I'd definitely prefer not cleaning up RegisterRef as part of this patch. The register/sub tuple pattern is present throughout the code and needs an independant clean-up. Otherwise we risk this not being a NFC.

Nov 10 2020, 3:32 PM · Restricted Project
gjain added inline comments to D91161: [NFC] Use [MC]Register for x86 target.
Nov 10 2020, 7:46 AM · Restricted Project
gjain updated the diff for D91161: [NFC] Use [MC]Register for x86 target.

Fix Typo

Nov 10 2020, 7:46 AM · Restricted Project
gjain updated the diff for D91161: [NFC] Use [MC]Register for x86 target.

Fixed a few additional instances

Nov 10 2020, 7:37 AM · Restricted Project
gjain requested review of D91161: [NFC] Use [MC]Register for x86 target.
Nov 10 2020, 6:59 AM · Restricted Project
gjain requested review of D91160: [NFC] Use [MC]Register for Hexagon target.
Nov 10 2020, 6:49 AM · Restricted Project

Nov 5 2020

gjain requested review of D90902: [NFC] Use [MC]Register in TwoAddressInstructionPass.
Nov 5 2020, 10:38 PM · Restricted Project
gjain accepted D90795: [NFC] Use [MC]Register.
Nov 5 2020, 10:37 PM · Restricted Project

Nov 4 2020

gjain added inline comments to D90724: [NFC] Use Register/MCRegister.
Nov 4 2020, 10:06 AM · Restricted Project

Nov 3 2020

gjain committed rG492b1d78d5c5: [NFC] Use [MC]Register in register allocation (authored by gjain).
[NFC] Use [MC]Register in register allocation
Nov 3 2020, 5:36 PM
gjain closed D90725: [NFC] Use [MC]Register in register allocation.
Nov 3 2020, 5:36 PM · Restricted Project
gjain added inline comments to D90725: [NFC] Use [MC]Register in register allocation.
Nov 3 2020, 4:29 PM · Restricted Project
gjain updated the diff for D90725: [NFC] Use [MC]Register in register allocation.

Address comments

Nov 3 2020, 4:29 PM · Restricted Project
gjain accepted D90724: [NFC] Use Register/MCRegister.
Nov 3 2020, 3:54 PM · Restricted Project
gjain requested review of D90725: [NFC] Use [MC]Register in register allocation.
Nov 3 2020, 3:48 PM · Restricted Project

Nov 2 2020

gjain committed rGb68994bd2d35: [NFC] Use [MC]Register in Live-ness tracking (authored by gjain).
[NFC] Use [MC]Register in Live-ness tracking
Nov 2 2020, 3:46 PM
gjain closed D90611: [NFC] Use [MC]Register in Live-ness tracking.
Nov 2 2020, 3:46 PM · Restricted Project
gjain requested review of D90611: [NFC] Use [MC]Register in Live-ness tracking.
Nov 2 2020, 7:33 AM · Restricted Project

Oct 31 2020

gjain accepted D90506: [NFC][regalloc] Use MCRegister appropriately.
Oct 31 2020, 1:33 AM · Restricted Project

Oct 28 2020

gjain committed rGf719fd7adee1: [NFC] Use [MC]Register in CSE & LICM (authored by gjain).
[NFC] Use [MC]Register in CSE & LICM
Oct 28 2020, 3:54 PM
gjain closed D90327: [NFC] Use [MC]Register in CSE & LICM.
Oct 28 2020, 3:53 PM · Restricted Project
gjain requested review of D90327: [NFC] Use [MC]Register in CSE & LICM.
Oct 28 2020, 11:51 AM · Restricted Project

Oct 27 2020

gjain accepted D90268: [NFC] Use Register in RegisterPressure APIs.
Oct 27 2020, 2:40 PM · Restricted Project

Oct 26 2020

gjain committed rG17cdba61d436: [NFC] Use [MC]Register in RegAllocPBQP & RegisterCoalescer (authored by gjain).
[NFC] Use [MC]Register in RegAllocPBQP & RegisterCoalescer
Oct 26 2020, 5:14 PM
gjain closed D90008: [NFC] Use [MC]Register in RegAllocPBQP & RegisterCoalescer.
Oct 26 2020, 5:14 PM · Restricted Project
gjain added inline comments to D90008: [NFC] Use [MC]Register in RegAllocPBQP & RegisterCoalescer.
Oct 26 2020, 2:28 PM · Restricted Project
gjain updated the diff for D90008: [NFC] Use [MC]Register in RegAllocPBQP & RegisterCoalescer.

Address comments

Oct 26 2020, 2:28 PM · Restricted Project

Oct 23 2020

gjain added inline comments to D90008: [NFC] Use [MC]Register in RegAllocPBQP & RegisterCoalescer.
Oct 23 2020, 9:31 AM · Restricted Project
gjain updated the diff for D90008: [NFC] Use [MC]Register in RegAllocPBQP & RegisterCoalescer.

Address comments

Oct 23 2020, 9:25 AM · Restricted Project

Oct 22 2020

gjain requested review of D90008: [NFC] Use [MC]Register in RegAllocPBQP & RegisterCoalescer.
Oct 22 2020, 9:39 PM · Restricted Project
gjain accepted D89975: [NFC] Use [MC]Register in RegAllocGreedy.
Oct 22 2020, 10:42 AM · Restricted Project

Oct 21 2020

gjain committed rG4634ad6c0bf8: [NFC] Set return type of getStackPointerRegisterToSaveRestore to Register (authored by gjain).
[NFC] Set return type of getStackPointerRegisterToSaveRestore to Register
Oct 21 2020, 4:24 PM
gjain closed D89858: [NFC] Set return type of getStackPointerRegisterToSaveRestore to Register.
Oct 21 2020, 4:24 PM · Restricted Project
gjain added a comment to D81515: [llvm] Release-mode ML InlineAdvisor.

Would you provide scripts to load the model and see the layers?

Re. second question, visualization - this is a question for Yundi, Gaurav, or Eugene (they are the ML experts). I'll venture "tensorboard" as an answer, but I'll make sure they give the authoritative one in a moment.

Oct 21 2020, 4:04 PM · Restricted Project
gjain accepted D89912: [NFC][MC] Use MCRegister for ReachingDefAnalysis APIs.
Oct 21 2020, 3:10 PM · Restricted Project
gjain retitled D89858: [NFC] Set return type of getStackPointerRegisterToSaveRestore to Register from Set return type of getStackPointerRegisterToSaveRestore to Register to [NFC] Set return type of getStackPointerRegisterToSaveRestore to Register.
Oct 21 2020, 3:01 PM · Restricted Project
gjain requested review of D89858: [NFC] Set return type of getStackPointerRegisterToSaveRestore to Register.
Oct 21 2020, 1:17 AM · Restricted Project

Oct 20 2020

gjain accepted D89815: [NFC][MC] Use [MC]Register in MachineVerifier.
Oct 20 2020, 12:27 PM · Restricted Project
gjain accepted D89718: [NFC][Regalloc] Type 2 statics in terms of Register.
Oct 20 2020, 10:16 AM · Restricted Project

Oct 19 2020

gjain accepted D89710: [NFC][MC] Type [MC]Register uses in MachineTraceMetrics.
Oct 19 2020, 9:32 AM · Restricted Project

Oct 13 2020

gjain accepted D89328: [NFC][MC] Use MCRegister in Machine{Sink|Pipeliner}.cpp.
Oct 13 2020, 12:08 PM · Restricted Project

Oct 12 2020

gjain accepted D89250: [NFC][Regalloc] Use MCRegister in MachineCopyPropagation.
Oct 12 2020, 12:48 PM · Restricted Project

Oct 9 2020

gjain accepted D89145: [NFC][MC] Use MCRegister in LiveRangeMatrix.
Oct 9 2020, 11:10 AM · Restricted Project

Oct 8 2020

gjain accepted D89018: [NFC][MC] MCRegister API typing..
Oct 8 2020, 11:22 AM · Restricted Project

Oct 7 2020

gjain added inline comments to D89018: [NFC][MC] MCRegister API typing..
Oct 7 2020, 9:04 PM · Restricted Project

Oct 6 2020

gjain accepted D88930: [NFC][regalloc] Use MCRegister instead of unsigned in InterferenceCache.
Oct 6 2020, 2:45 PM · Restricted Project

Oct 5 2020

gjain accepted D88862: [NFC][MC] Type uses of MCRegUnitIterator as MCRegister.
Oct 5 2020, 8:25 PM · Restricted Project
gjain requested changes to D88770: [MLInliner] Factor out logging.

Very minor comments...

Oct 5 2020, 4:15 PM · Restricted Project

Oct 2 2020

gjain accepted D88705: [MC] Assert that MCRegUnitIterator operates over MCRegisters.
Oct 2 2020, 10:53 AM · Restricted Project

Sep 16 2020

gjain accepted D87768: [NFC][regalloc] type LiveInterval::reg() as Register.
Sep 16 2020, 1:06 PM · Restricted Project