[07/10] ELF/Aarch64: Internal variable cleanup

[zatrazz]

Summary

Hi ruiu, shankarke,

This is re-post of a previous attempt. This patch makes the AArch64GotAtomContent, AArch64Plt0AtomContent, and
AArch64PltAtomContent static and also cleanup their formatting.

[ruiu]

LGTM. It is recommended by the LLVM's coding style to keep the length of
anonymous namespaces as small as possible. So please move these now-file
scope variables outside the anonymous namespace.

lib/ReaderWriter/ELF/AArch64/AArch64RelocationPass.cpp

 #include "llvm/ADT/STLExtras.h"
 #include "llvm/Support/Debug.h"
 
 using namespace lld;
 using namespace lld::elf;
 using namespace llvm::ELF;
 
 namespace {
+
 // .got values
-const uint8_t AArch64GotAtomContent[8] = {0};
+static const uint8_t AArch64GotAtomContent[8] = {0};
 
 // .plt value (entry 0)
-const uint8_t AArch64Plt0AtomContent[32] = {
-    0xf0, 0x7b, 0xbf,
-    0xa9, // stp  x16, x30, [sp,#-16]!
-    0x10, 0x00, 0x00,
-    0x90, // adrp x16, Page(eh_frame)
-    0x11, 0x02, 0x40,
-    0xf9, // ldr  x17, [x16,#offset]
-    0x10, 0x02, 0x00,
-    0x91, // add  x16, x16, #offset
-    0x20, 0x02, 0x1f,
-    0xd6, // br x17
-    0x1f, 0x20, 0x03,
-    0xd5, // nop
-    0x1f, 0x20, 0x03,
-    0xd5, // nop
-    0x1f, 0x20, 0x03,
-    0xd5 // nop
+static const uint8_t AArch64Plt0AtomContent[32] = {
+    0xf0, 0x7b, 0xbf, 0xa9, // stp  x16, x30, [sp,#-16]!
+    0x10, 0x00, 0x00, 0x90, // adrp  x16, Page(eh_frame)
+    0x11, 0x02, 0x40, 0xf9, // ldr  x17, [x16,#offset]
+    0x10, 0x02, 0x00, 0x91, // add  x16, x16, #offset
+    0x20, 0x02, 0x1f, 0xd6, // br  x17
+    0x1f, 0x20, 0x03, 0xd5, // nop
+    0x1f, 0x20, 0x03, 0xd5, // nop
+    0x1f, 0x20, 0x03, 0xd5  // nop
 };
 
 // .plt values (other entries)
-const uint8_t AArch64PltAtomContent[16] = {
-    0x10, 0x00, 0x00,
-    0x90, // adrp x16, PAGE(<GLOBAL_OFFSET_TABLE>)
-    0x11, 0x02, 0x40,
-    0xf9, // ldr x17, [x16,#offset]
-    0x10, 0x02, 0x00,
-    0x91, // add x16, x16, #offset
-    0x20, 0x02, 0x1f,
-    0xd6 // br x17
+static const uint8_t AArch64PltAtomContent[16] = {
+    0x10, 0x00, 0x00, 0x90, // adrp x16, PAGE(<GLOBAL_OFFSET_TABLE>)
+    0x11, 0x02, 0x40, 0xf9, // ldr  x17, [x16,#offset]
+    0x10, 0x02, 0x00, 0x91, // add  x16, x16, #offset
+    0x20, 0x02, 0x1f, 0xd6  // br   x17
 };
 
 /// \brief Atoms that are used by AArch64 dynamic linking
 class AArch64GOTAtom : public GOTAtom {
 public:
   AArch64GOTAtom(const File &f, StringRef secName) : GOTAtom(f, secName) {}
 
   ArrayRef<uint8_t> rawContent() const override {