Page MenuHomePhabricator

zatrazz (Adhemerval Zanella)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2015, 12:58 PM (293 w, 4 d)

Recent Activity

Mon, Oct 12

zatrazz added a comment to D86453: [AArch64] Support conversion between fp16 and fp128.

Ping (x3).

Mon, Oct 12, 10:37 AM · Restricted Project, Restricted Project
zatrazz committed rG039126c97d39: [sanitizer] Disable fast_unwind_on_malloc as default for arm-linux-gnu (authored by zatrazz).
[sanitizer] Disable fast_unwind_on_malloc as default for arm-linux-gnu
Mon, Oct 12, 10:36 AM
zatrazz closed D88958: [sanitizer] Disable fast_unwind_on_malloc as default for arm-linux-gnu.
Mon, Oct 12, 10:36 AM · Restricted Project

Wed, Oct 7

zatrazz requested review of D88958: [sanitizer] Disable fast_unwind_on_malloc as default for arm-linux-gnu.
Wed, Oct 7, 5:14 AM · Restricted Project
zatrazz abandoned D83134: [asan] Disable fast unwinder on arm-linux-gnueabi with thumb.
Wed, Oct 7, 5:14 AM · Restricted Project

Mon, Oct 5

zatrazz added a comment to D86453: [AArch64] Support conversion between fp16 and fp128.

Ping (x2).

Mon, Oct 5, 6:35 AM · Restricted Project, Restricted Project

Tue, Sep 29

zatrazz added a comment to D86453: [AArch64] Support conversion between fp16 and fp128.

Ping.

Tue, Sep 29, 5:33 AM · Restricted Project, Restricted Project

Sep 8 2020

zatrazz added inline comments to D86453: [AArch64] Support conversion between fp16 and fp128.
Sep 8 2020, 12:58 PM · Restricted Project, Restricted Project
zatrazz added inline comments to D86453: [AArch64] Support conversion between fp16 and fp128.
Sep 8 2020, 11:51 AM · Restricted Project, Restricted Project
zatrazz added a comment to D86453: [AArch64] Support conversion between fp16 and fp128.

Ping.

Sep 8 2020, 4:58 AM · Restricted Project, Restricted Project

Sep 1 2020

zatrazz updated the diff for D86453: [AArch64] Support conversion between fp16 and fp128.

I have adapted the news files using clang-format and fixed minor style issues pointed by previous comments.

Sep 1 2020, 10:43 AM · Restricted Project, Restricted Project

Aug 31 2020

zatrazz updated the diff for D86453: [AArch64] Support conversion between fp16 and fp128.

Updated patch based on previous comments.

Aug 31 2020, 10:46 AM · Restricted Project, Restricted Project
zatrazz added inline comments to D86453: [AArch64] Support conversion between fp16 and fp128.
Aug 31 2020, 10:43 AM · Restricted Project, Restricted Project

Aug 27 2020

zatrazz added a comment to D86453: [AArch64] Support conversion between fp16 and fp128.

Hi atrosinenko, do you think this patch need any more change on the testing side?
The fp_lib.h/int_lib.h change would most likely require in a more complex without
much gain in organization imho.

Aug 27 2020, 4:45 AM · Restricted Project, Restricted Project

Aug 25 2020

zatrazz added inline comments to D86453: [AArch64] Support conversion between fp16 and fp128.
Aug 25 2020, 6:47 AM · Restricted Project, Restricted Project

Aug 24 2020

zatrazz updated the diff for D86453: [AArch64] Support conversion between fp16 and fp128.

Updated version based on previous comments.

Aug 24 2020, 1:57 PM · Restricted Project, Restricted Project
zatrazz added inline comments to D86453: [AArch64] Support conversion between fp16 and fp128.
Aug 24 2020, 1:47 PM · Restricted Project, Restricted Project
zatrazz requested review of D86453: [AArch64] Support conversion between fp16 and fp128.
Aug 24 2020, 6:07 AM · Restricted Project, Restricted Project
zatrazz added a comment to D83134: [asan] Disable fast unwinder on arm-linux-gnueabi with thumb.

Is this patch still needed?

Aug 24 2020, 6:00 AM · Restricted Project

Jul 8 2020

zatrazz added a comment to D83134: [asan] Disable fast unwinder on arm-linux-gnueabi with thumb.

Is unwinding actually broken on an all-clang, all-thumb system?

Jul 8 2020, 5:21 AM · Restricted Project

Jul 3 2020

zatrazz created D83134: [asan] Disable fast unwinder on arm-linux-gnueabi with thumb.
Jul 3 2020, 8:02 AM · Restricted Project

Jan 10 2020

zatrazz abandoned D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test.
Jan 10 2020, 12:24 PM · Restricted Project

Jan 9 2020

zatrazz added a comment to D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test.

I'm fine with this workaround although I'm very surprised that the test is not working. Especially since deterministic-archive.test and replace-update.test also set TZ to get reproducible output

Do you have access to any of the failing bots? If so what happens there if you change the TZ variable?
I get the following on all systems I have access to when I run something like date && date -u && env TZ=CET date && env TZ=CET date -u && env TZ=BST date && env TZ=BST date -u I get the following output:

Thu  9 Jan 2020 20:18:10 GMT
Thu  9 Jan 2020 20:18:10 UTC
Thu  9 Jan 2020 21:18:10 CET
Thu  9 Jan 2020 20:18:10 UTC
Thu  9 Jan 2020 20:18:10 UTC
Thu  9 Jan 2020 20:18:10 UTC
Jan 9 2020, 1:32 PM · Restricted Project
zatrazz added a comment to D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test.

I was careful in the test to use TZ=UTC for all commands printing dates and it works fine for me in UTC+1 and in the UK which is currently UTC. Does the bot in question ignore the TZ variable?

Jan 9 2020, 1:13 PM · Restricted Project
zatrazz added inline comments to D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test.
Jan 9 2020, 11:20 AM · Restricted Project
zatrazz updated the diff for D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test.

Updated patch based on previous comments.

Jan 9 2020, 11:20 AM · Restricted Project
zatrazz created D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test.
Jan 9 2020, 6:37 AM · Restricted Project

Dec 31 2019

zatrazz added a comment to D69151: [gicombiner] Import tryCombineIndexedLoadStore().

I am investigating a recurring regression on arm-linux bots and bisecting the commits on the build [1] that introduced the regression it points to this one. By reverting I can build the stage1 (I am testing now the stage2). I seems to only happen on arm-linux bots, I didn't see it on aarch64-linux ones.

Dec 31 2019, 10:12 AM · Restricted Project

Dec 30 2019

zatrazz added a comment to D71111: [Sema] Improve diagnostic about addr spaces for overload candidates.

I am investigating a recurring regression on aarch64-linux bots and bisecting the commits on the build [1] that introduced the regression it points to this one. I don't understand exactly what is triggering the issue, but it only happen on the stage2 build with stage1 clang built with different compilers (gcc 5.4, gcc-7.4.0, and gcc-8.3.0). The issue is on clang itself while trying to execute the Analysis/uninit-sometimes.cpp test:

Dec 30 2019, 5:41 AM · Restricted Project

Oct 7 2019

zatrazz abandoned D67733: Fix gdb_pretty_printer_test on python3.
Oct 7 2019, 5:43 AM · Restricted Project

Sep 25 2019

zatrazz committed rG6023cf223446: [libcxxabi] Fix arm build failer with libgcc (authored by zatrazz).
[libcxxabi] Fix arm build failer with libgcc
Sep 25 2019, 2:50 PM
zatrazz updated the diff for D67733: Fix gdb_pretty_printer_test on python3.

I checked it with a gdb built against python 2.7.2 and python 3.7.4. I still seeing some issue on the arm bot, but I think it is unrelated to the python3 support now.

Sep 25 2019, 2:50 PM · Restricted Project
zatrazz closed D67732: Fix arm build failure with libgcc.
Sep 25 2019, 2:50 PM · Restricted Project

Sep 24 2019

zatrazz added a comment to D67732: Fix arm build failure with libgcc.

Ping.

Sep 24 2019, 4:30 PM · Restricted Project

Sep 19 2019

zatrazz added a comment to D67733: Fix gdb_pretty_printer_test on python3.

Thanks so much for fixing this. Really appreciate it.

Sep 19 2019, 1:17 PM · Restricted Project

Sep 18 2019

zatrazz created D67733: Fix gdb_pretty_printer_test on python3.
Sep 18 2019, 1:42 PM · Restricted Project
zatrazz created D67732: Fix arm build failure with libgcc.
Sep 18 2019, 1:42 PM · Restricted Project
zatrazz abandoned D67731: Fix arm build failer with libgcc.
Sep 18 2019, 1:32 PM · Restricted Project, Restricted Project
zatrazz created D67731: Fix arm build failer with libgcc.
Sep 18 2019, 1:32 PM · Restricted Project, Restricted Project

Jun 6 2019

zatrazz committed rG559e69a821bc: AArch64] Handle ISD::LRINT and ISD::LLRINT for float16 (authored by zatrazz).
AArch64] Handle ISD::LRINT and ISD::LLRINT for float16
Jun 6 2019, 5:39 AM
zatrazz committed rGbce9e11a7b01: [AArch64] Handle ISD::LROUND and ISD::LLROUND for float16 (authored by zatrazz).
[AArch64] Handle ISD::LROUND and ISD::LLROUND for float16
Jun 6 2019, 4:51 AM

Jun 4 2019

zatrazz created D62863: [AArch64] Handle ISD::LRINT and ISD::LLRINT for float16.
Jun 4 2019, 9:20 AM · Restricted Project
zatrazz created D62861: [AArch64] Handle ISD::LROUND and ISD::LLROUND for float16.
Jun 4 2019, 9:20 AM · Restricted Project

May 28 2019

zatrazz committed rG14689910737b: [clang] Handle lrint/llrint builtins (authored by zatrazz).
[clang] Handle lrint/llrint builtins
May 28 2019, 2:17 PM
zatrazz committed rG34d8daae539d: [AArch64] Handle ISD::LRINT and ISD::LLRINT (authored by zatrazz).
[AArch64] Handle ISD::LRINT and ISD::LLRINT
May 28 2019, 2:02 PM
zatrazz committed rG6d7bf5e8df54: [CodeGen] Add lrint/llrint builtins (authored by zatrazz).
[CodeGen] Add lrint/llrint builtins
May 28 2019, 1:47 PM

May 27 2019

zatrazz added a comment to D62018: [AArch64] Handle ISD::LRINT and ISD::LLRINT.

Ping.

May 27 2019, 4:35 AM · Restricted Project

May 23 2019

zatrazz added a comment to D62018: [AArch64] Handle ISD::LRINT and ISD::LLRINT.

Is this patch ok with windows support now?

May 23 2019, 5:27 AM · Restricted Project

May 21 2019

zatrazz updated the diff for D62018: [AArch64] Handle ISD::LRINT and ISD::LLRINT.

Updated patch based on previous comments. Add a pattern to handle i32 return and a testcase for Windows.

May 21 2019, 12:01 PM · Restricted Project
zatrazz added inline comments to D62018: [AArch64] Handle ISD::LRINT and ISD::LLRINT.
May 21 2019, 11:58 AM · Restricted Project
zatrazz added a comment to D62018: [AArch64] Handle ISD::LRINT and ISD::LLRINT.

Ping now that both D62017 and D62019 have been approved.

May 21 2019, 5:23 AM · Restricted Project

May 20 2019

zatrazz updated the diff for D62019: [clang] Handle lrint/llrint builtins.

Updated patch based on D62026.

May 20 2019, 8:15 AM · Restricted Project
zatrazz updated the diff for D62017: [CodeGen] Add lrint/llrint builtins.

Updated patch based on D62026.

May 20 2019, 8:15 AM · Restricted Project
zatrazz added a comment to D62017: [CodeGen] Add lrint/llrint builtins.

Can we do this with 2 intrinsics with overloaded result types as I've done for lround/llround in D62026?

May 20 2019, 5:55 AM · Restricted Project
zatrazz accepted D62026: [Intrinsics] Merge lround.i32 and lround.i64 into a single intrinsic with overloaded result type. Make result type for llround overloaded instead of fixing to i64.

LGTM, thanks for the follow-up patch.

May 20 2019, 5:53 AM · Restricted Project

May 16 2019

zatrazz created D62019: [clang] Handle lrint/llrint builtins.
May 16 2019, 11:28 AM · Restricted Project
zatrazz created D62018: [AArch64] Handle ISD::LRINT and ISD::LLRINT.
May 16 2019, 11:26 AM · Restricted Project
zatrazz created D62017: [CodeGen] Add lrint/llrint builtins.
May 16 2019, 11:26 AM · Restricted Project
zatrazz committed rG0d9dcd7bf01f: [clang] Handle lround/llround builtins (authored by zatrazz).
[clang] Handle lround/llround builtins
May 16 2019, 6:43 AM
zatrazz closed D61392: [clang] Handle lround/llround builtins.
May 16 2019, 6:41 AM · Restricted Project
zatrazz added inline comments to D61391: [AArc64] Handle ISD::LROUND and ISD::LLROUND.
May 16 2019, 6:29 AM · Restricted Project
zatrazz committed rG2d28db6b9f40: [AArch64] Handle ISD::LROUND and ISD::LLROUND (authored by zatrazz).
[AArch64] Handle ISD::LROUND and ISD::LLROUND
May 16 2019, 6:28 AM
zatrazz closed D61391: [AArc64] Handle ISD::LROUND and ISD::LLROUND.
May 16 2019, 6:27 AM · Restricted Project
zatrazz closed D61390: [CodeGen] Add lround/llround builtins.
May 16 2019, 6:24 AM · Restricted Project
zatrazz committed rG73643b5041bb: [CodeGen] Add lround/llround builtins (authored by zatrazz).
[CodeGen] Add lround/llround builtins
May 16 2019, 6:15 AM

May 14 2019

zatrazz added a comment to D61391: [AArc64] Handle ISD::LROUND and ISD::LLROUND.

So should I handle f16 in a different patch or should I also adapt it on this one?

May 14 2019, 10:36 AM · Restricted Project

May 13 2019

zatrazz added inline comments to D61391: [AArc64] Handle ISD::LROUND and ISD::LLROUND.
May 13 2019, 10:16 AM · Restricted Project
zatrazz added a comment to D61391: [AArc64] Handle ISD::LROUND and ISD::LLROUND.

Ping again now that D61390 has been approved.

May 13 2019, 6:02 AM · Restricted Project

May 10 2019

zatrazz added a comment to D61390: [CodeGen] Add lround/llround builtins.

Ping.

May 10 2019, 4:32 AM · Restricted Project

May 8 2019

zatrazz updated the diff for D61390: [CodeGen] Add lround/llround builtins.

Updated patch based on the previous comment. The main change is the IBM long double tests which also required both SoftenFloatOp_LROUND and SoftenFloatOp_LLROUND implementation to handle the type correctly.

May 8 2019, 2:30 PM · Restricted Project
zatrazz added a comment to D61390: [CodeGen] Add lround/llround builtins.

Should we have a PowerPC test for ppcf128?

May 8 2019, 12:26 PM · Restricted Project
zatrazz updated the diff for D61390: [CodeGen] Add lround/llround builtins.

Updated patch based on previous review.

May 8 2019, 11:39 AM · Restricted Project

May 7 2019

zatrazz updated the diff for D61390: [CodeGen] Add lround/llround builtins.

Updated patch based on previous comments. The changes are:

May 7 2019, 2:37 PM · Restricted Project
zatrazz added a comment to D61390: [CodeGen] Add lround/llround builtins.

Can you test lround.i32 with -mtriple=i686-unknown with and without -mattr=sse2.

Use utils/update_llc_test_checks.py to generate the checks for at least X86. Try it on the other targets too if it works for them.

May 7 2019, 2:34 PM · Restricted Project

May 6 2019

zatrazz updated the diff for D61390: [CodeGen] Add lround/llround builtins.

Updated patch based on the previous comment. The main change are:

May 6 2019, 11:50 AM · Restricted Project
zatrazz updated the diff for D61391: [AArc64] Handle ISD::LROUND and ISD::LLROUND.

Updated patch based on D61390 changes. The main change is it allows
index both lround/llround by returned type.

May 6 2019, 11:50 AM · Restricted Project

May 3 2019

zatrazz updated the diff for D61391: [AArc64] Handle ISD::LROUND and ISD::LLROUND.

Updated patch based on the previous comment. The main change adapt the testcases for D61390
update and handle lroundl/llroundl correctly.

May 3 2019, 12:45 PM · Restricted Project
zatrazz updated the diff for D61390: [CodeGen] Add lround/llround builtins.

In fact, it turned out that indexing the new lround/llround based on
input argument didn't really make it correctly handled as an expanded
operation. I will dig into exactly why backend is not selecting correctly
based on input argument, so I change it back to previous indexing by
return type.

May 3 2019, 12:43 PM · Restricted Project
zatrazz updated the diff for D61390: [CodeGen] Add lround/llround builtins.

Updated patch based on previous comments. The changes from the previous version are:

May 3 2019, 8:49 AM · Restricted Project

May 1 2019

zatrazz created D61391: [AArc64] Handle ISD::LROUND and ISD::LLROUND.
May 1 2019, 11:25 AM · Restricted Project
zatrazz created D61392: [clang] Handle lround/llround builtins.
May 1 2019, 11:25 AM · Restricted Project
zatrazz created D61390: [CodeGen] Add lround/llround builtins.
May 1 2019, 11:20 AM · Restricted Project

Apr 24 2019

zatrazz committed rG91cee68e1f0f: [fuzzer] Fix reload.test on Linux/aarch64 (authored by zatrazz).
[fuzzer] Fix reload.test on Linux/aarch64
Apr 24 2019, 12:01 PM
zatrazz closed D61066: [fuzzer] Fix reload.test on Linux/aarch64.
Apr 24 2019, 12:01 PM · Restricted Project, Restricted Project
zatrazz created D61066: [fuzzer] Fix reload.test on Linux/aarch64.
Apr 24 2019, 7:08 AM · Restricted Project, Restricted Project

Mar 18 2019

zatrazz committed rG270249de2bb3: [AArch64] Small fix for getIntImmCost (authored by zatrazz).
[AArch64] Small fix for getIntImmCost
Mar 18 2019, 11:52 AM
zatrazz closed D58461: [AArch64] Small fix for getIntImmCost.
Mar 18 2019, 11:52 AM · Restricted Project
zatrazz committed rGa3cefa5d6492: [AArch64] Optimize floating point materialization (authored by zatrazz).
[AArch64] Optimize floating point materialization
Mar 18 2019, 11:47 AM
zatrazz closed D58460: [AArch64] Optimize floating point materialization.
Mar 18 2019, 11:46 AM · Restricted Project
zatrazz committed rG664c1ef52849: [TargetLowering] Add code size information on isFPImmLegal. NFC (authored by zatrazz).
[TargetLowering] Add code size information on isFPImmLegal. NFC
Mar 18 2019, 11:41 AM
zatrazz closed D58690: [AArch64] Add code size information on isFPImmLegal.
Mar 18 2019, 11:40 AM · Restricted Project
zatrazz committed rG8a595b1d2edf: [AArch64] Refactor floating point materialization. NFC (authored by zatrazz).
[AArch64] Refactor floating point materialization. NFC
Mar 18 2019, 11:24 AM
zatrazz closed D58915: [AArch64] Refactor floating point materialization. NFC.
Mar 18 2019, 11:24 AM · Restricted Project

Mar 15 2019

zatrazz updated the diff for D58915: [AArch64] Refactor floating point materialization. NFC.

Updated patch based on previous comments.

Mar 15 2019, 6:07 AM · Restricted Project
zatrazz added inline comments to D58915: [AArch64] Refactor floating point materialization. NFC.
Mar 15 2019, 6:07 AM · Restricted Project

Mar 13 2019

zatrazz added a comment to D58915: [AArch64] Refactor floating point materialization. NFC.

Ping, only this refactor is missing review for my aarch64 fp materialization optimization.

Mar 13 2019, 12:52 PM · Restricted Project

Mar 11 2019

zatrazz added inline comments to D58690: [AArch64] Add code size information on isFPImmLegal.
Mar 11 2019, 1:42 PM · Restricted Project
zatrazz added a comment to D58915: [AArch64] Refactor floating point materialization. NFC.

Ping.

Mar 11 2019, 4:20 AM · Restricted Project
zatrazz added a comment to D58690: [AArch64] Add code size information on isFPImmLegal.

Ping.

Mar 11 2019, 4:20 AM · Restricted Project

Mar 7 2019

zatrazz updated the diff for D58690: [AArch64] Add code size information on isFPImmLegal.

Fxied CamelCase (sorry missing the comment).

Mar 7 2019, 10:36 AM · Restricted Project