Page MenuHomePhabricator

zatrazz (Adhemerval Zanella)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2015, 12:58 PM (318 w, 1 d)

Recent Activity

Mar 1 2021

zatrazz abandoned D96803: EntryExitInstrumenter: Enable at all optimization levels (PR49143).
Mar 1 2021, 6:33 AM · Restricted Project, Restricted Project

Feb 19 2021

zatrazz updated the diff for D96803: EntryExitInstrumenter: Enable at all optimization levels (PR49143).

Updated patch based on previous comments.

Feb 19 2021, 9:04 AM · Restricted Project, Restricted Project

Feb 18 2021

zatrazz added a comment to D96803: EntryExitInstrumenter: Enable at all optimization levels (PR49143).

why is this now a module pass?

Mainly to avoid the default rule from new pass manager to *not* apply any FunctionPass for optnone (which is the main issue for PR49143). Is there a better way to accomplish it? I noted also that createModuleToFunctionPassAdaptor basically creates a adaptor that applies the pass to all function on the module.

It's always good to make the pass as specific as possible (e.g. prefer a function pass rather than a module pass) so it doesn't have to worry about infra. For example, just iterating over functions doesn't skip declarations.

Feb 18 2021, 5:40 AM · Restricted Project, Restricted Project

Feb 17 2021

zatrazz added a comment to D96803: EntryExitInstrumenter: Enable at all optimization levels (PR49143).

why is this now a module pass?

Feb 17 2021, 4:02 AM · Restricted Project, Restricted Project

Feb 16 2021

zatrazz requested review of D96803: EntryExitInstrumenter: Enable at all optimization levels (PR49143).
Feb 16 2021, 11:15 AM · Restricted Project, Restricted Project

Feb 15 2021

zatrazz committed rGb9d3234c7058: [sanitizer] [arm] Disable some LSAN tests for arm-linux-gnueabihf (authored by zatrazz).
[sanitizer] [arm] Disable some LSAN tests for arm-linux-gnueabihf
Feb 15 2021, 4:35 AM
zatrazz committed rTbcda8fc240c5: [test-suite] Remove GCC-C-execute-eeprof-1 (authored by zatrazz).
[test-suite] Remove GCC-C-execute-eeprof-1
Feb 15 2021, 4:26 AM
zatrazz closed D96521: [test-suite] Remove GCC-C-execute-eeprof-1.
Feb 15 2021, 4:26 AM
zatrazz added inline comments to D96521: [test-suite] Remove GCC-C-execute-eeprof-1.
Feb 15 2021, 4:18 AM

Feb 12 2021

zatrazz accepted D96617: DebugInfo/Symbolize: Exclude ARM mapping symbols for .symtab symbolization after D95916.

LGTM, it fixes the arm sanitizer regressions.

Feb 12 2021, 10:57 AM · Restricted Project
zatrazz added a comment to D95916: DebugInfo/Symbolize: Allow STT_NOTYPE/STT_GNU_IFUNC symbols for .symtab symbolization.

This change broke arm32 llvm-symbolizer which triggered some sanitizer regression. Previously, ARM mapping symbols [1] were ignored but after this change they are shown as the function name.

Feb 12 2021, 10:06 AM · Restricted Project

Feb 11 2021

zatrazz committed rG88d1724d9b56: [sanitizer] Fix suffix-log-path_test.c on arm-linux-gnu (authored by zatrazz).
[sanitizer] Fix suffix-log-path_test.c on arm-linux-gnu
Feb 11 2021, 9:26 AM
zatrazz closed D96337: [sanitizer] Fix suffix-log-path_test.c on arm-linux-gnu.
Feb 11 2021, 9:26 AM · Restricted Project
zatrazz requested review of D96521: [test-suite] Remove GCC-C-execute-eeprof-1.
Feb 11 2021, 9:19 AM
zatrazz abandoned D96489: [zorg] Fix test-suite regression on arm bots.
Feb 11 2021, 8:57 AM · Restricted Project
zatrazz abandoned D96490: [zorg] Disable test-suite for arm global-isel bots.
Feb 11 2021, 8:57 AM · Restricted Project
zatrazz added a reviewer for D96337: [sanitizer] Fix suffix-log-path_test.c on arm-linux-gnu: ostannard.
Feb 11 2021, 6:26 AM · Restricted Project
zatrazz added a reviewer for D96489: [zorg] Fix test-suite regression on arm bots: ostannard.
Feb 11 2021, 6:25 AM · Restricted Project
zatrazz added a comment to D96490: [zorg] Disable test-suite for arm global-isel bots.

The test-suite is the only thing this bot does to test global-isel, so I don't think there's any point in running the bot with this change. I think our options here are:

  • Disable just the tests which are failing (looks like it's just test-suite::GCC-C-execute-eeprof-1.test?)
  • Convert this to a 2-stage bot with the second stage built using global-isel, so that we are still doing some useful testing
  • Disable this bot completely until https://bugs.llvm.org/show_bug.cgi?id=49143 is fixed.
Feb 11 2021, 5:58 AM · Restricted Project
zatrazz updated the diff for D96337: [sanitizer] Fix suffix-log-path_test.c on arm-linux-gnu.

Updated patch based on previous comments.

Feb 11 2021, 5:17 AM · Restricted Project
zatrazz requested review of D96490: [zorg] Disable test-suite for arm global-isel bots.
Feb 11 2021, 4:54 AM · Restricted Project
zatrazz requested review of D96489: [zorg] Fix test-suite regression on arm bots.
Feb 11 2021, 4:53 AM · Restricted Project
zatrazz added inline comments to D96337: [sanitizer] Fix suffix-log-path_test.c on arm-linux-gnu.
Feb 11 2021, 4:17 AM · Restricted Project
zatrazz added a comment to D96337: [sanitizer] Fix suffix-log-path_test.c on arm-linux-gnu.

Could this also affect regular users of the sanitizers, or is it specific to the way we are running the tests? If it could affect users, then could we fix this in the clang driver, so that unwind tables are turned on by default whenever the sanitizers need them?

Feb 11 2021, 4:12 AM · Restricted Project

Feb 9 2021

zatrazz requested review of D96337: [sanitizer] Fix suffix-log-path_test.c on arm-linux-gnu.
Feb 9 2021, 6:20 AM · Restricted Project

Jan 26 2021

zatrazz committed rGdad55c22182e: [ARM] [ELF] Fix ARMMaterializeGV for Indirect calls (authored by zatrazz).
[ARM] [ELF] Fix ARMMaterializeGV for Indirect calls
Jan 26 2021, 10:58 AM
zatrazz closed D95379: [ARM] [ELF] Fix ARMMaterializeGV for Indirect calls.
Jan 26 2021, 10:58 AM · Restricted Project
zatrazz added a watcher for lld: zatrazz.
Jan 26 2021, 5:11 AM
zatrazz closed D94612: [LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation.
Jan 26 2021, 4:43 AM · Restricted Project
zatrazz committed rG988cc0a08334: [LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation (authored by zatrazz).
[LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation
Jan 26 2021, 4:20 AM

Jan 25 2021

zatrazz updated the diff for D94612: [LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation.

Updated patch based on previous comments. The R_AARCH64_GOT_PAGE is added on
the isStaticLinkTimeConstant and the test is changed to check for shared build as well.

Jan 25 2021, 12:27 PM · Restricted Project
zatrazz requested review of D95379: [ARM] [ELF] Fix ARMMaterializeGV for Indirect calls.
Jan 25 2021, 10:43 AM · Restricted Project

Jan 21 2021

zatrazz added a comment to D94612: [LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation.

Ping.

Jan 21 2021, 4:14 AM · Restricted Project
zatrazz closed D94611: MC: AArch64: Add support for gotpage_lo15.
Jan 21 2021, 3:31 AM · Restricted Project
zatrazz committed rGff41ae8b3677: MC: AArch64: Add support for gotpage_lo15 (authored by zatrazz).
MC: AArch64: Add support for gotpage_lo15
Jan 21 2021, 3:31 AM

Jan 19 2021

zatrazz updated the diff for D94611: MC: AArch64: Add support for gotpage_lo15.

Updated patch based on previous comments.

Jan 19 2021, 6:34 AM · Restricted Project

Jan 18 2021

zatrazz closed D94809: [LLD][ELF][AArch64] Set _GLOBAL_OFFSET_TABLE_ at the start of .got.
Jan 18 2021, 10:06 AM · Restricted Project
zatrazz committed rG2f92386e721a: [LLD][ELF][AArch64] Set _GLOBAL_OFFSET_TABLE_ at the start of .got (authored by zatrazz).
[LLD][ELF][AArch64] Set _GLOBAL_OFFSET_TABLE_ at the start of .got
Jan 18 2021, 9:51 AM

Jan 15 2021

zatrazz updated the diff for D94612: [LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation.

Patch updated from comments, main changes are:

Jan 15 2021, 10:33 AM · Restricted Project
zatrazz added a comment to D94612: [LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation.

I will update the patch, since it is incomplete and requires https://reviews.llvm.org/D94809 .

Jan 15 2021, 10:27 AM · Restricted Project
zatrazz requested review of D94809: [LLD][ELF][AArch64] Set _GLOBAL_OFFSET_TABLE_ at the start of .got.
Jan 15 2021, 10:24 AM · Restricted Project

Jan 13 2021

zatrazz requested review of D94612: [LLD][ELF][AArch64] Add support for R_AARCH64_LD64_GOTPAGE_LO15 relocation.
Jan 13 2021, 9:35 AM · Restricted Project
zatrazz requested review of D94611: MC: AArch64: Add support for gotpage_lo15.
Jan 13 2021, 9:33 AM · Restricted Project

Dec 17 2020

zatrazz committed rG978eb3b87bca: [lld] [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS (authored by zatrazz).
[lld] [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS
Dec 17 2020, 6:35 AM
zatrazz committed rGe04dc5f557c5: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS for GNUStyle (authored by zatrazz).
[llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS for GNUStyle
Dec 17 2020, 6:35 AM
zatrazz committed rGef9dc51cd4af: [obj2yaml][yaml2obj] - Add AArch64 STO_AARCH64_VARIANT_PCS support (authored by zatrazz).
[obj2yaml][yaml2obj] - Add AArch64 STO_AARCH64_VARIANT_PCS support
Dec 17 2020, 6:34 AM
zatrazz closed D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.
Dec 17 2020, 6:34 AM · Restricted Project
zatrazz closed D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.
Dec 17 2020, 6:34 AM · Restricted Project
zatrazz closed D93235: [obj2yaml][yaml2obj] - Add AArch64 STO_AARCH64_VARIANT_PCS support.
Dec 17 2020, 6:34 AM · Restricted Project

Dec 16 2020

zatrazz updated the diff for D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.

Updated patch based on previous version.

Dec 16 2020, 10:21 AM · Restricted Project
zatrazz added inline comments to D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.
Dec 16 2020, 9:59 AM · Restricted Project
zatrazz added a comment to D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.

Both https://reviews.llvm.org/D93044 and https://reviews.llvm.org/D93235 have been approved, so the prerequisites of this patch are ok to land.

Dec 16 2020, 4:15 AM · Restricted Project
zatrazz added inline comments to D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.
Dec 16 2020, 4:13 AM · Restricted Project

Dec 15 2020

zatrazz added a comment to D93235: [obj2yaml][yaml2obj] - Add AArch64 STO_AARCH64_VARIANT_PCS support.

LGTM with 2 minor nits. Thanks!

Dec 15 2020, 8:36 AM · Restricted Project
zatrazz updated the diff for D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.

Updated patch based on previous comment:

Dec 15 2020, 6:28 AM · Restricted Project
zatrazz updated the diff for D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.

Updated patch based on previous comments:

Dec 15 2020, 6:25 AM · Restricted Project

Dec 14 2020

zatrazz updated the diff for D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.

Updated patch based on previous comments. It depends on https://reviews.llvm.org/D93235 for YAML STO_AARCH64_VARIANT_PCS support.

Dec 14 2020, 10:05 AM · Restricted Project
zatrazz requested review of D93235: [obj2yaml][yaml2obj] - Add AArch64 STO_AARCH64_VARIANT_PCS support.
Dec 14 2020, 10:03 AM · Restricted Project
zatrazz added inline comments to D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.
Dec 14 2020, 9:02 AM · Restricted Project
zatrazz updated the diff for D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.

Updated patch based on previous comment.

Dec 14 2020, 7:28 AM · Restricted Project

Dec 11 2020

zatrazz updated the diff for D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.

Updated patch based on previous comments. For in.relaIplt / R_AARCH64_IRELATIVE
I decided to not include since it seems to what binutils is done currently. I will raise with
them if this is the intended behaviour or if R_AARCH64_IRELATIVE should also create
the dynamic tag (and fix is accordingly on lld if it were the case).

Dec 11 2020, 11:57 AM · Restricted Project
zatrazz updated the diff for D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.

Updated patch based on previous comments.

Dec 11 2020, 11:55 AM · Restricted Project
zatrazz added inline comments to D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.
Dec 11 2020, 10:53 AM · Restricted Project
zatrazz added inline comments to D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.
Dec 11 2020, 10:43 AM · Restricted Project
zatrazz added inline comments to D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.
Dec 11 2020, 10:37 AM · Restricted Project
zatrazz updated the diff for D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.

Updated patch based on previous comments.

Dec 11 2020, 5:12 AM · Restricted Project
zatrazz updated the diff for D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.

Updated patch based on previous comments.

Dec 11 2020, 5:11 AM · Restricted Project
zatrazz abandoned D93107: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS for GNUStyle.
Dec 11 2020, 5:07 AM · Restricted Project
zatrazz requested review of D93107: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS for GNUStyle.
Dec 11 2020, 5:07 AM · Restricted Project

Dec 10 2020

zatrazz added inline comments to D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.
Dec 10 2020, 12:05 PM · Restricted Project
zatrazz added a comment to D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.

st_other marked with STO_AARCH64_VARIANT_PCS indicates a may follow a variant

a -> it

Dec 10 2020, 11:56 AM · Restricted Project
zatrazz added inline comments to D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.
Dec 10 2020, 11:49 AM · Restricted Project
zatrazz requested review of D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS.
Dec 10 2020, 8:39 AM · Restricted Project
zatrazz requested review of D93044: [llvm-readobj/elf] - AArch64: Handle AARCH64_VARIANT_PCS.
Dec 10 2020, 8:36 AM · Restricted Project

Dec 8 2020

zatrazz committed rGdb61b1844e11: [compiler-rt] [builtins] Support conversion between fp16 and fp128 (authored by zatrazz).
[compiler-rt] [builtins] Support conversion between fp16 and fp128
Dec 8 2020, 6:52 AM
zatrazz closed D92242: [compiler-rt] [builtins] Support conversion between fp16 and fp128.
Dec 8 2020, 6:52 AM · Restricted Project

Dec 3 2020

zatrazz committed rGc288715e952f: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2… (authored by zatrazz).
[compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2…
Dec 3 2020, 11:10 AM
zatrazz closed D92241: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2 if available.
Dec 3 2020, 11:10 AM · Restricted Project

Nov 30 2020

zatrazz added a comment to D92241: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2 if available.
Nov 30 2020, 4:06 AM · Restricted Project

Nov 27 2020

zatrazz requested review of D92242: [compiler-rt] [builtins] Support conversion between fp16 and fp128.
Nov 27 2020, 11:47 AM · Restricted Project
zatrazz requested review of D92241: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2 if available.
Nov 27 2020, 11:47 AM · Restricted Project

Nov 26 2020

zatrazz added a comment to D91733: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2 if available.

Isn't COMPILER_RT_HAS_FLOAT16 generated using the host compiler? If so, using the same flag for a compiler_rt test could fail if the host compiler supports f16 and the target compiler does not.

Nov 26 2020, 3:29 AM · Restricted Project

Nov 19 2020

zatrazz committed rG7a948298813c: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2… (authored by zatrazz).
[compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2…
Nov 19 2020, 10:15 AM
zatrazz committed rG1fb91fcf9cfe: [compiler-rt] [builtins] Support conversion between fp16 and fp128 (authored by zatrazz).
[compiler-rt] [builtins] Support conversion between fp16 and fp128
Nov 19 2020, 10:15 AM
zatrazz committed rG807320119fbb: [AArch64] Lower fptrunc/fpext from/to FP128t to/from FP16 (authored by zatrazz).
[AArch64] Lower fptrunc/fpext from/to FP128t to/from FP16
Nov 19 2020, 10:15 AM
zatrazz closed D91733: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2 if available.
Nov 19 2020, 10:15 AM · Restricted Project
zatrazz closed D91732: [compiler-rt] [builtins] Support conversion between fp16 and fp128.
Nov 19 2020, 10:15 AM · Restricted Project
zatrazz closed D91731: [AArch64] Lower fptrunc/fpext from/to FP128t to/from FP16.
Nov 19 2020, 10:15 AM · Restricted Project
zatrazz added a comment to D91732: [compiler-rt] [builtins] Support conversion between fp16 and fp128.

LGTM

Also, __fp16 is a storage format and promoted to 'float' for argument passing

It doesn't affect this patch, but for all of the ARM and AArch64 ABIs, __fp16 arguments are passed in the bottom half of an integer or FP register, not promoted to float. There was an old version of the AArch32 ABI (I think) which did that, but I don't think any compiler implemented it before it was changed.

Nov 19 2020, 3:17 AM · Restricted Project

Nov 18 2020

zatrazz abandoned D90175: [AArch64] Support conversion between fp16 and fp128.
Nov 18 2020, 11:36 AM · Restricted Project, Restricted Project
zatrazz requested review of D91733: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2 if available.
Nov 18 2020, 11:36 AM · Restricted Project
zatrazz requested review of D91732: [compiler-rt] [builtins] Support conversion between fp16 and fp128.
Nov 18 2020, 11:35 AM · Restricted Project
zatrazz requested review of D91731: [AArch64] Lower fptrunc/fpext from/to FP128t to/from FP16.
Nov 18 2020, 11:34 AM · Restricted Project
zatrazz added a comment to D90175: [AArch64] Support conversion between fp16 and fp128.

They are enabled iff the compiler supports _Float16.

Why are these not enabled for compilers which don't support _Float16? There is also the __fp16 type, which has been supported for much longer and could also generate code like this.

Nov 18 2020, 5:18 AM · Restricted Project, Restricted Project
zatrazz added a comment to D90175: [AArch64] Support conversion between fp16 and fp128.

Apologies for my slow response.

Patches need to have a large context (see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface I prefer arc diff)

Nov 18 2020, 3:59 AM · Restricted Project, Restricted Project

Nov 17 2020

zatrazz added a comment to D90175: [AArch64] Support conversion between fp16 and fp128.

Ping (x2).

Nov 17 2020, 12:15 PM · Restricted Project, Restricted Project

Nov 11 2020

zatrazz added a comment to D90175: [AArch64] Support conversion between fp16 and fp128.

Ping.

Nov 11 2020, 5:48 AM · Restricted Project, Restricted Project

Nov 5 2020

zatrazz closed D90627: [sanitizer] Assume getrandom might not be supported by the kernel.
Nov 5 2020, 3:38 AM · Restricted Project
zatrazz closed D90628: [lsan] Disable some LSAN tests for arm-linux-gnueabi{hf}.
Nov 5 2020, 3:38 AM · Restricted Project
zatrazz committed rGd025df3c1dec: [lsan] Disable some LSAN tests for arm-linux-gnueabi{hf} (authored by zatrazz).
[lsan] Disable some LSAN tests for arm-linux-gnueabi{hf}
Nov 5 2020, 3:37 AM