This is an archive of the discontinued LLVM Phabricator instance.

[Object][MachO] Refine interface of Slice
ClosedPublic

Authored by alexander-shaposhnikov on Sep 25 2020, 9:56 AM.

Details

Summary

This patch performs a minor cleanup of the class Slice:
static methods and constructors which take a pointer but assume that it's not null now take the argument by reference.
NFC.

Test plan: make check-all

Diff Detail

Unit TestsFailed

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptSep 25 2020, 9:56 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
alexander-shaposhnikov requested review of this revision.Sep 25 2020, 9:56 AM
rupprecht accepted this revision.Sep 25 2020, 11:14 AM
This revision is now accepted and ready to land.Sep 25 2020, 11:14 AM
MaskRay accepted this revision.Sep 25 2020, 11:32 AM
This revision was landed with ongoing or failed builds.Sep 25 2020, 4:28 PM
This revision was automatically updated to reflect the committed changes.