Page MenuHomePhabricator

[NFC] Follow up on D87111 - Add an option for unrolling loops up to a factor - CR issues addressed.
ClosedPublic

Authored by llitchev on Tue, Sep 8, 11:43 AM.

Details

Summary

Addressed some CR issues pointed out in D87111. Formatting and other nits.
The original Diff D87111 - Add an option for unrolling loops up to a factor.

Diff Detail

Event Timeline

llitchev created this revision.Tue, Sep 8, 11:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Sep 8, 11:43 AM
llitchev requested review of this revision.Tue, Sep 8, 11:43 AM
llitchev updated this revision to Diff 290558.Tue, Sep 8, 11:53 AM

Some more formatting and squashing commits.

bondhugula requested changes to this revision.EditedWed, Sep 9, 10:28 PM

Please mark the commit 'NFC' (in the title). Please also include the previous commit title in the commit summary and a part of it in the current title.

This revision now requires changes to proceed.Wed, Sep 9, 10:28 PM
llitchev updated this revision to Diff 291027.Thu, Sep 10, 10:42 AM

Fixed couple of typos and Diff title/summary issues

llitchev retitled this revision from Follow up for D87111 - CR issues addressed. to [NFC] Follow up on D87111 - Add an option for unrolling loops up to a factor - CR issues addressed..Thu, Sep 10, 10:46 AM
llitchev edited the summary of this revision. (Show Details)

Updated the Title and Summary of the diff as requested.

bondhugula accepted this revision.Thu, Sep 10, 10:45 PM
This revision is now accepted and ready to land.Thu, Sep 10, 10:45 PM