Page MenuHomePhabricator

[DWARFYAML] Make the debug_addr section optional.
ClosedPublic

Authored by Higuoxing on Sun, Sep 6, 7:15 AM.

Details

Summary

This patch makes the debug_addr section optional. When an empty
debug_addr section is specified, yaml2obj only emits a section header
for it.

Diff Detail

Event Timeline

Higuoxing created this revision.Sun, Sep 6, 7:15 AM
Herald added a project: Restricted Project. · View Herald Transcript
Higuoxing requested review of this revision.Sun, Sep 6, 7:15 AM
jhenderson accepted this revision.Mon, Sep 7, 12:55 AM

LGTM, with nit.

llvm/test/tools/yaml2obj/ELF/DWARF/debug-addr.yaml
639

I think you can drop --section-data from this line, right?

This revision is now accepted and ready to land.Mon, Sep 7, 12:55 AM
Higuoxing updated this revision to Diff 290196.Mon, Sep 7, 1:02 AM
Higuoxing marked an inline comment as done.

Address review comment.

llvm/test/tools/yaml2obj/ELF/DWARF/debug-addr.yaml
639

Yes, thanks!

This revision was landed with ongoing or failed builds.Mon, Sep 7, 1:18 AM
This revision was automatically updated to reflect the committed changes.