Page MenuHomePhabricator

Higuoxing (Xing GUO)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Jan 15 2018, 6:21 AM (140 w, 2 d)

Recent Activity

Today

Higuoxing updated the diff for D88200: [llvm-dwarfdump][test] Rewrite verify_die_ranges.s in YAML. NFC..

Split commands.

Thu, Sep 24, 1:09 AM · Unknown Object (Project)
Higuoxing requested review of D88200: [llvm-dwarfdump][test] Rewrite verify_die_ranges.s in YAML. NFC..
Thu, Sep 24, 12:50 AM · Unknown Object (Project)

Yesterday

Higuoxing committed rG505ac22f1a1a: [DWARFYAML] Make the ExtLen field of extended opcodes optional. (authored by Higuoxing).
[DWARFYAML] Make the ExtLen field of extended opcodes optional.
Wed, Sep 23, 11:20 PM
Higuoxing closed D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional..
Wed, Sep 23, 11:20 PM · Unknown Object (Project)
Higuoxing updated the diff for D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional..

Append --strict-whitespace option.
Use {{ }} to match more (2) spaces.

Wed, Sep 23, 3:19 AM · Unknown Object (Project)
Higuoxing updated the diff for D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional..

Thanks!

Wed, Sep 23, 2:05 AM · Unknown Object (Project)
Higuoxing added inline comments to D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional..
Wed, Sep 23, 1:49 AM · Unknown Object (Project)
Higuoxing updated the diff for D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional..

Address review comments.

Wed, Sep 23, 1:49 AM · Unknown Object (Project)

Tue, Sep 22

Higuoxing requested review of D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional..
Tue, Sep 22, 11:47 PM · Unknown Object (Project)
Higuoxing committed rG64435a427a01: [DWARFYAML][test] Simplify __debug_pubnames/types tests. NFC. (authored by Higuoxing).
[DWARFYAML][test] Simplify __debug_pubnames/types tests. NFC.
Tue, Sep 22, 5:43 PM
Higuoxing closed D88073: [DWARFYAML][test] Simplify __debug_pubnames/types tests. NFC..
Tue, Sep 22, 5:43 PM · Unknown Object (Project)
Higuoxing requested review of D88073: [DWARFYAML][test] Simplify __debug_pubnames/types tests. NFC..
Tue, Sep 22, 12:18 AM · Unknown Object (Project)

Mon, Sep 21

Higuoxing added inline comments to D88048: [dwarfdump] Add verifier check to find DIEs with DW_CHILDREN_yes but without children..
Mon, Sep 21, 7:58 PM · Unknown Object (Project)
Higuoxing added a comment to D88048: [dwarfdump] Add verifier check to find DIEs with DW_CHILDREN_yes but without children..

maybe slightly long test case - could do this with the CU DIE itself? (perhaps a case where hand-crafted/substantially hand-modified assembly is OK, because it can be made /so/ simple - or maybe yaml2obj dwarf support is adequate for this use case?)

Mon, Sep 21, 7:57 PM · Unknown Object (Project)

Sun, Sep 20

Higuoxing added inline comments to D87179: Fix debug_abbrev emitter to only assign table id once.
Sun, Sep 20, 10:50 PM · Unknown Object (Project)
Higuoxing added inline comments to rG6bb912336804: DWARFYAML::emitDebugSections - fix use after std::move warnings. NFCI..
Sun, Sep 20, 9:44 AM

Fri, Sep 18

Higuoxing committed rG2d35092cd258: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the… (authored by Higuoxing).
[DWARFYAML] Make the include_directories, file_names and opcodes fields of the…
Fri, Sep 18, 5:22 AM
Higuoxing closed D87878: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional..
Fri, Sep 18, 5:22 AM · Unknown Object (Project), Restricted Project
Higuoxing committed rGa761e81e2202: [DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC. (authored by Higuoxing).
[DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC.
Fri, Sep 18, 5:20 AM
Higuoxing closed D87876: [DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC..
Fri, Sep 18, 5:20 AM · Unknown Object (Project)
Higuoxing retitled D87876: [DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC. from [DWARFYAML][test] Make checkers stricter. NFC. to [DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC..
Fri, Sep 18, 1:32 AM · Unknown Object (Project)
Higuoxing updated the diff for D87878: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional..

I might be missing it, but do you have direct testing showing that the default for IncludeDirs\Files\Opcodes is an empty output, when the output is written? I think it's important that this is tested.

Fri, Sep 18, 1:30 AM · Unknown Object (Project), Restricted Project

Thu, Sep 17

Higuoxing requested review of D87878: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional..
Thu, Sep 17, 8:03 PM · Unknown Object (Project), Restricted Project
Higuoxing updated the diff for D87876: [DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC..

Check the DWARF: tag.

Thu, Sep 17, 7:49 PM · Unknown Object (Project)
Higuoxing requested review of D87876: [DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC..
Thu, Sep 17, 7:46 PM · Unknown Object (Project)

Tue, Sep 15

Higuoxing committed rG4171d5c30ad3: [obj2yaml] Add support for dumping the .debug_addr(v5) section. (authored by Higuoxing).
[obj2yaml] Add support for dumping the .debug_addr(v5) section.
Tue, Sep 15, 11:49 PM
Higuoxing closed D87601: [obj2yaml] Add support for dumping the .debug_addr(v5) section..
Tue, Sep 15, 11:48 PM · Unknown Object (Project)
Higuoxing added inline comments to D87656: [llvm-dwarfdump] --show-sources option to show all sources.
Tue, Sep 15, 11:36 PM · Unknown Object (Project)
Higuoxing updated the diff for D87601: [obj2yaml] Add support for dumping the .debug_addr(v5) section..

Address comments.

Tue, Sep 15, 12:21 AM · Unknown Object (Project)

Mon, Sep 14

Higuoxing added inline comments to D87601: [obj2yaml] Add support for dumping the .debug_addr(v5) section..
Mon, Sep 14, 11:06 PM · Unknown Object (Project)
Higuoxing updated the diff for D87601: [obj2yaml] Add support for dumping the .debug_addr(v5) section..

Address review comments.

Mon, Sep 14, 11:06 PM · Unknown Object (Project)
Higuoxing requested review of D87601: [obj2yaml] Add support for dumping the .debug_addr(v5) section..
Mon, Sep 14, 1:30 AM · Unknown Object (Project)

Sun, Sep 13

Higuoxing added a comment to D87179: Fix debug_abbrev emitter to only assign table id once.

@Higuoxing I didn't realize the DWARF section was completely new until I read your GSOC project. Thanks a lot for this work otherwise it would have been impossible for me to create the tests I needed for my other diff!

Sun, Sep 13, 6:47 PM · Unknown Object (Project)
Higuoxing accepted D87179: Fix debug_abbrev emitter to only assign table id once.

LGTM with nit.

Sun, Sep 13, 6:11 PM · Unknown Object (Project)

Thu, Sep 10

Higuoxing committed rG0e47a8d17fe8: [obj2yaml] Add support for dumping the .debug_ranges section. (authored by Higuoxing).
[obj2yaml] Add support for dumping the .debug_ranges section.
Thu, Sep 10, 5:49 PM
Higuoxing closed D87429: [obj2yaml] Add support for dumping the .debug_ranges section..
Thu, Sep 10, 5:48 PM · Unknown Object (Project)
Higuoxing updated the diff for D87429: [obj2yaml] Add support for dumping the .debug_ranges section..

Address comments.

Thu, Sep 10, 5:45 PM · Unknown Object (Project)
Higuoxing added inline comments to D87429: [obj2yaml] Add support for dumping the .debug_ranges section..
Thu, Sep 10, 2:09 AM · Unknown Object (Project)
Higuoxing updated the diff for D87429: [obj2yaml] Add support for dumping the .debug_ranges section..

Address review comments.

Thu, Sep 10, 2:09 AM · Unknown Object (Project)

Wed, Sep 9

Higuoxing requested review of D87429: [obj2yaml] Add support for dumping the .debug_ranges section..
Wed, Sep 9, 8:18 PM · Unknown Object (Project)
Higuoxing committed rG25f3cc0ced17: [elf2yaml] Fix dumping a debug section whose name is not recognized. (authored by Higuoxing).
[elf2yaml] Fix dumping a debug section whose name is not recognized.
Wed, Sep 9, 5:08 AM
Higuoxing closed D87346: [elf2yaml] Fix dumping a debug section whose name is not recognized..
Wed, Sep 9, 5:08 AM · Unknown Object (Project)
Higuoxing updated the diff for D87346: [elf2yaml] Fix dumping a debug section whose name is not recognized..

Address review comments.

Wed, Sep 9, 3:07 AM · Unknown Object (Project)
Higuoxing updated the summary of D87346: [elf2yaml] Fix dumping a debug section whose name is not recognized..
Wed, Sep 9, 1:37 AM · Unknown Object (Project)
Higuoxing updated the summary of D87346: [elf2yaml] Fix dumping a debug section whose name is not recognized..
Wed, Sep 9, 1:36 AM · Unknown Object (Project)
Higuoxing added inline comments to D87346: [elf2yaml] Fix dumping a debug section whose name is not recognized..
Wed, Sep 9, 1:36 AM · Unknown Object (Project)
Higuoxing updated the diff for D87346: [elf2yaml] Fix dumping a debug section whose name is not recognized..

Address review comments.

Wed, Sep 9, 1:36 AM · Unknown Object (Project)

Tue, Sep 8

Higuoxing requested review of D87346: [elf2yaml] Fix dumping a debug section whose name is not recognized..
Tue, Sep 8, 11:14 PM · Unknown Object (Project)
Higuoxing committed rG4682f654031c: [obj2yaml][test] Test generating and dumping a broken debug_ranges section. (authored by Higuoxing).
[obj2yaml][test] Test generating and dumping a broken debug_ranges section.
Tue, Sep 8, 5:49 PM
Higuoxing closed D87275: [obj2yaml][test] Test generating and dumping a broken debug_ranges section..
Tue, Sep 8, 5:49 PM · Unknown Object (Project)
Higuoxing committed rG25c3fa3f1333: [DWARFYAML] Make the debug_ranges section optional. (authored by Higuoxing).
[DWARFYAML] Make the debug_ranges section optional.
Tue, Sep 8, 4:56 AM
Higuoxing closed D87263: [DWARFYAML] Make the debug_ranges section optional..
Tue, Sep 8, 4:56 AM · Unknown Object (Project)
Higuoxing retitled D87275: [obj2yaml][test] Test generating and dumping a broken debug_ranges section. from [obj2yaml] Test generating and dumping a broken debug_ranges section. to [obj2yaml][test] Test generating and dumping a broken debug_ranges section..
Tue, Sep 8, 4:07 AM · Unknown Object (Project)
Higuoxing updated the diff for D87275: [obj2yaml][test] Test generating and dumping a broken debug_ranges section..

Reflow comments.

Tue, Sep 8, 4:07 AM · Unknown Object (Project)
Higuoxing requested review of D87275: [obj2yaml][test] Test generating and dumping a broken debug_ranges section..
Tue, Sep 8, 1:34 AM · Unknown Object (Project)
Higuoxing updated the diff for D87263: [DWARFYAML] Make the debug_ranges section optional..

Rebase.

Tue, Sep 8, 1:33 AM · Unknown Object (Project)
Higuoxing committed rG3cda69872362: [obj2yaml] Stop parsing the debug_str section when it encounters a string… (authored by Higuoxing).
[obj2yaml] Stop parsing the debug_str section when it encounters a string…
Tue, Sep 8, 1:11 AM
Higuoxing closed D87261: [obj2yaml] Stop parsing the debug_str section when it encounters a string without the null terminator..
Tue, Sep 8, 1:10 AM · Unknown Object (Project)
Higuoxing added inline comments to D87261: [obj2yaml] Stop parsing the debug_str section when it encounters a string without the null terminator..
Tue, Sep 8, 1:02 AM · Unknown Object (Project)
Higuoxing updated the diff for D87261: [obj2yaml] Stop parsing the debug_str section when it encounters a string without the null terminator..

Update comment.

Tue, Sep 8, 1:02 AM · Unknown Object (Project)
Higuoxing added inline comments to D87263: [DWARFYAML] Make the debug_ranges section optional..
Tue, Sep 8, 12:55 AM · Unknown Object (Project)
Higuoxing updated the diff for D87263: [DWARFYAML] Make the debug_ranges section optional..

Address review comments.

Tue, Sep 8, 12:55 AM · Unknown Object (Project)
Higuoxing updated the diff for D87261: [obj2yaml] Stop parsing the debug_str section when it encounters a string without the null terminator..

Address review comments.

Tue, Sep 8, 12:46 AM · Unknown Object (Project)

Mon, Sep 7

Higuoxing requested review of D87263: [DWARFYAML] Make the debug_ranges section optional..
Mon, Sep 7, 7:19 PM · Unknown Object (Project)
Higuoxing updated the diff for D87261: [obj2yaml] Stop parsing the debug_str section when it encounters a string without the null terminator..

Remove a header.

Mon, Sep 7, 6:36 PM · Unknown Object (Project)
Higuoxing requested review of D87261: [obj2yaml] Stop parsing the debug_str section when it encounters a string without the null terminator..
Mon, Sep 7, 6:29 PM · Unknown Object (Project)
Higuoxing committed rG3097427f93dd: [obj2yaml] Add support for dumping the .debug_str section. (authored by Higuoxing).
[obj2yaml] Add support for dumping the .debug_str section.
Mon, Sep 7, 4:47 AM
Higuoxing closed D86867: [obj2yaml] Add support for dumping the .debug_str section..
Mon, Sep 7, 4:47 AM · Unknown Object (Project)
Higuoxing updated the diff for D86867: [obj2yaml] Add support for dumping the .debug_str section..

Avoid using Flags.getValueOr() twice.

Mon, Sep 7, 2:29 AM · Unknown Object (Project)
Higuoxing committed rG40f4131fce78: [DWARFYAML] Make the debug_addr section optional. (authored by Higuoxing).
[DWARFYAML] Make the debug_addr section optional.
Mon, Sep 7, 1:19 AM
Higuoxing closed D87205: [DWARFYAML] Make the debug_addr section optional..
Mon, Sep 7, 1:18 AM · Unknown Object (Project)
Higuoxing updated the diff for D86867: [obj2yaml] Add support for dumping the .debug_str section..

Explicitly check the sh_flag.

Mon, Sep 7, 1:15 AM · Unknown Object (Project)
Higuoxing added inline comments to D87205: [DWARFYAML] Make the debug_addr section optional..
Mon, Sep 7, 1:02 AM · Unknown Object (Project)
Higuoxing updated the diff for D87205: [DWARFYAML] Make the debug_addr section optional..

Address review comment.

Mon, Sep 7, 1:02 AM · Unknown Object (Project)

Sun, Sep 6

Higuoxing requested review of D87205: [DWARFYAML] Make the debug_addr section optional..
Sun, Sep 6, 7:15 AM · Unknown Object (Project)
Higuoxing added inline comments to D86867: [obj2yaml] Add support for dumping the .debug_str section..
Sun, Sep 6, 3:48 AM · Unknown Object (Project)
Higuoxing updated the diff for D86867: [obj2yaml] Add support for dumping the .debug_str section..

I modified the getDefaultShEntSize() function in this revision. If the section name is '.debug_str', the default value of sh_entsize is 1 rather than 0.

Sun, Sep 6, 3:48 AM · Unknown Object (Project)

Sat, Sep 5

Higuoxing added inline comments to D87179: Fix debug_abbrev emitter to only assign table id once.
Sat, Sep 5, 6:48 PM · Unknown Object (Project)
Higuoxing added a comment to D87179: Fix debug_abbrev emitter to only assign table id once.

I think the problem is caused by misplacing the line Y.DebugAbbrev.back().ID = AbbrevTableID++;. It should be placed in an outer loop.

Sat, Sep 5, 10:41 AM · Unknown Object (Project)

Fri, Sep 4

Higuoxing committed rG2966d6e80b77: [MachOYAML] Allow handcrafting custom contents for DWARF sections. (authored by Higuoxing).
[MachOYAML] Allow handcrafting custom contents for DWARF sections.
Fri, Sep 4, 7:43 AM
Higuoxing closed D87126: [MachOYAML] Allow handcrafting custom contents for DWARF sections..
Fri, Sep 4, 7:43 AM · Unknown Object (Project)
Higuoxing updated the summary of D87126: [MachOYAML] Allow handcrafting custom contents for DWARF sections..
Fri, Sep 4, 7:40 AM · Unknown Object (Project)
Higuoxing updated the summary of D87126: [MachOYAML] Allow handcrafting custom contents for DWARF sections..
Fri, Sep 4, 2:56 AM · Unknown Object (Project)
Higuoxing updated the diff for D87126: [MachOYAML] Allow handcrafting custom contents for DWARF sections..

Add a comment saying why we don't check the segname.

Fri, Sep 4, 1:42 AM · Unknown Object (Project)
Higuoxing requested review of D87126: [MachOYAML] Allow handcrafting custom contents for DWARF sections..
Fri, Sep 4, 12:58 AM · Unknown Object (Project)

Thu, Sep 3

Higuoxing added inline comments to D86867: [obj2yaml] Add support for dumping the .debug_str section..
Thu, Sep 3, 9:26 PM · Unknown Object (Project)
Higuoxing updated the diff for D86867: [obj2yaml] Add support for dumping the .debug_str section..

Check the optional value.

Thu, Sep 3, 9:26 PM · Unknown Object (Project)
Higuoxing added inline comments to D86867: [obj2yaml] Add support for dumping the .debug_str section..
Thu, Sep 3, 1:37 AM · Unknown Object (Project)
Higuoxing updated the diff for D86867: [obj2yaml] Add support for dumping the .debug_str section..

Update.

Thu, Sep 3, 1:37 AM · Unknown Object (Project)

Wed, Sep 2

Higuoxing updated the diff for D86867: [obj2yaml] Add support for dumping the .debug_str section..

Add test case (c): Test dumping an empty .debug_str section.

Wed, Sep 2, 10:04 PM · Unknown Object (Project)
Higuoxing added inline comments to D86867: [obj2yaml] Add support for dumping the .debug_str section..
Wed, Sep 2, 7:57 PM · Unknown Object (Project)
Higuoxing updated the diff for D86867: [obj2yaml] Add support for dumping the .debug_str section..

Address comments.

Wed, Sep 2, 7:57 PM · Unknown Object (Project)
Higuoxing committed rG67ce11405b08: [llvm-dwarfdump] Warn user when it encounters no null terminated strings. (authored by Higuoxing).
[llvm-dwarfdump] Warn user when it encounters no null terminated strings.
Wed, Sep 2, 5:51 PM
Higuoxing closed D86998: [llvm-dwarfdump] Warn user when it encounters no null terminated strings..
Wed, Sep 2, 5:50 PM · Unknown Object (Project)
Higuoxing added inline comments to D86998: [llvm-dwarfdump] Warn user when it encounters no null terminated strings..
Wed, Sep 2, 3:29 AM · Unknown Object (Project)
Higuoxing updated the diff for D86998: [llvm-dwarfdump] Warn user when it encounters no null terminated strings..

Address comment.

Wed, Sep 2, 3:29 AM · Unknown Object (Project)
Higuoxing added inline comments to D86998: [llvm-dwarfdump] Warn user when it encounters no null terminated strings..
Wed, Sep 2, 1:55 AM · Unknown Object (Project)

Tue, Sep 1

Higuoxing added inline comments to D86998: [llvm-dwarfdump] Warn user when it encounters no null terminated strings..
Tue, Sep 1, 10:16 PM · Unknown Object (Project)
Higuoxing updated the diff for D86998: [llvm-dwarfdump] Warn user when it encounters no null terminated strings..

Address comment.

Tue, Sep 1, 10:16 PM · Restricted Project
Higuoxing requested review of D86998: [llvm-dwarfdump] Warn user when it encounters no null terminated strings..
Tue, Sep 1, 7:48 PM · Restricted Project