Page MenuHomePhabricator

[llvm-readobj/elf] - Don't fail when dumping an archive with a member that can't be recognized.
ClosedPublic

Authored by grimar on Fri, Aug 28, 3:34 AM.

Details

Summary

Imagine we have an archive that has 3 objects in the following order:
<valid known object>,<unknown object> and <valid known object>.

Currently llvm-readelf/obj report an error and stops dumping in the middle.
This patch changes the error reported to warning.

I am improving this warning in a follow-up that will be posted soon.

Diff Detail

Event Timeline

grimar created this revision.Fri, Aug 28, 3:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Aug 28, 3:35 AM
Herald added a subscriber: rupprecht. · View Herald Transcript
grimar requested review of this revision.Fri, Aug 28, 3:35 AM
MaskRay accepted this revision.Fri, Aug 28, 8:12 AM

with an object that can't be recognized.

object -> member or element.

This revision is now accepted and ready to land.Fri, Aug 28, 8:12 AM
grimar retitled this revision from [llvm-readobj/elf] - Don't fail when dumping an archive with an object that can't be recognized. to [llvm-readobj/elf] - Don't fail when dumping an archive with a member that can't be recognized..Mon, Aug 31, 3:05 AM
jhenderson added inline comments.Tue, Sep 1, 2:06 AM
llvm/test/tools/llvm-readobj/archive.test
89–90
grimar added inline comments.Tue, Sep 1, 4:03 AM
llvm/test/tools/llvm-readobj/archive.test
89–90