Differential D86334

[analyzer] Remove redundant output errs
ClosedPublic
Actions

Authored by nullptr.cpp on Aug 21 2020, 12:49 AM.

Details

Reviewers

dcoughlin
NoQ
george.karpenkov
xazax.hun

Commits

rG37c21dbb3a32: [analyzer] Fix the debug print about debug egraph dumps requiring asserts.

Summary

No need to output errs if already have NDEBUG defined.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

nullptr.cpp created this revision.Aug 21 2020, 12:49 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 21 2020, 12:50 AM

Herald added subscribers: cfe-commits, ASDenysPetrov, martong and 9 others. · View Herald Transcript

nullptr.cpp requested review of this revision.Aug 21 2020, 12:50 AM

nullptr.cpp added reviewers: dcoughlin, NoQ, george.karpenkov.Aug 21 2020, 12:52 AM

Harbormaster completed remote builds in B69113: Diff 286960.Aug 21 2020, 1:33 AM

nullptr.cpp added a reviewer: xazax.hun.Aug 21 2020, 1:57 AM

Herald added a subscriber: rnkovacs. · View Herald TranscriptAug 21 2020, 1:57 AM

LGTM, thanks!

This revision is now accepted and ready to land.Aug 21 2020, 2:19 AM

I don't have commit access, can you help commit it?

In D86334#2230032, @xazax.hun wrote:

LGTM, thanks!

nullptr.cpp mentioned this in D86691: [analyzer] Fix wrong parameter name in printFormattedEntry.Aug 27 2020, 4:19 AM

Closed by commit rG37c21dbb3a32: [analyzer] Fix the debug print about debug egraph dumps requiring asserts. (authored by nullptr.cpp, committed by dergachev.a). · Explain WhyAug 27 2020, 12:15 PM

This revision was automatically updated to reflect the committed changes.

dergachev.a added a commit: rG37c21dbb3a32: [analyzer] Fix the debug print about debug egraph dumps requiring asserts..

Revision Contents
Changeset List

Path

Size

clang/

lib/

StaticAnalyzer/

Core/

10 lines

Diff 288421

clang/lib/StaticAnalyzer/Core/ExprEngine.cpp

Loading...