Page MenuHomePhabricator

[TableGen][GlobalISel] Fix tblgen optimization bug
ClosedPublic

Authored by ehjogab on Aug 19 2020, 1:06 AM.

Details

Summary

When optimizing the table, PointerToAnyOperandMatchers would be
incorrectly reported as identical even though they have different
SizeInBits values. This bug was due to failing to overload the
isIdentical() method, which this patch addresses.

Diff Detail

Event Timeline

ehjogab created this revision.Aug 19 2020, 1:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2020, 1:06 AM
Herald added subscribers: jfb, rovka. · View Herald Transcript
ehjogab requested review of this revision.Aug 19 2020, 1:06 AM
bjope added a subscriber: bjope.Aug 19 2020, 2:39 AM
arsenm accepted this revision.Aug 19 2020, 6:33 AM
This revision is now accepted and ready to land.Aug 19 2020, 6:33 AM
bjope added a comment.Aug 25 2020, 1:29 AM

@ehjogab : Should I help out landing this patch?

This revision was automatically updated to reflect the committed changes.