User Details
- User Since
- Sep 26 2016, 7:58 AM (226 w, 16 h)
Fri, Jan 22
Thu, Jan 21
@lebedev.ri : I think I need your blessing as well on this, considering your earlier concerns. Is it still just confusing? (I doubt that we want/can replace all uses of getCharWidth/getIntWidth etc in clang with integers)
Still LGTM
Updated to add CharTy to the CodeGenTypeCache (based on review feedback).
Wed, Jan 20
LGTM
Tue, Jan 19
Mon, Jan 18
Sat, Jan 16
Fri, Jan 15
Thu, Jan 14
Wed, Jan 13
I've now tried to do some performance comparisons using perf stat -r 100 opt -O3 -o /dev/null --verify-dom-info -verify-assumption-cache -verify-loop-info.
Tue, Jan 12
I created this patch as my earlier patch (https://reviews.llvm.org/D94138) resulted in even more duplicates in the preserved sets. So the idea was to compensate a bit for a potential speed regression, when using verifiers, by simply getting rid of all duplicates in the sets.
Rebase after pre-committing the test case.
I landed this on behalf of @ebevhan
I've just landed this on behalf of @ebevhan.
Mon, Jan 11
Sat, Jan 9
Thu, Jan 7
Wed, Jan 6
Tue, Jan 5
Mon, Jan 4
Ping!
There is a bunch of lit tests that fail if adding a DT->verify() check in isKnownNonZero.
Wed, Dec 30
Dec 18 2020
Dec 16 2020
Dec 14 2020
Gentle ping again.
Dec 10 2020
But if I understand this patch correctly it has tried to derive the type from "some_isnt" when it is omitted, rather than reusing the type from the source pattern. Would it make more sense to infer the type from the source pattern instead of from the target instruction when it is omitted? Is that possible?
Dec 9 2020
@SjoerdMeijer : I've reviewed the non-target-specific changes now. And that part looks good to me now.
Dec 7 2020
Nov 27 2020
Nov 25 2020
Nov 20 2020
Nov 18 2020
Nov 16 2020
Nov 12 2020
Nov 11 2020
Add back test cases (they were accidentally removed when commandeering this patch and rebasing earlier).
Nov 3 2020
Nov 2 2020
Oct 30 2020
Big thanks to @ebevhan for doing lots of work moving forward with the fixed-point number (embedded-c) support.
Address review comments from RKSimon.
Rebase
Oct 29 2020
Oct 27 2020
Oct 23 2020
Our "master integration" also stopped after this commit, and we hit the LIBCXXABI_LIBCXX_INCLUDES= is not a valid directory. error. We've never provided any LIBCXXABI_LIBCXX_INCLUDES so I'm not sure what I should point it to.
Oct 21 2020
As I see it this solution focuses on the problem seen in LoopUnroll. So I agree, it is conservative and simple so if it solves the PR I think it is just fine.
Oct 19 2020
Oct 7 2020
Oct 5 2020
One thing that I've not understood is how GlobalISel is different from the legacy ISel here. Apparently it isn't necessary to annotate things with the legacy ISel today? So is legacy ISel doing the same thing that this patch suggests to do also for GlobalISel, or why do we suddenly need to update all patterns now (I mean, somehow it has worked fine in the past, right)?
Oct 2 2020
Looking at build.ninja we used to get
I've checked the late "better safe than sorry type checks" and they LGTM.