Page MenuHomePhabricator

[Clang][SVE] NFC: Move info about ACLE types into separate function.
ClosedPublic

Authored by sdesmalen on Aug 17 2020, 12:47 PM.

Details

Summary

This function returns a struct BuiltinVectorTypeInfo that contains
the builtin vector's element type, element count and number of vectors
(used for vector tuples).

Diff Detail

Event Timeline

sdesmalen created this revision.Aug 17 2020, 12:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2020, 12:47 PM
sdesmalen requested review of this revision.Aug 17 2020, 12:47 PM
c-rhodes accepted this revision.Aug 18 2020, 9:14 AM

LGTM, just one minor nit but seems like a nice improvement

clang/include/clang/AST/ASTContext.h
1318

nit: not sure on the name here since it's returning more than the element type, how about getBuiltinVectorTypeInfo?

This revision is now accepted and ready to land.Aug 18 2020, 9:14 AM
sdesmalen added inline comments.Aug 19 2020, 3:06 AM
clang/include/clang/AST/ASTContext.h
1318

Thanks, you're right that was a misnomer. I've taken your suggestion (and also updated the comment).