This is an archive of the discontinued LLVM Phabricator instance.

[lld][ARM] Handle mapping symbols
ClosedPublic

Authored by denis-protivensky on Mar 24 2015, 11:02 PM.

Details

Summary

Mapping symbols should have their own code models, and in some places must be treated in a specific way.
Make $t denote Thumb code, and $a and $d denote ARM code.
Set size, binding and type of mapping symbols to what the specification says.

Diff Detail

Event Timeline

denis-protivensky retitled this revision from to [lld][ARM] Handle mapping symbols.
denis-protivensky updated this object.
denis-protivensky edited the test plan for this revision. (Show Details)
denis-protivensky added reviewers: ruiu, shankarke.
denis-protivensky added a project: lld.
denis-protivensky added a subscriber: Unknown Object (MLST).
This revision is now accepted and ready to land.Mar 25 2015, 6:05 AM
ruiu accepted this revision.Mar 25 2015, 11:00 AM
ruiu edited edge metadata.

LGTM

lib/ReaderWriter/ELF/ARM/ARMELFFile.h
55

remove "this->"

63

Ditto

119

wrong indentation

Otherwise, LGTM.

lib/ReaderWriter/ELF/ARM/ARMELFFile.h
33

Should we inherit constructors here like Rui just proposed with D8612?

meadori added inline comments.Mar 25 2015, 12:57 PM
lib/ReaderWriter/ELF/ARM/ARMELFFile.h
33

Nevermind. I see where D8612 just got abandoned.

lib/ReaderWriter/ELF/ARM/ARMELFFile.h
55

I'd want to, but gcc doesn't resolve template dependent names otherwise.

119

Will fix.

This revision was automatically updated to reflect the committed changes.