This is an archive of the discontinued LLVM Phabricator instance.

[llvm-install-name-tool] Add more documentation
ClosedPublic

Authored by sameerarora101 on Aug 10 2020, 8:11 AM.

Details

Summary

Add documentation for the remaining options of
llvm-install-name-tool.

Diff Detail

Event Timeline

sameerarora101 created this revision.Aug 10 2020, 8:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2020, 8:11 AM
sameerarora101 requested review of this revision.Aug 10 2020, 8:11 AM

This is how it would look online:

smeenai accepted this revision.Aug 10 2020, 8:00 PM

Looks great, thanks!

llvm/docs/CommandGuide/llvm-install-name-tool.rst
25–26

Grammar nit: I'd prefer "-add_rpath, -delete_rpath, and -rpath can be combined in an invocation only if..."

This revision is now accepted and ready to land.Aug 10 2020, 8:00 PM
jhenderson accepted this revision.Aug 11 2020, 2:47 AM

Mostly looks good.

llvm/docs/CommandGuide/llvm-install-name-tool.rst
25–26

I'm not sure this should be a bullet point. It seems like it should be a new sentence at the end of the previous paragraph.

59–60

Let's get rid of the excessive new lines!

sameerarora101 marked 3 inline comments as done.Aug 11 2020, 7:13 AM
sameerarora101 added inline comments.
llvm/docs/CommandGuide/llvm-install-name-tool.rst
25–26

Added as a sentence. How does that look?

sameerarora101 marked an inline comment as done.

Remove extra lines.

jhenderson accepted this revision.Aug 11 2020, 7:22 AM
jhenderson added inline comments.
llvm/docs/CommandGuide/llvm-install-name-tool.rst
25–26

Thanks, looks good.

Rebase to remove previous build errors.

This revision was automatically updated to reflect the committed changes.