Page MenuHomePhabricator

Ktwu (Kellie Medlin)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 29 2019, 2:55 PM (57 w, 3 d)

Recent Activity

Jun 30 2020

Ktwu added inline comments to D82812: [llvm-install-name-tool] Merge rpath with id/change.
Jun 30 2020, 1:37 PM · Restricted Project
Ktwu added inline comments to D82812: [llvm-install-name-tool] Merge rpath with id/change.
Jun 30 2020, 10:49 AM · Restricted Project

Jun 29 2020

Ktwu added inline comments to D82812: [llvm-install-name-tool] Merge rpath with id/change.
Jun 29 2020, 6:34 PM · Restricted Project

Jun 18 2020

Ktwu added a comment to D81887: [lld-macho] Refactor segment/section creation, sorting, and merging.

This is nice; thanks for the cleanup!

Jun 18 2020, 10:18 AM · Restricted Project

Jun 16 2020

Ktwu added inline comments to D81944: [llvm-install-name-tool] Adds docs for install-name-tool.
Jun 16 2020, 11:00 AM · Restricted Project

Jun 8 2020

Ktwu accepted D81295: lld: initial pass at supporting TBD.

Thanks!

Jun 8 2020, 1:18 PM · Restricted Project, lld
Ktwu added inline comments to D81295: lld: initial pass at supporting TBD.
Jun 8 2020, 11:35 AM · Restricted Project, lld
Ktwu added a comment to D81295: lld: initial pass at supporting TBD.

This is largely incomplete, not filtering out platforms and architectures.

Jun 8 2020, 10:29 AM · Restricted Project, lld
Ktwu added inline comments to D81326: lld: improve the `-arch` handling for MachO.
Jun 8 2020, 9:56 AM · Restricted Project, lld

Jun 5 2020

Ktwu added a comment to D81295: lld: initial pass at supporting TBD.

This is largely incomplete, not filtering out platforms and architectures.

Jun 5 2020, 2:35 PM · Restricted Project, lld

Jun 4 2020

Ktwu added inline comments to D81097: [llvm-objcopy] Reorder --dump-section before --remove-section for ELF..
Jun 4 2020, 1:50 PM · Restricted Project

May 14 2020

Ktwu added inline comments to D78342: [lld] Add archive file support to Mach-O backend.
May 14 2020, 2:08 PM · Restricted Project
Ktwu updated the diff for D78342: [lld] Add archive file support to Mach-O backend.
  • Make archive input files own their archives again
May 14 2020, 1:03 PM · Restricted Project
Ktwu added inline comments to D78342: [lld] Add archive file support to Mach-O backend.
May 14 2020, 12:30 PM · Restricted Project
Ktwu updated the diff for D78342: [lld] Add archive file support to Mach-O backend.
  • Inlined the archive*.s file inputs
  • Removed unused return value
  • Retweaked the inputs for symbol-order to reflect the files that inspired them
  • Re-ran check-lld once more
May 14 2020, 10:50 AM · Restricted Project
Ktwu added inline comments to D78342: [lld] Add archive file support to Mach-O backend.
May 14 2020, 10:50 AM · Restricted Project

May 13 2020

Ktwu updated the diff for D78342: [lld] Add archive file support to Mach-O backend.
  • Inlined the test files for symbol-order
  • Changed symbol-order to check sections instead of running executables
  • A couple other lil changes
  • rebased
May 13 2020, 5:29 PM · Restricted Project
Ktwu added inline comments to D78342: [lld] Add archive file support to Mach-O backend.
May 13 2020, 3:51 PM · Restricted Project

May 8 2020

Ktwu updated the diff for D78342: [lld] Add archive file support to Mach-O backend.
  • Add a test for symbol order resolution based on @smeenai's wonderful work
  • Get rid of the input section function in favor of immediately caching Archive inputs during fetch
  • Test format cleanup: use *.o naming
  • Tried to use llvm-nm -p, test started failing, punting for now
  • Explicitly include Archive.h
May 8 2020, 6:17 PM · Restricted Project
Ktwu added inline comments to D78342: [lld] Add archive file support to Mach-O backend.
May 8 2020, 4:41 PM · Restricted Project

May 7 2020

Ktwu added inline comments to D78342: [lld] Add archive file support to Mach-O backend.
May 7 2020, 12:28 PM · Restricted Project
Ktwu added inline comments to D79460: [lld-macho] Follow-up to D77893.
May 7 2020, 11:55 AM · Restricted Project

May 6 2020

Ktwu accepted D79460: [lld-macho] Follow-up to D77893.
May 6 2020, 12:25 PM · Restricted Project

May 4 2020

Ktwu added inline comments to D78342: [lld] Add archive file support to Mach-O backend.
May 4 2020, 10:43 AM · Restricted Project

May 1 2020

Ktwu updated the diff for D77893: [lld] Merge Mach-O input sections.

Remove testing cruft, oops

May 1 2020, 5:12 PM · Restricted Project
Ktwu updated the diff for D78342: [lld] Add archive file support to Mach-O backend.

Added two tests inspired by the ELF implementation -- a bad archive, and an archive with no symbol table.

May 1 2020, 5:09 PM · Restricted Project

Apr 30 2020

Ktwu updated the diff for D77893: [lld] Merge Mach-O input sections.
  • initialization list for SyntheticSection
  • caching position for "default" sections
  • objdump instead of readobj in test
  • constants for __DATA_CONST
  • llvm_unreachable
Apr 30 2020, 11:46 PM · Restricted Project
Ktwu added inline comments to D77893: [lld] Merge Mach-O input sections.
Apr 30 2020, 11:45 PM · Restricted Project

Apr 29 2020

Ktwu updated the diff for D78342: [lld] Add archive file support to Mach-O backend.

Rebase, go through most comments (still need to add an erroneous archive test)

Apr 29 2020, 11:25 PM · Restricted Project
Ktwu added inline comments to D78342: [lld] Add archive file support to Mach-O backend.
Apr 29 2020, 11:13 PM · Restricted Project
Ktwu updated the diff for D77893: [lld] Merge Mach-O input sections.

clang-format

Apr 29 2020, 10:41 PM · Restricted Project
Ktwu updated the diff for D77893: [lld] Merge Mach-O input sections.

Rebased, aligned file offsets, and tested with UBSAN.

Apr 29 2020, 10:41 PM · Restricted Project
Ktwu added inline comments to D77893: [lld] Merge Mach-O input sections.
Apr 29 2020, 10:41 PM · Restricted Project

Apr 27 2020

Ktwu updated the diff for D77893: [lld] Merge Mach-O input sections.

Comments. More significantly, added more checks to verify __text merging.

Apr 27 2020, 4:11 PM · Restricted Project
Ktwu added inline comments to D77893: [lld] Merge Mach-O input sections.
Apr 27 2020, 3:39 PM · Restricted Project

Apr 24 2020

Ktwu added inline comments to D77893: [lld] Merge Mach-O input sections.
Apr 24 2020, 4:48 PM · Restricted Project

Apr 22 2020

Ktwu updated the diff for D77893: [lld] Merge Mach-O input sections.
  • Move comparator logic within output segment / section
  • Refactored creation of synthetic classes to use a base class / add to segments within constructor
  • removed instances of "this"
Apr 22 2020, 1:37 PM · Restricted Project
Ktwu added inline comments to D77893: [lld] Merge Mach-O input sections.
Apr 22 2020, 1:03 PM · Restricted Project

Apr 21 2020

Ktwu added inline comments to D77893: [lld] Merge Mach-O input sections.
Apr 21 2020, 10:40 PM · Restricted Project
Ktwu updated the diff for D78342: [lld] Add archive file support to Mach-O backend.

Rebase

Apr 21 2020, 11:20 AM · Restricted Project
Ktwu updated the diff for D77893: [lld] Merge Mach-O input sections.

tweak comment

Apr 21 2020, 11:20 AM · Restricted Project
Ktwu updated the diff for D77893: [lld] Merge Mach-O input sections.

Pruned unnecessary hidden checks, coalesced some functions, removed unused imports

Apr 21 2020, 11:20 AM · Restricted Project
Ktwu updated the diff for D77893: [lld] Merge Mach-O input sections.

Refactored to turn synthetic input sections into output sections. A new class represents merged input sections, the MergedOutputSection.

Apr 21 2020, 1:02 AM · Restricted Project

Apr 16 2020

Ktwu updated the summary of D78342: [lld] Add archive file support to Mach-O backend.
Apr 16 2020, 8:01 PM · Restricted Project
Ktwu created D78342: [lld] Add archive file support to Mach-O backend.
Apr 16 2020, 7:30 PM · Restricted Project
Ktwu added inline comments to D77893: [lld] Merge Mach-O input sections.
Apr 16 2020, 7:29 PM · Restricted Project
Ktwu retitled D77893: [lld] Merge Mach-O input sections from WIP [lld] Merge Mach-O input sections to [lld] Merge Mach-O input sections.
Apr 16 2020, 3:04 PM · Restricted Project
Ktwu updated the diff for D77893: [lld] Merge Mach-O input sections.

Rebased, various comments about renames, basic test

Apr 16 2020, 3:04 PM · Restricted Project
Ktwu updated the diff for D77893: [lld] Merge Mach-O input sections.

Added a test; unfortunately symbol export is blocking the text so I need to rebase

Apr 16 2020, 12:14 PM · Restricted Project
Ktwu added inline comments to D77893: [lld] Merge Mach-O input sections.
Apr 16 2020, 11:42 AM · Restricted Project

Apr 14 2020

Ktwu updated the diff for D77893: [lld] Merge Mach-O input sections.

Passing most local tests now

Apr 14 2020, 5:58 PM · Restricted Project
Ktwu added inline comments to D77893: [lld] Merge Mach-O input sections.
Apr 14 2020, 4:52 PM · Restricted Project

Apr 10 2020

Ktwu updated the diff for D77893: [lld] Merge Mach-O input sections.

Output is horribly wrong but at least it's not crashing now when running symtab.s

Apr 10 2020, 5:47 PM · Restricted Project
Ktwu updated the diff for D77893: [lld] Merge Mach-O input sections.

Now in a buildable state

Apr 10 2020, 2:31 PM · Restricted Project
Ktwu created D77893: [lld] Merge Mach-O input sections.
Apr 10 2020, 1:26 PM · Restricted Project

Apr 9 2020

Ktwu added inline comments to D76742: [lld-macho] Add basic symbol table output.
Apr 9 2020, 11:59 AM · Restricted Project

Apr 6 2020

Ktwu updated the diff for D76742: [lld-macho] Add basic symbol table output.

Addressing request to split generating content and assigning addresses. This doesn't functionally
do anything different than before since nothing in the writer is parallelized, but in principle
this could be adapted to be so.

Apr 6 2020, 6:01 PM · Restricted Project
Ktwu added a comment to D76742: [lld-macho] Add basic symbol table output.

Since D76839 is based on this diff, it'd be easier to land this diff as-is so that D76839 doesn't have to rebase. Any qualms about landing as-is and then changing the write order in another diff?

Apr 6 2020, 1:37 PM · Restricted Project

Apr 2 2020

Ktwu added a comment to D76742: [lld-macho] Add basic symbol table output.

My understanding of this patch is that this creates section contents early. But can you avoid doing that?

Apr 2 2020, 9:44 AM · Restricted Project

Apr 1 2020

Ktwu updated the diff for D76742: [lld-macho] Add basic symbol table output.

Address comments, rebase on D76252

Apr 1 2020, 7:04 PM · Restricted Project
Ktwu added a comment to D76742: [lld-macho] Add basic symbol table output.

Sorry for the delay in response, and thanks for the review so far!

Apr 1 2020, 6:32 PM · Restricted Project

Mar 30 2020

Ktwu updated the summary of D76742: [lld-macho] Add basic symbol table output.
Mar 30 2020, 4:24 PM · Restricted Project
Ktwu updated the diff for D76742: [lld-macho] Add basic symbol table output.

Verify that address offsets for the text segment are reasonable

Mar 30 2020, 4:24 PM · Restricted Project
Ktwu updated the diff for D76742: [lld-macho] Add basic symbol table output.

Addressing first round of comments (minus the value checks in the test)

Mar 30 2020, 3:51 PM · Restricted Project

Mar 26 2020

Ktwu added inline comments to D76742: [lld-macho] Add basic symbol table output.
Mar 26 2020, 9:45 AM · Restricted Project

Mar 24 2020

Ktwu updated the summary of D76742: [lld-macho] Add basic symbol table output.
Mar 24 2020, 5:30 PM · Restricted Project
Ktwu updated the summary of D76742: [lld-macho] Add basic symbol table output.
Mar 24 2020, 5:30 PM · Restricted Project
Ktwu created D76742: [lld-macho] Add basic symbol table output.
Mar 24 2020, 5:30 PM · Restricted Project