Page MenuHomePhabricator

sameerarora101 (Sameer Arora)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2020, 1:08 PM (21 w, 1 d)

Recent Activity

Aug 14 2020

sameerarora101 committed rG1aed1e72e83d: [llvm-libtool-darwin] Add support for -l and -L (authored by sameerarora101).
[llvm-libtool-darwin] Add support for -l and -L
Aug 14 2020, 11:45 AM
sameerarora101 closed D85540: [llvm-libtool-darwin] Add support for -l and -L.
Aug 14 2020, 11:44 AM · Restricted Project
sameerarora101 committed rG8f6f6f407aa9: [llvm-libtool-darwin] Support universal outputs (authored by sameerarora101).
[llvm-libtool-darwin] Support universal outputs
Aug 14 2020, 11:37 AM
sameerarora101 closed D85334: [llvm-libtool-darwin] Support universal outputs.
Aug 14 2020, 11:36 AM · Restricted Project
sameerarora101 updated the diff for D85540: [llvm-libtool-darwin] Add support for -l and -L.

Rebase.

Aug 14 2020, 10:42 AM · Restricted Project
sameerarora101 updated the diff for D85334: [llvm-libtool-darwin] Support universal outputs.

unordered_map -> map to guarantee deterministic output across platforms.

Aug 14 2020, 10:32 AM · Restricted Project
sameerarora101 updated the diff for D85540: [llvm-libtool-darwin] Add support for -l and -L.

Add 2 more tests for file not found.

Aug 14 2020, 6:57 AM · Restricted Project
sameerarora101 added inline comments to D85540: [llvm-libtool-darwin] Add support for -l and -L.
Aug 14 2020, 6:54 AM · Restricted Project
sameerarora101 updated the diff for D85334: [llvm-libtool-darwin] Support universal outputs.

Reorder architectures in test.

Aug 14 2020, 6:38 AM · Restricted Project
sameerarora101 added inline comments to D85334: [llvm-libtool-darwin] Support universal outputs.
Aug 14 2020, 6:18 AM · Restricted Project

Aug 13 2020

sameerarora101 committed rGbd2853f7998d: [llvm-libtool-darwin] Add support for -arch_only (authored by sameerarora101).
[llvm-libtool-darwin] Add support for -arch_only
Aug 13 2020, 11:10 AM
sameerarora101 closed D84770: [llvm-libtool-darwin] Add support for -arch_only.
Aug 13 2020, 11:10 AM · Restricted Project
sameerarora101 committed rG8d58eb11f9da: [llvm-libtool-darwin] Refactor ArchiveWriter (authored by sameerarora101).
[llvm-libtool-darwin] Refactor ArchiveWriter
Aug 13 2020, 10:59 AM
sameerarora101 closed D84858: [llvm-libtool-darwin] Refactor ArchiveWriter.
Aug 13 2020, 10:58 AM · Restricted Project
sameerarora101 committed rG612b4dda7667: [llvm-install-name-tool] Add more documentation (authored by sameerarora101).
[llvm-install-name-tool] Add more documentation
Aug 13 2020, 10:49 AM
sameerarora101 closed D85655: [llvm-install-name-tool] Add more documentation.
Aug 13 2020, 10:48 AM · Restricted Project
sameerarora101 updated the diff for D84858: [llvm-libtool-darwin] Refactor ArchiveWriter.

Rebase to resolve previous build errors.

Aug 13 2020, 9:37 AM · Restricted Project
sameerarora101 updated the diff for D85655: [llvm-install-name-tool] Add more documentation.

Rebase to remove previous build errors.

Aug 13 2020, 9:25 AM · Restricted Project
sameerarora101 updated the diff for D85540: [llvm-libtool-darwin] Add support for -l and -L.

Rebase.

Aug 13 2020, 9:12 AM · Restricted Project
sameerarora101 updated the diff for D85334: [llvm-libtool-darwin] Support universal outputs.

Resolve test on windows (order in which architectures appear in test file).

Aug 13 2020, 9:07 AM · Restricted Project
sameerarora101 updated the diff for D85540: [llvm-libtool-darwin] Add support for -l and -L.

Add more tests.

Aug 13 2020, 8:54 AM · Restricted Project
sameerarora101 added inline comments to D85540: [llvm-libtool-darwin] Add support for -l and -L.
Aug 13 2020, 8:53 AM · Restricted Project
sameerarora101 updated the diff for D85334: [llvm-libtool-darwin] Support universal outputs.

Use unordered_map in place of DenseMap.

Aug 13 2020, 7:30 AM · Restricted Project
sameerarora101 added inline comments to D85334: [llvm-libtool-darwin] Support universal outputs.
Aug 13 2020, 7:24 AM · Restricted Project
sameerarora101 updated the diff for D84770: [llvm-libtool-darwin] Add support for -arch_only.

Remove redundant braces.

Aug 13 2020, 6:30 AM · Restricted Project
sameerarora101 added a comment to D84770: [llvm-libtool-darwin] Add support for -arch_only.

LGTM.

Let's commit this one as-is, and you can add arm64v8 to TextAPI and add the corresponding test here as a follow-up.

Aug 13 2020, 6:16 AM · Restricted Project

Aug 12 2020

sameerarora101 updated the diff for D85540: [llvm-libtool-darwin] Add support for -l and -L.

Add another test to check that files ending in '.o' are matched as-is.

Aug 12 2020, 2:53 PM · Restricted Project
sameerarora101 added inline comments to D85540: [llvm-libtool-darwin] Add support for -l and -L.
Aug 12 2020, 2:28 PM · Restricted Project
sameerarora101 added inline comments to D85540: [llvm-libtool-darwin] Add support for -l and -L.
Aug 12 2020, 1:31 PM · Restricted Project
sameerarora101 updated the diff for D85540: [llvm-libtool-darwin] Add support for -l and -L.

Use lambda function.

Aug 12 2020, 1:26 PM · Restricted Project
sameerarora101 added inline comments to D85540: [llvm-libtool-darwin] Add support for -l and -L.
Aug 12 2020, 1:02 PM · Restricted Project
sameerarora101 updated the diff for D85334: [llvm-libtool-darwin] Support universal outputs.

Replace auto.

Aug 12 2020, 12:21 PM · Restricted Project
sameerarora101 added inline comments to D85334: [llvm-libtool-darwin] Support universal outputs.
Aug 12 2020, 9:59 AM · Restricted Project
sameerarora101 updated the diff for D85334: [llvm-libtool-darwin] Support universal outputs.

Add tests for different cpu types.

Aug 12 2020, 9:51 AM · Restricted Project
sameerarora101 added inline comments to D85334: [llvm-libtool-darwin] Support universal outputs.
Aug 12 2020, 9:50 AM · Restricted Project

Aug 11 2020

sameerarora101 added inline comments to D85540: [llvm-libtool-darwin] Add support for -l and -L.
Aug 11 2020, 12:42 PM · Restricted Project
sameerarora101 updated the diff for D85540: [llvm-libtool-darwin] Add support for -l and -L.

Add more tests.

Aug 11 2020, 12:34 PM · Restricted Project
sameerarora101 added inline comments to D85540: [llvm-libtool-darwin] Add support for -l and -L.
Aug 11 2020, 12:31 PM · Restricted Project
sameerarora101 updated the diff for D85334: [llvm-libtool-darwin] Support universal outputs.

Make ArchCPUType and ArchCPUSubtype part of Config.

Aug 11 2020, 10:12 AM · Restricted Project
sameerarora101 added inline comments to D85334: [llvm-libtool-darwin] Support universal outputs.
Aug 11 2020, 10:07 AM · Restricted Project
sameerarora101 updated the diff for D84858: [llvm-libtool-darwin] Refactor ArchiveWriter.

Add Temp->dicard() error.

Aug 11 2020, 8:14 AM · Restricted Project
sameerarora101 added inline comments to D84858: [llvm-libtool-darwin] Refactor ArchiveWriter.
Aug 11 2020, 8:06 AM · Restricted Project
sameerarora101 added a comment to D84770: [llvm-libtool-darwin] Add support for -arch_only.

I think I need to add V8 support under llvm/include/llvm/TextAPI/MachO/Architecture.def here:

///
/// ARM64 architectures sorted by cpu sub type id.
///
ARCHINFO(arm64, MachO::CPU_TYPE_ARM64, MachO::CPU_SUBTYPE_ARM64_ALL, 64)
ARCHINFO(arm64e, MachO::CPU_TYPE_ARM64, MachO::CPU_SUBTYPE_ARM64E, 64)

What should be the first element for that tuple in case of V8 (arm64_v8 or arm64v8 or maybe something else) ? Thanks.

Hmm, what necessitates the TAPI patch? arm64_v8 seems fine to me, though @ributzka and @cishida should weigh in there.

Aug 11 2020, 7:35 AM · Restricted Project
sameerarora101 updated the diff for D85655: [llvm-install-name-tool] Add more documentation.

Remove extra lines.

Aug 11 2020, 7:15 AM · Restricted Project
sameerarora101 added inline comments to D85655: [llvm-install-name-tool] Add more documentation.
Aug 11 2020, 7:13 AM · Restricted Project

Aug 10 2020

sameerarora101 added a comment to D85655: [llvm-install-name-tool] Add more documentation.

This is how it would look online:

Aug 10 2020, 8:13 AM · Restricted Project
sameerarora101 requested review of D85655: [llvm-install-name-tool] Add more documentation.
Aug 10 2020, 8:11 AM · Restricted Project

Aug 7 2020

sameerarora101 added a comment to D84770: [llvm-libtool-darwin] Add support for -arch_only.

I think I need to add V8 support under llvm/include/llvm/TextAPI/MachO/Architecture.def here:

Aug 7 2020, 3:49 PM · Restricted Project
sameerarora101 updated the diff for D84770: [llvm-libtool-darwin] Add support for -arch_only.

Rebase after adding constant V8.

Aug 7 2020, 3:42 PM · Restricted Project
sameerarora101 committed rG71a1f135e4ed: [llvm-libtool-darwin] Add support for -D and -U options (authored by sameerarora101).
[llvm-libtool-darwin] Add support for -D and -U options
Aug 7 2020, 2:47 PM
sameerarora101 closed D84209: [llvm-libtool-darwin] Add support for -D and -U option.
Aug 7 2020, 2:47 PM · Restricted Project
sameerarora101 committed rGd9a9192984fa: [llvm-libtool-darwin] Add support for -filelist option (authored by sameerarora101).
[llvm-libtool-darwin] Add support for -filelist option
Aug 7 2020, 2:30 PM
sameerarora101 closed D84206: [llvm-libtool-darwin] Add support for -filelist option.
Aug 7 2020, 2:30 PM · Restricted Project
sameerarora101 committed rG645de3664a6b: [llvm-libtool-darwin] Add constant CPU_SUBTYPE_ARM64_V8 (authored by sameerarora101).
[llvm-libtool-darwin] Add constant CPU_SUBTYPE_ARM64_V8
Aug 7 2020, 2:13 PM
sameerarora101 closed D85041: [llvm-libtool-darwin] Add constant CPU_TYPE_ARM64_V8.
Aug 7 2020, 2:13 PM · Restricted Project
sameerarora101 committed rGcf26a1051767: Add symlinks for `libtool` and `install_name_tool` (authored by sameerarora101).
Add symlinks for `libtool` and `install_name_tool`
Aug 7 2020, 1:48 PM
sameerarora101 closed D85054: Add symlinks for `libtool` and `install_name_tool`.
Aug 7 2020, 1:47 PM · Restricted Project
sameerarora101 committed rGd6c00edf2eb8: [FileCheck] Add docs for --allow-empty (authored by sameerarora101).
[FileCheck] Add docs for --allow-empty
Aug 7 2020, 1:28 PM
sameerarora101 closed D83682: [FileCheck] Add docs for --allow-empty.
Aug 7 2020, 1:28 PM · Restricted Project
sameerarora101 committed rGbb4b70f79215: [llvm-install-name-tool] Adds docs for llvm-install-name-tool (authored by sameerarora101).
[llvm-install-name-tool] Adds docs for llvm-install-name-tool
Aug 7 2020, 12:52 PM
sameerarora101 closed D81944: [llvm-install-name-tool] Adds docs for install-name-tool.
Aug 7 2020, 12:52 PM · Restricted Project
sameerarora101 added inline comments to D85540: [llvm-libtool-darwin] Add support for -l and -L.
Aug 7 2020, 11:13 AM · Restricted Project
sameerarora101 requested review of D85540: [llvm-libtool-darwin] Add support for -l and -L.
Aug 7 2020, 11:07 AM · Restricted Project
sameerarora101 updated the diff for D85334: [llvm-libtool-darwin] Support universal outputs.

Adding more tests and resolve clang-tidy

Aug 7 2020, 9:08 AM · Restricted Project

Aug 5 2020

sameerarora101 requested review of D85334: [llvm-libtool-darwin] Support universal outputs.
Aug 5 2020, 11:25 AM · Restricted Project
sameerarora101 updated the diff for D84770: [llvm-libtool-darwin] Add support for -arch_only.

Rebase.

Aug 5 2020, 7:49 AM · Restricted Project
sameerarora101 updated the diff for D84209: [llvm-libtool-darwin] Add support for -D and -U option.

Rebase.

Aug 5 2020, 7:48 AM · Restricted Project
sameerarora101 updated the diff for D84206: [llvm-libtool-darwin] Add support for -filelist option.

Twine(Path).str() -> static_cast<std::string>(Path)

Aug 5 2020, 7:46 AM · Restricted Project
sameerarora101 added inline comments to D84206: [llvm-libtool-darwin] Add support for -filelist option.
Aug 5 2020, 7:44 AM · Restricted Project
sameerarora101 updated the diff for D85041: [llvm-libtool-darwin] Add constant CPU_TYPE_ARM64_V8.

Remove --check-prefix=FAT.

Aug 5 2020, 7:27 AM · Restricted Project
sameerarora101 added a comment to D84858: [llvm-libtool-darwin] Refactor ArchiveWriter.

Looks good, but I think it'll help if you can upload the dependent patch (draft) so that people can see that the interface is suitable.

Aug 5 2020, 7:11 AM · Restricted Project

Aug 4 2020

sameerarora101 abandoned D80838: [llvm-ar] Add more tests for errors in opening archives.

Closing revision as the issue has been addressed.

Aug 4 2020, 2:45 PM · Restricted Project
sameerarora101 updated the diff for D84858: [llvm-libtool-darwin] Refactor ArchiveWriter.

Removing OldArchiveBuf from writeArchiveToBuffer signature.

Aug 4 2020, 9:38 AM · Restricted Project
sameerarora101 added inline comments to D84858: [llvm-libtool-darwin] Refactor ArchiveWriter.
Aug 4 2020, 9:28 AM · Restricted Project
sameerarora101 updated the diff for D85041: [llvm-libtool-darwin] Add constant CPU_TYPE_ARM64_V8.

Update tests.

Aug 4 2020, 8:30 AM · Restricted Project
sameerarora101 added inline comments to D85041: [llvm-libtool-darwin] Add constant CPU_TYPE_ARM64_V8.
Aug 4 2020, 8:21 AM · Restricted Project

Aug 3 2020

sameerarora101 updated the diff for D84858: [llvm-libtool-darwin] Refactor ArchiveWriter.

Implement writeArchiveBuffer using SmallVectorMemoryBuffer.

Aug 3 2020, 1:39 PM · Restricted Project
sameerarora101 added inline comments to D84858: [llvm-libtool-darwin] Refactor ArchiveWriter.
Aug 3 2020, 12:03 PM · Restricted Project
sameerarora101 updated the diff for D85041: [llvm-libtool-darwin] Add constant CPU_TYPE_ARM64_V8.

Add test for llvm-readobj

Aug 3 2020, 11:35 AM · Restricted Project
sameerarora101 added inline comments to D85041: [llvm-libtool-darwin] Add constant CPU_TYPE_ARM64_V8.
Aug 3 2020, 11:31 AM · Restricted Project
sameerarora101 updated the diff for D84770: [llvm-libtool-darwin] Add support for -arch_only.

Invalid architecture error msg and consumeError comment.

Aug 3 2020, 8:35 AM · Restricted Project
sameerarora101 added inline comments to D84770: [llvm-libtool-darwin] Add support for -arch_only.
Aug 3 2020, 8:34 AM · Restricted Project
sameerarora101 updated the diff for D84858: [llvm-libtool-darwin] Refactor ArchiveWriter.

Change name and signature of writeArchiveBuffer

Aug 3 2020, 7:46 AM · Restricted Project
sameerarora101 added a comment to D85054: Add symlinks for `libtool` and `install_name_tool`.

yup, libtool and install_name_tool are the cctools names.

Aug 3 2020, 6:23 AM · Restricted Project

Jul 31 2020

sameerarora101 requested review of D85054: Add symlinks for `libtool` and `install_name_tool`.
Jul 31 2020, 3:27 PM · Restricted Project
sameerarora101 added inline comments to D84770: [llvm-libtool-darwin] Add support for -arch_only.
Jul 31 2020, 12:10 PM · Restricted Project
sameerarora101 requested review of D85041: [llvm-libtool-darwin] Add constant CPU_TYPE_ARM64_V8.
Jul 31 2020, 12:07 PM · Restricted Project
sameerarora101 committed rGdf69492cdfa8: [llvm-libtool-darwin] Refactor Slice and writeUniversalBinary (authored by sameerarora101).
[llvm-libtool-darwin] Refactor Slice and writeUniversalBinary
Jul 31 2020, 9:23 AM
sameerarora101 closed D84662: [llvm-libtool-darwin] Refactor Slice and writeUniversalBinary.
Jul 31 2020, 9:23 AM · Restricted Project
sameerarora101 updated the diff for D84770: [llvm-libtool-darwin] Add support for -arch_only.

Alphabetically ordering docs.

Jul 31 2020, 9:02 AM · Restricted Project
sameerarora101 added inline comments to D84770: [llvm-libtool-darwin] Add support for -arch_only.
Jul 31 2020, 9:02 AM · Restricted Project
sameerarora101 updated the diff for D84209: [llvm-libtool-darwin] Add support for -D and -U option.

Config C -> const Config &C

Jul 31 2020, 9:02 AM · Restricted Project

Jul 30 2020

sameerarora101 updated the diff for D84858: [llvm-libtool-darwin] Refactor ArchiveWriter.

Making writeArchiveInFD static

Jul 30 2020, 7:17 AM · Restricted Project
sameerarora101 added inline comments to D84858: [llvm-libtool-darwin] Refactor ArchiveWriter.
Jul 30 2020, 7:15 AM · Restricted Project

Jul 29 2020

sameerarora101 updated the diff for D84770: [llvm-libtool-darwin] Add support for -arch_only.

Add documentation for -arch_only option.

Jul 29 2020, 2:07 PM · Restricted Project
sameerarora101 added inline comments to D84858: [llvm-libtool-darwin] Refactor ArchiveWriter.
Jul 29 2020, 8:48 AM · Restricted Project
sameerarora101 requested review of D84858: [llvm-libtool-darwin] Refactor ArchiveWriter.
Jul 29 2020, 8:39 AM · Restricted Project
sameerarora101 updated the diff for D84770: [llvm-libtool-darwin] Add support for -arch_only.

Rebase

Jul 29 2020, 7:18 AM · Restricted Project
sameerarora101 updated the diff for D84209: [llvm-libtool-darwin] Add support for -D and -U option.

Add Config struct.

Jul 29 2020, 7:01 AM · Restricted Project
sameerarora101 added inline comments to D84209: [llvm-libtool-darwin] Add support for -D and -U option.
Jul 29 2020, 7:00 AM · Restricted Project