This is an archive of the discontinued LLVM Phabricator instance.

[asan] Mark the strstr test as UNSUPPORTED on FreeBSD
ClosedPublic

Authored by arichardson on Jul 24 2020, 10:47 AM.

Reviewers

Commits

Summary

Like Android, FreeBSDs libc calls memchr which causes this test to fail.

Herald added subscribers: Restricted Project, krytarowski, emaste. · View Herald Transcript

LGTM, we acquired our strstr from musl

This revision is now accepted and ready to land.Jul 24 2020, 11:12 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

compiler-rt/

test/

asan/

TestCases/

4 lines

	// Test strict_string_checks option in strstr function			// Test strict_string_checks option in strstr function
	// RUN: %clang_asan %s -o %t && %run %t 2>&1			// RUN: %clang_asan %s -o %t && %run %t 2>&1

	// Newer versions of Android's strstr() uses memchr() internally, which actually			// Newer versions of Android's strstr() uses memchr() internally, which actually
	// does trigger a heap-buffer-overflow (as it tries to find the			// does trigger a heap-buffer-overflow (as it tries to find the
	// null-terminator).			// null-terminator). The same applies to FreeBSD.
	// UNSUPPORTED: android			// UNSUPPORTED: android, freebsd
	// RUN: %env_asan_opts=strict_string_checks=false %run %t 2>&1			// RUN: %env_asan_opts=strict_string_checks=false %run %t 2>&1

	// RUN: %env_asan_opts=strict_string_checks=true not %run %t 2>&1 \| FileCheck %s			// RUN: %env_asan_opts=strict_string_checks=true not %run %t 2>&1 \| FileCheck %s

	#include <assert.h>			#include <assert.h>
	#include <stdlib.h>			#include <stdlib.h>
	#include <string.h>			#include <string.h>

	Show All 16 Lines