User Details
- User Since
- Sep 8 2017, 3:58 PM (187 w, 2 d)
Fri, Apr 9
It would be nice to include some details about MTE support (like the header size is 16 bytes rather than 8 bytes, etc). But we can make those changes afterwards.
Looks like this patch might have broken the ASan buildbots (https://lab.llvm.org/buildbot/#/builders/99/builds/2766):
wrong diffbase messed up phabricator rendering
Looks like this patch broke the UBSan buildbot (https://lab.llvm.org/buildbot/#/builders/5/builds/6546), PTAL.
Wed, Apr 7
Tue, Mar 16
Mar 11 2021
LGTM w/ nit
Mar 9 2021
Mar 5 2021
Hello, it looks like this change broke the MSan and ASan buildbots.
Mar 4 2021
Feb 23 2021
@pcc - friendly ping for a final pass when you have some spare time. Could you take a look at the comment in lit.site.cfg.py.in and see if you have any suggestions?
LGTM
LGTM w/ one nit.
Feb 22 2021
Feb 10 2021
Feb 9 2021
Inline the definitions required only on Android.
Feb 8 2021
Address Evgenii's comments.
Feb 5 2021
Feb 4 2021
(friendly ping)
Feb 2 2021
Rebase on top of D95542.
Rebased on top of D95542, which changed the GWP-ASan flag parsing dependencies. This patch does require a small change on the Scudo side, but the actual integration on top of this API (with some new fixes) is at D95884.
Rebase after kerfuffle.
Accidentally committed this in 9dc06762470cb5a6cde8de5833cb75262e1bacb0, and reverted it in 0dcf3324cfb4429e85b54e857f9bb86f423ffc5e. This is still needing review.
Addressed Kostya's comments.
Changed a comment and reformatted slightly.
Rebased on top of unwinder locking in D95889.
Feb 1 2021
Removed Scudo bits for now, made this GWP-ASan specific. Changes to scudo will come in a follow-up patch.
Jan 27 2021
Jan 26 2021
Address reviewer comments.
Jan 22 2021
Hi, looks like this patch broke UBSan on aarch64:
Jan 19 2021
Reverted in 5b7aef6eb4b2930971029b984cb2360f7682e5a5 to bring the ASan bots online. Repro instructions at https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild:
Jan 15 2021
Jan 14 2021
- Addressed eugenis@'s comments, delete unknown registry and remove some unnecessary code.
Jan 12 2021
(no longer relevant - much fresher patch should be coming soon to do the same thing)
We're actually going to kill support for compiler-rt based scudo on Android, so this patch should become obsolete soon. Preferably, we'd like to delete the entire thing but it seems like it might be used for Windows builds experimentally...
@eugenis - friendly ping
Jan 8 2021
- Update namespace in fuchsia file.
(friendly ping)
Jan 7 2021
Scratch this patch - polluted environment probably doesn't necessitate a workaround that increases the complexity of the runner.