Page MenuHomePhabricator
People hctim

hctim (Mitch Phillips)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 8 2017, 3:58 PM (187 w, 2 d)

Recent Activity
View All

Fri, Apr 9

hctim added a reverting change for rG5a0117b2d0ea: [AMDGPU] Remove MachineDCE after SIFoldOperands: rG092f288d3644: Revert "[AMDGPU] Remove MachineDCE after SIFoldOperands".
Fri, Apr 9, 3:48 PM
hctim committed rG092f288d3644: Revert "[AMDGPU] Remove MachineDCE after SIFoldOperands" (authored by hctim).
Revert "[AMDGPU] Remove MachineDCE after SIFoldOperands"
Fri, Apr 9, 3:48 PM
hctim added a reverting change for rGd19a42eba98f: [AMDGPU] SIFoldOperands: eagerly erase dead REG_SEQUENCEs: rG3d4730a73fd1: Revert "[AMDGPU] SIFoldOperands: eagerly erase dead REG_SEQUENCEs".
Fri, Apr 9, 3:48 PM
hctim added a reverting change for D100189: [AMDGPU] Remove MachineDCE after SIFoldOperands: rG092f288d3644: Revert "[AMDGPU] Remove MachineDCE after SIFoldOperands".
Fri, Apr 9, 3:48 PM · Restricted Project
hctim added a reverting change for D100188: [AMDGPU] SIFoldOperands: eagerly erase dead REG_SEQUENCEs: rG3d4730a73fd1: Revert "[AMDGPU] SIFoldOperands: eagerly erase dead REG_SEQUENCEs".
Fri, Apr 9, 3:48 PM · Restricted Project
hctim committed rG3d4730a73fd1: Revert "[AMDGPU] SIFoldOperands: eagerly erase dead REG_SEQUENCEs" (authored by hctim).
Revert "[AMDGPU] SIFoldOperands: eagerly erase dead REG_SEQUENCEs"
Fri, Apr 9, 3:48 PM
hctim accepted D100230: [docs][scudo] Update Scudo documentation.

It would be nice to include some details about MTE support (like the header size is 16 bytes rather than 8 bytes, etc). But we can make those changes afterwards.

Fri, Apr 9, 3:26 PM · Restricted Project
hctim added a comment to D100188: [AMDGPU] SIFoldOperands: eagerly erase dead REG_SEQUENCEs.

Looks like this patch might have broken the ASan buildbots (https://lab.llvm.org/buildbot/#/builders/99/builds/2766):

Fri, Apr 9, 3:05 PM · Restricted Project
hctim committed rG7df30e77d499: [ASan] Allow new/delete replacement by making interceptors weak (authored by hctim).
[ASan] Allow new/delete replacement by making interceptors weak
Fri, Apr 9, 2:20 PM
hctim closed D100220: [ASan] Allow new/delete replacement by making interceptors weak.
Fri, Apr 9, 2:20 PM · Restricted Project
hctim added a reverting change for rG16fe741c6942: [PowerPC] Add ROP Protection Instructions for PowerPC: rG1a2756b777b6: Revert "[PowerPC] Add ROP Protection Instructions for PowerPC".
Fri, Apr 9, 1:37 PM
hctim committed rG1a2756b777b6: Revert "[PowerPC] Add ROP Protection Instructions for PowerPC" (authored by hctim).
Revert "[PowerPC] Add ROP Protection Instructions for PowerPC"
Fri, Apr 9, 1:37 PM
hctim added a reverting change for D99375: [PowerPC] Add ROP Protection Instructions for PowerPC: rG1a2756b777b6: Revert "[PowerPC] Add ROP Protection Instructions for PowerPC".
Fri, Apr 9, 1:37 PM · Restricted Project
hctim updated the diff for D100220: [ASan] Allow new/delete replacement by making interceptors weak.

wrong diffbase messed up phabricator rendering

Fri, Apr 9, 1:02 PM · Restricted Project
hctim updated the diff for D100220: [ASan] Allow new/delete replacement by making interceptors weak.
In D100220#2680431, @eugenis wrote:

Add it to CXX_OPERATOR_ATTRIBUTE, on non-mac non-windows?

Fri, Apr 9, 1:01 PM · Restricted Project
hctim added a comment to D99375: [PowerPC] Add ROP Protection Instructions for PowerPC.

Looks like this patch broke the UBSan buildbot (https://lab.llvm.org/buildbot/#/builders/5/builds/6546), PTAL.

Fri, Apr 9, 12:13 PM · Restricted Project
hctim requested review of D100220: [ASan] Allow new/delete replacement by making interceptors weak.
Fri, Apr 9, 11:37 AM · Restricted Project

Wed, Apr 7

hctim committed rZORG43077c5c525b: Unconditionally pre-define CMAKE_ARGS in sanitizer bot. (authored by hctim).
Unconditionally pre-define CMAKE_ARGS in sanitizer bot.
Wed, Apr 7, 12:27 PM

Tue, Mar 16

hctim accepted D98732: scudo: Allow TBI to be disabled on Linux with a macro..
Tue, Mar 16, 12:49 PM · Restricted Project

Mar 11 2021

hctim accepted D98456: [scudo][standalone] Add shared library to makefile.
Mar 11 2021, 4:21 PM · Restricted Project
hctim added a comment to D98456: [scudo][standalone] Add shared library to makefile.

LGTM w/ nit

Mar 11 2021, 3:19 PM · Restricted Project

Mar 9 2021

hctim added a comment to D96120: [scudo] Port scudo sanitizer to Windows.
In D96120#2615085, @russell.gallop wrote:
In D96120#2597877, @kcc wrote:

I am afraid we will have to delete the older (non-standalone) variant entirely.
(And the sooner the better)

Okay, think we found a few things out by doing this before porting standalone.

If I find time I’ll have a go at removing the sanitizer version.

The scudo documentation (https://llvm.org/docs/ScudoHardenedAllocator.html) still seems to refer to the sanitizer version so will need updating.

Mar 9 2021, 2:46 PM · Restricted Project, Restricted Project

Mar 5 2021

hctim committed rGe58d68fcd06d: Revert "[AMDGPU] Restore the s_memtime instruction in gfx1030" (authored by hctim).
Revert "[AMDGPU] Restore the s_memtime instruction in gfx1030"
Mar 5 2021, 6:25 PM
hctim added a reverting change for rGfc28f600e558: [AMDGPU] Restore the s_memtime instruction in gfx1030: rGe58d68fcd06d: Revert "[AMDGPU] Restore the s_memtime instruction in gfx1030".
Mar 5 2021, 6:25 PM
hctim added a reverting change for D97928: [AMDGPU] Restore the s_memtime instruction in gfx1030: rGe58d68fcd06d: Revert "[AMDGPU] Restore the s_memtime instruction in gfx1030".
Mar 5 2021, 6:25 PM · Restricted Project, Restricted Project
hctim added a comment to D97928: [AMDGPU] Restore the s_memtime instruction in gfx1030.

Hello, it looks like this change broke the MSan and ASan buildbots.

Mar 5 2021, 4:48 PM · Restricted Project, Restricted Project

Mar 4 2021

hctim committed rG1be97975ccc6: Change instrprof LLVM_VP_MAX_NUM_VALS_PER_SITE threshold. (authored by hctim).
Change instrprof LLVM_VP_MAX_NUM_VALS_PER_SITE threshold.
Mar 4 2021, 12:14 PM

Feb 23 2021

hctim added a comment to D95884: [Scudo] Use GWP-ASan's aligned allocations and fixup postalloc hooks..

@pcc - friendly ping for a final pass when you have some spare time. Could you take a look at the comment in lit.site.cfg.py.in and see if you have any suggestions?

Feb 23 2021, 1:33 PM · Restricted Project
hctim accepted D96435: [scudo][standalone] Compact pointers for Caches/Batches.

LGTM

Feb 23 2021, 11:05 AM · Restricted Project
hctim accepted D96435: [scudo][standalone] Compact pointers for Caches/Batches.

LGTM w/ one nit.

Feb 23 2021, 9:44 AM · Restricted Project

Feb 22 2021

hctim added inline comments to D96435: [scudo][standalone] Compact pointers for Caches/Batches.
Feb 22 2021, 1:27 PM · Restricted Project

Feb 10 2021

hctim committed rGb93786907c54: [GWP-ASan] Add back some headers removed by IWYU. (authored by hctim).
[GWP-ASan] Add back some headers removed by IWYU.
Feb 10 2021, 9:14 AM
hctim closed D96374: [GWP-ASan] Add back some headers removed by IWYU..
Feb 10 2021, 9:14 AM · Restricted Project

Feb 9 2021

hctim updated the diff for D96374: [GWP-ASan] Add back some headers removed by IWYU..

Inline the definitions required only on Android.

Feb 9 2021, 2:57 PM · Restricted Project
hctim requested review of D96374: [GWP-ASan] Add back some headers removed by IWYU..
Feb 9 2021, 2:55 PM · Restricted Project

Feb 8 2021

hctim added inline comments to D93731: scudo: Support memory tagging in the secondary allocator..
Feb 8 2021, 3:50 PM · Restricted Project
hctim added inline comments to D95884: [Scudo] Use GWP-ASan's aligned allocations and fixup postalloc hooks..
Feb 8 2021, 12:37 PM · Restricted Project
hctim added inline comments to D95884: [Scudo] Use GWP-ASan's aligned allocations and fixup postalloc hooks..
Feb 8 2021, 11:25 AM · Restricted Project
hctim edited reviewers for D95884: [Scudo] Use GWP-ASan's aligned allocations and fixup postalloc hooks., added: pcc; removed: eugenis.
Feb 8 2021, 11:24 AM · Restricted Project
hctim committed rG3d8823b8e48a: [GWP-ASan] Add aligned allocations. (authored by hctim).
[GWP-ASan] Add aligned allocations.
Feb 8 2021, 11:23 AM
hctim closed D94830: [GWP-ASan] Add aligned allocations..
Feb 8 2021, 11:23 AM · Restricted Project
hctim updated the diff for D94830: [GWP-ASan] Add aligned allocations..

Address Evgenii's comments.

Feb 8 2021, 10:17 AM · Restricted Project

Feb 5 2021

hctim added a comment to D95884: [Scudo] Use GWP-ASan's aligned allocations and fixup postalloc hooks..
In D95884#2545237, @cryptoad wrote:

I think the skip in the tests will not work on Fuchsia. I'll check.

Feb 5 2021, 9:13 AM · Restricted Project

Feb 4 2021

hctim added a comment to D94830: [GWP-ASan] Add aligned allocations..

(friendly ping)

Feb 4 2021, 9:15 AM · Restricted Project

Feb 2 2021

hctim accepted D95921: [scudo/standalone] Use zx_system_get_page_size() on Fuchsia.
Feb 2 2021, 9:18 PM · Restricted Project
hctim accepted D95920: [gwp_asan] Use zx_system_get_page_size() on Fuchsia.
Feb 2 2021, 9:18 PM · Restricted Project
hctim updated the diff for D95884: [Scudo] Use GWP-ASan's aligned allocations and fixup postalloc hooks..

Rebase on top of D95542.

Feb 2 2021, 4:35 PM · Restricted Project
hctim updated the diff for D94830: [GWP-ASan] Add aligned allocations..

Rebased on top of D95542, which changed the GWP-ASan flag parsing dependencies. This patch does require a small change on the Scudo side, but the actual integration on top of this API (with some new fixes) is at D95884.

Feb 2 2021, 3:34 PM · Restricted Project
hctim updated the diff for D94830: [GWP-ASan] Add aligned allocations..

Rebase after kerfuffle.

Feb 2 2021, 2:51 PM · Restricted Project
hctim reopened D94830: [GWP-ASan] Add aligned allocations..

Accidentally committed this in 9dc06762470cb5a6cde8de5833cb75262e1bacb0, and reverted it in 0dcf3324cfb4429e85b54e857f9bb86f423ffc5e. This is still needing review.

Feb 2 2021, 2:48 PM · Restricted Project
hctim added a reverting change for rG9dc06762470c: [GWP-ASan] Add aligned allocations.: rG0dcf3324cfb4: Revert "[GWP-ASan] Add aligned allocations.".
Feb 2 2021, 2:47 PM
hctim committed rG0dcf3324cfb4: Revert "[GWP-ASan] Add aligned allocations." (authored by hctim).
Revert "[GWP-ASan] Add aligned allocations."
Feb 2 2021, 2:47 PM
hctim added a reverting change for D94830: [GWP-ASan] Add aligned allocations.: rG0dcf3324cfb4: Revert "[GWP-ASan] Add aligned allocations.".
Feb 2 2021, 2:47 PM · Restricted Project
hctim committed rG30973f6fe01c: [GWP-ASan] Add locking around unwinder for atfork protection. (authored by hctim).
[GWP-ASan] Add locking around unwinder for atfork protection.
Feb 2 2021, 2:45 PM
hctim committed rG9dc06762470c: [GWP-ASan] Add aligned allocations. (authored by hctim).
[GWP-ASan] Add aligned allocations.
Feb 2 2021, 2:45 PM
hctim closed D95889: [GWP-ASan] Add locking around unwinder for atfork protection..
Feb 2 2021, 2:45 PM · Restricted Project
hctim closed D94830: [GWP-ASan] Add aligned allocations..
Feb 2 2021, 2:45 PM · Restricted Project
hctim updated the diff for D94830: [GWP-ASan] Add aligned allocations..

Addressed Kostya's comments.

Feb 2 2021, 2:31 PM · Restricted Project
hctim updated the summary of D95884: [Scudo] Use GWP-ASan's aligned allocations and fixup postalloc hooks..
Feb 2 2021, 2:26 PM · Restricted Project
hctim updated the diff for D95884: [Scudo] Use GWP-ASan's aligned allocations and fixup postalloc hooks..

Changed a comment and reformatted slightly.

Feb 2 2021, 2:26 PM · Restricted Project
hctim updated the diff for D95884: [Scudo] Use GWP-ASan's aligned allocations and fixup postalloc hooks..

Rebased on top of unwinder locking in D95889.

Feb 2 2021, 2:22 PM · Restricted Project
hctim requested review of D95889: [GWP-ASan] Add locking around unwinder for atfork protection..
Feb 2 2021, 11:48 AM · Restricted Project
hctim requested review of D95884: [Scudo] Use GWP-ASan's aligned allocations and fixup postalloc hooks..
Feb 2 2021, 10:30 AM · Restricted Project

Feb 1 2021

hctim added inline comments to D94830: [GWP-ASan] Add aligned allocations..
Feb 1 2021, 11:12 AM · Restricted Project
hctim updated the diff for D94830: [GWP-ASan] Add aligned allocations..

Removed Scudo bits for now, made this GWP-ASan specific. Changes to scudo will come in a follow-up patch.

Feb 1 2021, 11:10 AM · Restricted Project
hctim retitled D94830: [GWP-ASan] Add aligned allocations. from [GWP-ASan] Add 'user requested' size and fix Scudo. to [GWP-ASan] Add aligned allocations..
Feb 1 2021, 11:09 AM · Restricted Project

Jan 27 2021

hctim accepted D95542: [scudo][standalone] Restore GWP-ASan flag parsing.
Jan 27 2021, 11:42 AM · Restricted Project

Jan 26 2021

hctim planned changes to D94830: [GWP-ASan] Add aligned allocations..
Jan 26 2021, 4:46 PM · Restricted Project
hctim updated the diff for D94830: [GWP-ASan] Add aligned allocations..

Address reviewer comments.

Jan 26 2021, 4:46 PM · Restricted Project
hctim added a comment to D94830: [GWP-ASan] Add aligned allocations..
In D94830#2502424, @cryptoad wrote:

Is there some test that can be added that would find a regression?

Jan 26 2021, 4:37 PM · Restricted Project
hctim updated the summary of D94830: [GWP-ASan] Add aligned allocations..
Jan 26 2021, 4:26 PM · Restricted Project
hctim added inline comments to D92696: [GWP-ASan] Add inbuilt options parser..
Jan 26 2021, 2:23 PM · Restricted Project
hctim added inline comments to D92696: [GWP-ASan] Add inbuilt options parser..
Jan 26 2021, 11:41 AM · Restricted Project

Jan 22 2021

hctim added a reverting change for rG3dedad475da4: [AArch64][GlobalISel] Make G_USUBO legal and select it.: rG19ec559c665e: Revert "[AArch64][GlobalISel] Make G_USUBO legal and select it.".
Jan 22 2021, 2:33 PM
hctim committed rG19ec559c665e: Revert "[AArch64][GlobalISel] Make G_USUBO legal and select it." (authored by hctim).
Revert "[AArch64][GlobalISel] Make G_USUBO legal and select it."
Jan 22 2021, 2:33 PM
hctim added a reverting change for rG541d98efa222: [AArch64][GlobalISel] Implement widenScalar for signed overflow: rGe3a7532cc95e: Revert "[AArch64][GlobalISel] Implement widenScalar for signed overflow".
Jan 22 2021, 2:33 PM
hctim committed rGe3a7532cc95e: Revert "[AArch64][GlobalISel] Implement widenScalar for signed overflow" (authored by hctim).
Revert "[AArch64][GlobalISel] Implement widenScalar for signed overflow"
Jan 22 2021, 2:33 PM
hctim added a reverting change for D95032: [AArch64][GlobalISel] Make G_USUBO legal and select it: rG19ec559c665e: Revert "[AArch64][GlobalISel] Make G_USUBO legal and select it.".
Jan 22 2021, 2:33 PM · Restricted Project
hctim added a reverting change for rG2bb92bf451d7: [GlobalISel] LegalizerHelper - Extract widenScalarAddoSubo method: rG554b3211fefd: Revert "[GlobalISel] LegalizerHelper - Extract widenScalarAddoSubo method".
Jan 22 2021, 2:33 PM
hctim committed rG554b3211fefd: Revert "[GlobalISel] LegalizerHelper - Extract widenScalarAddoSubo method" (authored by hctim).
Revert "[GlobalISel] LegalizerHelper - Extract widenScalarAddoSubo method"
Jan 22 2021, 2:33 PM
hctim added a reverting change for D95034: [AArch64][GlobalISel] Implement widenScalar for signed overflow: rGe3a7532cc95e: Revert "[AArch64][GlobalISel] Implement widenScalar for signed overflow".
Jan 22 2021, 2:33 PM · Restricted Project
hctim added a reverting change for D95035: [GlobalISel] LegalizerHelper - Extract widenScalarAddoSubo method: rG554b3211fefd: Revert "[GlobalISel] LegalizerHelper - Extract widenScalarAddoSubo method".
Jan 22 2021, 2:33 PM · Restricted Project
hctim added a comment to D95032: [AArch64][GlobalISel] Make G_USUBO legal and select it.

Hi, looks like this patch broke UBSan on aarch64:

Jan 22 2021, 2:16 PM · Restricted Project

Jan 19 2021

hctim added a comment to D94267: [PDB] Defer relocating .debug$S until commit time and parallelize it.

Reverted in 5b7aef6eb4b2930971029b984cb2360f7682e5a5 to bring the ASan bots online. Repro instructions at https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild:

Jan 19 2021, 11:48 AM · Restricted Project
hctim added a reverting change for rG6529d7c5a45b: [PDB] Defer relocating .debug$S until commit time and parallelize it: rG5b7aef6eb4b2: Revert "[PDB] Defer relocating .debug$S until commit time and parallelize it".
Jan 19 2021, 11:46 AM
hctim committed rG5b7aef6eb4b2: Revert "[PDB] Defer relocating .debug$S until commit time and parallelize it" (authored by hctim).
Revert "[PDB] Defer relocating .debug$S until commit time and parallelize it"
Jan 19 2021, 11:46 AM
hctim added a reverting change for D94267: [PDB] Defer relocating .debug$S until commit time and parallelize it: rG5b7aef6eb4b2: Revert "[PDB] Defer relocating .debug$S until commit time and parallelize it".
Jan 19 2021, 11:46 AM · Restricted Project

Jan 15 2021

hctim requested review of D94830: [GWP-ASan] Add aligned allocations..
Jan 15 2021, 2:39 PM · Restricted Project
hctim committed rG6a42cbf6d211: [GWP-ASan] Add inbuilt options parser. (authored by hctim).
[GWP-ASan] Add inbuilt options parser.
Jan 15 2021, 1:18 PM
hctim closed D92696: [GWP-ASan] Add inbuilt options parser..
Jan 15 2021, 1:17 PM · Restricted Project

Jan 14 2021

hctim updated the diff for D92696: [GWP-ASan] Add inbuilt options parser..
  • Addressed eugenis@'s comments, delete unknown registry and remove some unnecessary code.
Jan 14 2021, 1:32 PM · Restricted Project
hctim committed rGa8520f6970fd: [GWP-ASan] Minor refactor of optional components. (authored by hctim).
[GWP-ASan] Minor refactor of optional components.
Jan 14 2021, 11:14 AM
hctim closed D94117: [GWP-ASan] Minor refactor of optional components..
Jan 14 2021, 11:14 AM · Restricted Project

Jan 12 2021

hctim abandoned D64457: [GWP-ASan] Attempt to fix Android/ARM platforms..

(no longer relevant - much fresher patch should be coming soon to do the same thing)

Jan 12 2021, 1:39 PM · Restricted Project, Restricted Project
hctim abandoned D94105: [scudo] [android] Use ELF TLS on Android API >= 30..

We're actually going to kill support for compiler-rt based scudo on Android, so this patch should become obsolete soon. Preferably, we'd like to delete the entire thing but it seems like it might be used for Windows builds experimentally...

Jan 12 2021, 12:30 PM · Restricted Project
hctim added a comment to D94117: [GWP-ASan] Minor refactor of optional components..

@eugenis - friendly ping

Jan 12 2021, 10:59 AM · Restricted Project

Jan 8 2021

hctim updated the diff for D94117: [GWP-ASan] Minor refactor of optional components..
  • Update namespace in fuchsia file.
Jan 8 2021, 11:07 AM · Restricted Project
hctim added a comment to D94117: [GWP-ASan] Minor refactor of optional components..

(friendly ping)

Jan 8 2021, 10:14 AM · Restricted Project

Jan 7 2021

hctim abandoned D93499: [sanitizers] Force pickup of new symbolizer (round #2)..

Scratch this patch - polluted environment probably doesn't necessitate a workaround that increases the complexity of the runner.

Jan 7 2021, 8:59 AM · Restricted Project

Jan 6 2021

hctim added inline comments to D93499: [sanitizers] Force pickup of new symbolizer (round #2)..
Jan 6 2021, 4:04 PM · Restricted Project