Page MenuHomePhabricator

dim (Dimitry Andric)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 15 2014, 12:19 PM (397 w, 4 d)

Recent Activity

Thu, Nov 25

dim added a comment to D114555: [ScalarEvolution] Add bailout to avoid zext of pointer..

FWIW, this fixes both the minimized test case from PR52594, and the full original test case from https://bugs.freebsd.org/260000.

Thu, Nov 25, 1:06 AM · Restricted Project

Wed, Nov 24

dim committed rG187d9979f22e: cfi: fix more -Wformat warnings (authored by dim).
cfi: fix more -Wformat warnings
Wed, Nov 24, 12:49 PM
dim closed D114466: cfi: fix more -Wformat warnings.
Wed, Nov 24, 12:48 PM · Restricted Project

Tue, Nov 23

dim updated the diff for D114469: [XRay] fix more -Wformat warnings.

Squash commits because arc tricked me.

Tue, Nov 23, 1:03 PM · Restricted Project
dim updated the diff for D114469: [XRay] fix more -Wformat warnings.

Drop trailing dots from report messages.

Tue, Nov 23, 1:02 PM · Restricted Project
dim committed rGb5a927b972b2: [lldb] Move create_relative_symlink function up in CMake hierarchy (authored by dim).
[lldb] Move create_relative_symlink function up in CMake hierarchy
Tue, Nov 23, 1:00 PM
dim closed D114465: [lldb] Move create_relative_symlink function up in CMake hierarchy.
Tue, Nov 23, 1:00 PM · Restricted Project
dim requested review of D114469: [XRay] fix more -Wformat warnings.
Tue, Nov 23, 12:36 PM · Restricted Project
dim abandoned D114468: Lint..
Tue, Nov 23, 12:35 PM · Restricted Project
dim requested review of D114468: Lint..
Tue, Nov 23, 12:35 PM · Restricted Project
dim requested review of D114466: cfi: fix more -Wformat warnings.
Tue, Nov 23, 12:13 PM · Restricted Project
dim requested review of D114465: [lldb] Move create_relative_symlink function up in CMake hierarchy.
Tue, Nov 23, 11:58 AM · Restricted Project

Mon, Nov 22

dim accepted D114396: [Driver] Default to current FreeBSD profiling behaviour.

LGTM

Mon, Nov 22, 11:57 PM
dim added a comment to D113443: [FreeBSD] avoid marking __stack_chk_guard symbol as dso_local on PPC64.

Note that this is the version as we have it in the FreeBSD base system version of llvm 13.0.0. Without the isPPC64() check, we would get unexpected R_X86_64_REX_GOTP relocations in our kernel modules, which the kernel module loader cannot handle; see e.g. https://reviews.llvm.org/D109090#3113552 and further comments.

Mon, Nov 22, 11:46 AM · Restricted Project
dim accepted D77776: [Driver] Default to libc++ on FreeBSD.

LGTM

Mon, Nov 22, 8:43 AM · Restricted Project

Sat, Nov 20

dim committed rG7dbbb5d3a46e: compiler-rt: Use FreeBSD's elf_aux_info to detect AArch64 HW features (authored by dim).
compiler-rt: Use FreeBSD's elf_aux_info to detect AArch64 HW features
Sat, Nov 20, 3:13 AM
dim closed D109330: compiler-rt: Use FreeBSD's elf_aux_info for detecting ARM HW features.
Sat, Nov 20, 3:13 AM · Restricted Project

Wed, Nov 17

dim updated subscribers of D92397: [libc++] Always define a key function for std::bad_function_call in the dylib.
Wed, Nov 17, 1:23 AM · Restricted Project

Sat, Nov 6

dim updated subscribers of D109090: [FreeBSD] avoid marking __stack_chk_guard symbol as dso_local on FreeBSD.

Hmm this seems to cause some trouble when building kernels and kernel modules on FreeBSD, which are built in -ffreestanding mode, and then you get weird relocations in kernel modules:

Sat, Nov 6, 6:00 AM · Restricted Project

Oct 19 2021

dim updated subscribers of D111863: [libunwind] Add an interface for dynamic .eh_frame registration.

It's also worth noting that FreeBSD's version of libgcc exception handling is actually based on the libunwind code, with a local patch that implements compatibility with libgcc __register_frame by changing it to parse an entire .eh_frame section (in a slightly more ad hoc fashion than this code). Having this new entry point in-tree would simplify the FreeBSD local changes.

Oct 19 2021, 2:24 AM · Restricted Project, Restricted Project

Oct 18 2021

dim accepted D111967: [Mips] Add glue between CopyFromReg, CopyToReg and RDHWR nodes for TLS.

This worked OK for building both 32-bit and 64-bit mips worlds on FreeBSD. Thanks!

Oct 18 2021, 5:49 AM · Restricted Project

Sep 26 2021

dim accepted D110213: [PowerPC] Define XL-compatible macros only for AIX and Linux.

FWIW I think this is fine.

Sep 26 2021, 5:18 AM · Restricted Project

Sep 21 2021

dim added a comment to D110126: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on FreeBSD.

I tried building head-of-main with LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON, and one thing I noticed is that the directories have the minor version swizzled in:

Sep 21 2021, 10:51 AM · Restricted Project

Sep 19 2021

dim added inline comments to D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO.
Sep 19 2021, 10:22 AM · Restricted Project

Sep 16 2021

dim added a comment to D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO.

I can at least confirm that both the original test case for bug 51862 (from https://github.com/Macaulay2/frobby ) and the reduced test case compile successfully with this patch added.

Sep 16 2021, 10:09 AM · Restricted Project

Sep 9 2021

dim committed rTad49cd738e93: Avoid use of gets() in DOE-ProxyApps-C/Pathfinder (authored by dim).
Avoid use of gets() in DOE-ProxyApps-C/Pathfinder
Sep 9 2021, 1:17 AM
dim closed D89556: Avoid use of gets() in DOE-ProxyApps-C/Pathfinder.
Sep 9 2021, 1:17 AM

Sep 7 2021

dim updated the diff for D109330: compiler-rt: Use FreeBSD's elf_aux_info for detecting ARM HW features.

Use version committed into FreeBSD 14-CURRENT.

Sep 7 2021, 2:34 PM · Restricted Project
dim added reviewers for D109330: compiler-rt: Use FreeBSD's elf_aux_info for detecting ARM HW features: emaste, arichardson.
Sep 7 2021, 2:33 PM · Restricted Project
dim commandeered D109330: compiler-rt: Use FreeBSD's elf_aux_info for detecting ARM HW features.
Sep 7 2021, 2:33 PM · Restricted Project
dim accepted D109374: [Support] Implement getMainExecutable on Solaris.

I can't vouch for the Solaris specific parts, but it looks sane to me. I guess you won't need to add any tests, since this will fix many now-failing tests? :)

Sep 7 2021, 10:50 AM · Restricted Project
dim added a comment to D109330: compiler-rt: Use FreeBSD's elf_aux_info for detecting ARM HW features.

Address comment.

dim@FreeBSD.org committed a in slightly different version in FreeBSD src tree. Should I use its version instead?

Thanks!

Yes that looks reasonable to me. CC: @dim

Sep 7 2021, 10:46 AM · Restricted Project

Sep 5 2021

dim added a comment to D109248: Annotate `llvm.eh.sjlj.setjmp` as `returns_twice`.

I'm not a reviewer, but this looks good to me. (At first I thought that the required tablegen additions were missing, but they were at the end of the list of files so I missed them :) )

Sep 5 2021, 10:36 AM · Restricted Project

Sep 2 2021

dim added a comment to D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL..

The idea with putting all of these in a separate function was to:

  1. Make it easy to limit it to specific targets as I suggested above
  2. Have them all in one place to easily identify which ones are added for this compatibility so we can eventually pull this support once they are no longer needed
  3. Just kind of isolate this to keep it out of the way

I really think the best way forward might be to limit this to Linux and AIX. I don't think IBM provided XLC/C++ on FreeBSD.

Sep 2 2021, 8:10 AM · Restricted Project
dim added a comment to D108630: [libc++] Remove _LIBCPP_HAS_NO_LONG_LONG in favour of using_if_exists.

Ah, gcc doesn't work at all with libc++ before C+11 :) I tried with gcc 12.0.0 20210711, and it spews hundreds of errors, starting off with:

Sep 2 2021, 6:27 AM · Restricted Project
dim accepted D108630: [libc++] Remove _LIBCPP_HAS_NO_LONG_LONG in favour of using_if_exists.

Hmm I have applied this on top of our existing libc++ headers, but if I compile a simple program using e.g. -std=c++98 I immediately get errors due to missing declarations:

...

But I think this is because my current clang is still 12.0.1? Was using_if_exists only added after 13.0.0 ?

Sep 2 2021, 4:20 AM · Restricted Project
dim added a comment to D108630: [libc++] Remove _LIBCPP_HAS_NO_LONG_LONG in favour of using_if_exists.

Hmm I have applied this on top of our existing libc++ headers, but if I compile a simple program using e.g. -std=c++98 I immediately get errors due to missing declarations:

Sep 2 2021, 2:48 AM · Restricted Project

Aug 31 2021

dim added a comment to D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL..

Just encountered another similar error, apparently introduced in rGc8937b6cb9751807de1e69f0f0f70a9a58f8f5dc (as more additions to the defineXLCompatMacros function, by @lei):

Aug 31 2021, 3:08 PM · Restricted Project
dim updated subscribers of D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL..

Note that this unexpectedly broke FreeBSD's powerpc64 builds, as we've long used the following in our lib/libc/powerpc64/string/bcopy.S:

...

However, I think I can make do with adding -U__bcopy to the clang command line. It would have been nice if these aliases were behind some --xl-compat flag... :)

I am really sorry that we broke you. Would it help if we defined this macro only if compiling for Linux/AIX? If so, are there any others (or perhaps all of them) that you'd like us to conditionally define only on AIX/Linux?

Aug 31 2021, 3:53 AM · Restricted Project

Aug 30 2021

dim updated subscribers of D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL..

Note that this unexpectedly broke FreeBSD's powerpc64 builds, as we've long used the following in our lib/libc/powerpc64/string/bcopy.S:

Aug 30 2021, 1:59 PM · Restricted Project

Aug 25 2021

dim committed rG18da6db838c5: [libc++][NFC] Remove duplicate ranges entry in CMakeLists.txt. (authored by dim).
[libc++][NFC] Remove duplicate ranges entry in CMakeLists.txt.
Aug 25 2021, 2:50 PM
dim closed D108726: [libc++][NFC] Remove duplicate ranges entry in CMakeLists.txt..
Aug 25 2021, 2:50 PM · Restricted Project
dim requested review of D108726: [libc++][NFC] Remove duplicate ranges entry in CMakeLists.txt..
Aug 25 2021, 2:12 PM · Restricted Project

Aug 24 2021

dim added inline comments to D108630: [libc++] Remove _LIBCPP_HAS_NO_LONG_LONG in favour of using_if_exists.
Aug 24 2021, 8:16 AM · Restricted Project

Aug 19 2021

dim added a comment to D107972: [Flang] Fix build failure on MacOS.

Thanks. This should be merged to 13.0.0, if possible.

Meanwhile, if I may take a moment of your attention, I ran into this particular error (narrowing {-1} to clock_t) while doing the 13.0.0 rc1 builds for i386-freebsd, i.e. 32-bit x86. Since I encountered a whole lot of other issues where 32 and 64 bit quantities were mixed, does it make sense at all to attempt to build flang on 32-bit systems?

My guess is that this was never a goal, and 64 bit systems (i.e. LP64) are really the only support targets?

Could @sscalpone or @klausler or @schweitz take this question?

@dim I did not get a chance to discuss this with everyone. But my understanding is that at the moment we test only for 64 bit systems. Support for 32 bit systems (I think) is not ruled out but is not of immediate interest.

Aug 19 2021, 12:27 PM · Restricted Project, Restricted Project
dim added a comment to D101406: Rename human-readable name for DW_LANG_Mips_Assembler.

This can't have been the intention of this commit? As far as I can see, there *is* no plugin for plain assembler?

...

Yes, there is no plugin for the language assembler. But that hasn't chnaged with this commit.

Aug 19 2021, 1:31 AM · Restricted Project

Aug 18 2021

dim added a comment to D108120: [lld] Add CMake options to disable individual linkers.

It's mostly about shaving off quite a bit of build time, if you can skip all the formats that you never use. The size reduction is also nice, but is not really the essential part.

Aug 18 2021, 3:15 PM · Restricted Project, Restricted Project

Aug 17 2021

dim accepted D108120: [lld] Add CMake options to disable individual linkers.

Indeed in the FreeBSD base system we only build the ELF part and patch lldMain to stub out the rest, see https://github.com/freebsd/freebsd-src/commit/59948e95d8deadafca3acd659b6dfc78b708f117

Aug 17 2021, 12:22 PM · Restricted Project, Restricted Project
dim accepted D106906: [Nomination] Adding an Nvidia representative to security group.
Aug 17 2021, 11:30 AM · Restricted Project
dim accepted D108203: [libc++] Rely solely on using_if_exists for ::aligned_alloc, ::quick_exit and ::timespec_get.

Expand the change to timespec_get and quick_exit.

Note that we'll have to wait for a while before we can submit this change, since we need to drop support
for Clang 12 (which doesn't support the attribute).

Aug 17 2021, 11:28 AM · Restricted Project
dim added a comment to D101406: Rename human-readable name for DW_LANG_Mips_Assembler.

Everyone uses this for any assembly in their code. Should we get rid of this warning? I find it is useless and would like to see it go.

Aug 17 2021, 12:01 AM · Restricted Project

Aug 16 2021

dim committed rG5033f0793fe6: [lldb] Avoid unhandled Error in TypeSystemMap::GetTypeSystemForLanguage (authored by dim).
[lldb] Avoid unhandled Error in TypeSystemMap::GetTypeSystemForLanguage
Aug 16 2021, 8:38 AM
dim closed D108088: [lldb] Avoid unhandled Error in TypeSystemMap::GetTypeSystemForLanguage.
Aug 16 2021, 8:38 AM · Restricted Project

Aug 15 2021

dim requested review of D108088: [lldb] Avoid unhandled Error in TypeSystemMap::GetTypeSystemForLanguage.
Aug 15 2021, 9:01 AM · Restricted Project

Aug 14 2021

dim added a comment to D101406: Rename human-readable name for DW_LANG_Mips_Assembler.

Hmm so now on FreeBSD, basically *every* program will cause this warning, as our C startup objects are compiled from .S files, e.g.:

Aug 14 2021, 12:41 PM · Restricted Project

Aug 12 2021

dim added a comment to D107972: [Flang] Fix build failure on MacOS.

Thanks. This should be merged to 13.0.0, if possible.

Aug 12 2021, 11:15 AM · Restricted Project, Restricted Project

Aug 10 2021

dim added a comment to D105716: sanitizer_common: add thread safety annotations.

I can keep that part if you prefer (with REPLACE "-W" "-Wno-").

Aug 10 2021, 8:09 AM · Restricted Project
dim added a comment to D105716: sanitizer_common: add thread safety annotations.

I did not know about COMPILER_RT_ENABLE_WERROR enabled on some bots.
And also I was wrong about existing warnings. They present but only with gcc (since I compile with both regularly, I had impression I always see warnings).
I've mailed https://reviews.llvm.org/D107826 is it what you meant?
I've also removed the FreeBSD workaround added by @dim. It won't be needed anymore, right?

Aug 10 2021, 7:40 AM · Restricted Project

Aug 9 2021

dim added a comment to D105716: sanitizer_common: add thread safety annotations.

It looks like this also causes a build error on FreeBSD 11 even without tests, due to a false positive warning:

...

Apparently the used compiler is clang 6.0.

Aug 9 2021, 10:55 AM · Restricted Project

Aug 8 2021

dim committed rG400cd6d2f049: [libomptarget][amdgpu] use --allow-shlib-undefined to link on FreeBSD (authored by dim).
[libomptarget][amdgpu] use --allow-shlib-undefined to link on FreeBSD
Aug 8 2021, 4:53 AM
dim closed D107698: [libomptarget][amdgpu] use --allow-shlib-undefined to link on FreeBSD.
Aug 8 2021, 4:53 AM · Restricted Project
dim updated subscribers of D107698: [libomptarget][amdgpu] use --allow-shlib-undefined to link on FreeBSD.

That'll work. It means freebsd gets less link time sanity checking though.

The correct fix might be to use a platform abstraction over environment access. There's probably one in the llvm libraries we can use.

Aug 8 2021, 4:52 AM · Restricted Project
dim committed rGab4b4684a26c: [mlir] Avoid including <alloca.h> on FreeBSD and NetBSD (authored by dim).
[mlir] Avoid including <alloca.h> on FreeBSD and NetBSD
Aug 8 2021, 4:34 AM
dim closed D107699: [mlir] Avoid including <alloca.h> on FreeBSD and NetBSD.
Aug 8 2021, 4:33 AM · Restricted Project

Aug 7 2021

dim updated the diff for D89556: Avoid use of gets() in DOE-ProxyApps-C/Pathfinder.

Assume stdin is in text mode and compare correctly.

Aug 7 2021, 1:43 PM
dim updated the diff for D89556: Avoid use of gets() in DOE-ProxyApps-C/Pathfinder.

Add mygets() and implement it hopefully to everybody's liking.

Aug 7 2021, 1:37 PM
dim requested review of D107699: [mlir] Avoid including <alloca.h> on FreeBSD and NetBSD.
Aug 7 2021, 1:00 PM · Restricted Project
dim requested review of D107698: [libomptarget][amdgpu] use --allow-shlib-undefined to link on FreeBSD.
Aug 7 2021, 12:40 PM · Restricted Project

Aug 6 2021

dim committed rG71ae2e0221a9: [libomptarget][amdgpu] don't declare Elf_Note on FreeBSD (authored by dim).
[libomptarget][amdgpu] don't declare Elf_Note on FreeBSD
Aug 6 2021, 12:46 PM
dim closed D107661: [libomptarget][amdgpu] don't declare Elf_Note on FreeBSD.
Aug 6 2021, 12:46 PM · Restricted Project
dim requested review of D107661: [libomptarget][amdgpu] don't declare Elf_Note on FreeBSD.
Aug 6 2021, 12:09 PM · Restricted Project
dim added a comment to D107635: [LLD] Support compressed input sections on big-endian targets.

This LGTM, but I'm not an approver. I'll probably import this into FreeBSD if it's committed, though.

Aug 6 2021, 7:26 AM · Restricted Project

Aug 5 2021

dim committed rGb260f3fdda63: sanitizer_common: disable thread safety annotations for googletest (authored by dim).
sanitizer_common: disable thread safety annotations for googletest
Aug 5 2021, 11:08 AM
dim closed D107491: sanitizer_common: disable thread safety annotations for googletest.
Aug 5 2021, 11:07 AM · Restricted Project
dim updated the diff for D107491: sanitizer_common: disable thread safety annotations for googletest.

Fix typo.

Aug 5 2021, 11:04 AM · Restricted Project
dim updated the diff for D107491: sanitizer_common: disable thread safety annotations for googletest.

Only disable thread safety warnings on FreeBSD, and add an explanatory comment.

Aug 5 2021, 11:02 AM · Restricted Project

Aug 4 2021

dim added a comment to D107493: Re: Work around non-existence of ElfW(type) macro on FreeBSD.

Hmm in compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp it's even defined without any context or comment:

Aug 4 2021, 1:07 PM · Restricted Project
dim added inline comments to D107388: Work around non-existence of ElfW(type) macro on FreeBSD.
Aug 4 2021, 11:43 AM · Restricted Project
dim requested review of D107491: sanitizer_common: disable thread safety annotations for googletest.
Aug 4 2021, 11:36 AM · Restricted Project
dim committed rG440d9712ebf6: Work around non-existence of ElfW(type) macro on FreeBSD (authored by dim).
Work around non-existence of ElfW(type) macro on FreeBSD
Aug 4 2021, 11:16 AM
dim closed D107388: Work around non-existence of ElfW(type) macro on FreeBSD.
Aug 4 2021, 11:16 AM · Restricted Project

Aug 3 2021

dim updated the diff for D107388: Work around non-existence of ElfW(type) macro on FreeBSD.

Squash commits so buildkite doesn't choke.

Aug 3 2021, 3:04 PM · Restricted Project
dim updated subscribers of D105716: sanitizer_common: add thread safety annotations.

After this commit (tentative) I'm getting these compile errors on FreeBSD, when it's building the googletest parts of the compiler-rt tests:

Aug 3 2021, 2:09 PM · Restricted Project
dim updated the diff for D107388: Work around non-existence of ElfW(type) macro on FreeBSD.

Add comment about the FreeBSD ElfW(type) workaround.

Aug 3 2021, 1:54 PM · Restricted Project
dim added inline comments to D107388: Work around non-existence of ElfW(type) macro on FreeBSD.
Aug 3 2021, 1:35 PM · Restricted Project
dim requested review of D107388: Work around non-existence of ElfW(type) macro on FreeBSD.
Aug 3 2021, 12:36 PM · Restricted Project

Jul 28 2021

dim accepted D106964: [Security] Replace a Sony member.

LGTM

Jul 28 2021, 1:39 PM · Restricted Project

Jul 27 2021

dim accepted D106917: Security: make peoples' phab names obvious; recommend phab as the place for nominations.

LGTM.

Jul 27 2021, 3:08 PM · Restricted Project

Jul 21 2021

dim added inline comments to D105594: cmake: Allow shared libraries to customize the soname using LLVM_ABI_REVISION.
Jul 21 2021, 9:21 AM · Restricted Project, Restricted Project

Jun 22 2021

dim accepted D104753: [Driver] Stop linking _p libs for -pg on FreeBSD 14.

I mostly agree with this, but for the "silent ignoring" of -pg which this achieves. What would be the consequence of producing an error instead, like -pg not supported for FreeBSD >= 14 ? Too many unexpected failures?

Jun 22 2021, 3:33 PM · Restricted Project

May 29 2021

dim accepted D103346: [Support] Fix getMainExecutable on FreeBSD when called via an absolute path.

Yes, this looks good to me. Thanks for this fix!

May 29 2021, 12:39 AM · Restricted Project

May 28 2021

dim added a comment to D101773: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem.

https://bugs.llvm.org/show_bug.cgi?id=50522

May 28 2021, 1:14 PM · Restricted Project
dim updated subscribers of D101773: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem.

Hm so this is definitely something that we'd want in 12.0.1? @tstellar it doesn't change any ABI, so should be perfectly safe. I'll create a PR.

May 28 2021, 12:29 PM · Restricted Project

May 4 2021

dim committed rGdffddde73ab7: Revert "[llvm-objdump] Remove Generic Options group from help text output" (authored by dim).
Revert "[llvm-objdump] Remove Generic Options group from help text output"
May 4 2021, 9:29 AM
dim added a reverting change for rG73686247ac3e: [llvm-objdump] Remove Generic Options group from help text output: rGdffddde73ab7: Revert "[llvm-objdump] Remove Generic Options group from help text output".
May 4 2021, 9:29 AM
dim added a reverting change for D101652: [llvm-objdump] Remove Generic Options group from help text output: rGdffddde73ab7: Revert "[llvm-objdump] Remove Generic Options group from help text output".
May 4 2021, 9:29 AM · Restricted Project
dim added inline comments to rG73686247ac3e: [llvm-objdump] Remove Generic Options group from help text output.
May 4 2021, 9:27 AM
dim committed rG7e83a7f1fdfc: Reland "[MC][ELF] Work around R_MIPS_LO16 relocation handling problem" (authored by dim).
Reland "[MC][ELF] Work around R_MIPS_LO16 relocation handling problem"
May 4 2021, 9:16 AM

May 3 2021

dim added a comment to D101773: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem.

Reverted due to the influence this had on some other test cases. I'll do a full check-all and go over them one by one, but it will take some time...

May 3 2021, 2:11 PM · Restricted Project
dim added a reverting change for rGab40c027f0ce: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem: rGe1babfc2233b: Revert "[MC][ELF] Work around R_MIPS_LO16 relocation handling problem".
May 3 2021, 2:09 PM