- User Since
- Apr 15 2014, 12:19 PM (397 w, 4 d)
Thu, Nov 25
FWIW, this fixes both the minimized test case from PR52594, and the full original test case from https://bugs.freebsd.org/260000.
Wed, Nov 24
Tue, Nov 23
Squash commits because arc tricked me.
Drop trailing dots from report messages.
Mon, Nov 22
Note that this is the version as we have it in the FreeBSD base system version of llvm 13.0.0. Without the isPPC64() check, we would get unexpected R_X86_64_REX_GOTP relocations in our kernel modules, which the kernel module loader cannot handle; see e.g. https://reviews.llvm.org/D109090#3113552 and further comments.
Sat, Nov 20
Wed, Nov 17
Sat, Nov 6
Hmm this seems to cause some trouble when building kernels and kernel modules on FreeBSD, which are built in -ffreestanding mode, and then you get weird relocations in kernel modules:
Oct 19 2021
Oct 18 2021
This worked OK for building both 32-bit and 64-bit mips worlds on FreeBSD. Thanks!
Sep 26 2021
FWIW I think this is fine.
Sep 21 2021
I tried building head-of-main with LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON, and one thing I noticed is that the directories have the minor version swizzled in:
Sep 19 2021
Sep 16 2021
I can at least confirm that both the original test case for bug 51862 (from https://github.com/Macaulay2/frobby ) and the reduced test case compile successfully with this patch added.
Sep 9 2021
Sep 7 2021
Use version committed into FreeBSD 14-CURRENT.
I can't vouch for the Solaris specific parts, but it looks sane to me. I guess you won't need to add any tests, since this will fix many now-failing tests? :)
Sep 5 2021
I'm not a reviewer, but this looks good to me. (At first I thought that the required tablegen additions were missing, but they were at the end of the list of files so I missed them :) )
Sep 2 2021
Ah, gcc doesn't work at all with libc++ before C+11 :) I tried with gcc 12.0.0 20210711, and it spews hundreds of errors, starting off with:
But I think this is because my current clang is still 12.0.1? Was using_if_exists only added after 13.0.0 ?
Hmm I have applied this on top of our existing libc++ headers, but if I compile a simple program using e.g. -std=c++98 I immediately get errors due to missing declarations:
Aug 31 2021
However, I think I can make do with adding -U__bcopy to the clang command line. It would have been nice if these aliases were behind some --xl-compat flag... :)
I am really sorry that we broke you. Would it help if we defined this macro only if compiling for Linux/AIX? If so, are there any others (or perhaps all of them) that you'd like us to conditionally define only on AIX/Linux?
Aug 30 2021
Note that this unexpectedly broke FreeBSD's powerpc64 builds, as we've long used the following in our lib/libc/powerpc64/string/bcopy.S:
Aug 25 2021
Aug 24 2021
Aug 19 2021
Yes, there is no plugin for the language assembler. But that hasn't chnaged with this commit.
Aug 18 2021
It's mostly about shaving off quite a bit of build time, if you can skip all the formats that you never use. The size reduction is also nice, but is not really the essential part.
Aug 17 2021
Indeed in the FreeBSD base system we only build the ELF part and patch lldMain to stub out the rest, see https://github.com/freebsd/freebsd-src/commit/59948e95d8deadafca3acd659b6dfc78b708f117
Aug 16 2021
Aug 15 2021
Aug 14 2021
Hmm so now on FreeBSD, basically *every* program will cause this warning, as our C startup objects are compiled from .S files, e.g.:
Aug 12 2021
Thanks. This should be merged to 13.0.0, if possible.
Aug 10 2021
Aug 9 2021
Apparently the used compiler is clang 6.0.
Aug 8 2021
Aug 7 2021
Assume stdin is in text mode and compare correctly.
Add mygets() and implement it hopefully to everybody's liking.
Aug 6 2021
This LGTM, but I'm not an approver. I'll probably import this into FreeBSD if it's committed, though.
Aug 5 2021
Only disable thread safety warnings on FreeBSD, and add an explanatory comment.
Aug 4 2021
Hmm in compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp it's even defined without any context or comment:
Aug 3 2021
Squash commits so buildkite doesn't choke.
After this commit (tentative) I'm getting these compile errors on FreeBSD, when it's building the googletest parts of the compiler-rt tests:
Add comment about the FreeBSD ElfW(type) workaround.
Jul 28 2021
Jul 27 2021
Jul 21 2021
Jun 22 2021
I mostly agree with this, but for the "silent ignoring" of -pg which this achieves. What would be the consequence of producing an error instead, like -pg not supported for FreeBSD >= 14 ? Too many unexpected failures?
May 29 2021
Yes, this looks good to me. Thanks for this fix!
May 28 2021
Hm so this is definitely something that we'd want in 12.0.1? @tstellar it doesn't change any ABI, so should be perfectly safe. I'll create a PR.
May 4 2021
May 3 2021
Reverted due to the influence this had on some other test cases. I'll do a full check-all and go over them one by one, but it will take some time...