[flang] Don't use-associate intrinsics

[tskeith]

Summary

When an intrinsic is referenced in a module scope, a symbol for it is
added. When that module is USEd, the intrinsic should not be included.
Otherwise we can get ambiguous reference errors with the same intrinsic
coming from two difference modules.

flang/lib/Semantics/resolve-names.cpp

for (const auto &rename : *list) {
                      [&](const parser::Rename::Operators &ops) {
                        useNames.insert(std::get<1>(ops.t).v.source);
                      },
                  },
           rename.u);
     }
     for (const auto &[name, symbol] : *useModuleScope_) {
       if (symbol->attrs().test(Attr::PUBLIC) &&
+          !symbol->attrs().test(Attr::INTRINSIC) &&
           !symbol->detailsIf<MiscDetails>()) {
         if (useNames.count(name) == 0) {
           auto *localSymbol{FindInScope(currScope(), name)};
           if (!localSymbol) {
             localSymbol = &CopySymbol(name, *symbol);
           }
           AddUse(x.moduleName.source, *localSymbol, *symbol);
         }

flang/test/Semantics/modfile30.f90

 
 !Expect: m2.mod
 !module m2
 ! type::t
 ! end type
 ! type(t),parameter::a=t()
 !end
 
-! Don't write out intrinsics
 module m3a
   integer, parameter :: i4 = selected_int_kind(9)
 end
 module m3b
   use m3a
   integer(i4) :: j
 end
 
 !Expect: m3a.mod
 !module m3a
 ! integer(4),parameter::i4=4_4
 ! intrinsic::selected_int_kind
 !end
 
 !Expect: m3b.mod
 !module m3b
 ! use m3a,only:i4
-! use m3a,only:selected_int_kind
 ! integer(4)::j
 !end
 
 ! Test that character literals written with backslash escapes are read correctly.
 module m4a
   character(1), parameter :: a = achar(1)
 end
 module m4b
   use m4a
   character(1), parameter :: b = a
 end
 
 !Expect: m4a.mod
 !module m4a
 ! character(1_4,1),parameter::a="\001"
 ! intrinsic::achar
 !end
 
 !Expect: m4b.mod
 !module m4b
 ! use m4a,only:a
-! use m4a,only:achar
 ! character(1_4,1),parameter::b="\001"
 !end
 

flang/test/Semantics/resolve14.f90

 ! RUN: %S/test_errors.sh %s %t %f18
 module m1
   integer :: x
   integer :: y
   integer :: z
+  integer, parameter :: k1 = selected_int_kind(9)
 end
 module m2
   real :: y
   real :: z
   real :: w
+  integer, parameter :: k2 = selected_int_kind(9)
 end
 
+program p1
+  use m1
+  use m2
+  ! check that selected_int_kind is not use-associated
+  integer, parameter :: k = selected_int_kind(9)
+end
+
+program p2
   use m1, xx => x, y => z
   use m2
   volatile w
   !ERROR: Cannot change CONTIGUOUS attribute on use-associated 'w'
   contiguous w
   !ERROR: 'z' is use-associated from module 'm2' and cannot be re-declared
   integer z
   !ERROR: Reference to 'y' is ambiguous
   y = 1
 end