Page MenuHomePhabricator

[clang-tidy] OptionsView::store specialized on bool
ClosedPublic

Authored by njames93 on Jul 2 2020, 7:40 AM.

Details

Summary

Following on fcf7cc268fe and 672207c319a which granted checks the ability to read boolean configuration arguments as true or false.
This enables storing the options back to the configuration file using true and false.
This is in line with how clang-format dumps boolean options in its style config.

Diff Detail

Event Timeline

njames93 created this revision.Jul 2 2020, 7:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 2 2020, 7:40 AM
njames93 marked an inline comment as done.Jul 2 2020, 7:41 AM
njames93 added inline comments.
clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp
31 ↗(On Diff #275121)

Had to force this to explicitly call the correct function to avoid a compile error

njames93 updated this revision to Diff 277778.Tue, Jul 14, 4:28 AM

Removed no longer needed change to ProBoundsConstantArrayIndexCheck

This revision is now accepted and ready to land.Tue, Jul 14, 12:51 PM
This revision was automatically updated to reflect the committed changes.