- User Since
- Oct 31 2019, 10:15 AM (40 w, 3 d)
Fri, Aug 7
Thu, Aug 6
Could you add unit tests for methods in List and NNS? OK if they are in a separate patch.
Please also add appropriate handling to syntax::List::getDelimiterTokenKind, getTerminationKind, and canBeEmpty.
Wed, Aug 5
I'd suggest to drop the <> quotes (because the AST dump does not add quotes unless it is printing a multi-word thing, and because <> don't exactly scream "role" helping to read the output).
Node::dumpTokens was never used.
I feel uneasy about adding this code without tests. Could we maybe port the function parameter list to use this infrastructure, and then add tests that exercise getElementsAsNodesAndDelimiters?
Tue, Aug 4
Mon, Aug 3
Thu, Jul 30
Wed, Jul 29
Passed test cases but failed in the real world as std::string has a non trivial destructor so creates a CXXBindTemporaryExpr.
Tue, Jul 28
Mon, Jul 27
Fri, Jul 24
What is this diff based on? On the left I see, for example, NamespaceNameSpecifier, which is not in the repository yet.
Thu, Jul 23
Wed, Jul 22
Generally in Python it is preferred to have more strongly typed inputs than stringifying whatever comes in. If you feel like this is the best choice, I don't mind.
Fri, Jul 17
Did your latest update unintentionally drop the test file clang/test/Analysis/ns_error_enum.m?
Thu, Jul 16
Wed, Jul 15
Mon, Jul 13
Fri, Jul 10
Jul 10 2020
Could you take a look at test failures and check if they are relevant? linux > Clang.AST::ast-dump-attr.cpp looks extremely close to the area you're working on.
Jul 9 2020
Jul 8 2020
Fix crash on user defined literals
Jul 7 2020
Jul 6 2020
Jul 3 2020
Jul 1 2020
Jun 30 2020
Jun 29 2020
I reverted your commit because it seemed to have broken the build:
However, is this worth an RFC to the list?
Jun 26 2020
Now, in all the test cases we are calling the default implementation. We are not surfacing that WalkUpFrom can not walk up.
I generally avoid testing error message content in tests, but I know there's a variety of opinions on this subject...
Any chance for a test?