Page MenuHomePhabricator

gribozavr2 (Dmitri Gribenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 31 2019, 10:15 AM (63 w, 2 d)

Recent Activity

Dec 8 2020

gribozavr2 accepted D92861: [libc++] Remove the libc++ Sphinx docs job.
Dec 8 2020, 10:06 AM

Nov 22 2020

gribozavr2 added inline comments to D91915: [clang-tidy] Fix RenamerClangTidy checks trying to emit a fix that isnt a valid identifier.
Nov 22 2020, 10:12 AM · Restricted Project
gribozavr2 added inline comments to D91915: [clang-tidy] Fix RenamerClangTidy checks trying to emit a fix that isnt a valid identifier.
Nov 22 2020, 8:32 AM · Restricted Project
gribozavr2 accepted D91915: [clang-tidy] Fix RenamerClangTidy checks trying to emit a fix that isnt a valid identifier.
Nov 22 2020, 7:52 AM · Restricted Project

Nov 20 2020

gribozavr2 accepted D91614: [clang-tidy] Fix a nullptr-access crash in unused-raii-check..
Nov 20 2020, 5:23 PM · Restricted Project

Nov 18 2020

gribozavr2 accepted D91544: [clang-tidy] Allow `TransformerClangTidyCheck` clients to set the rule directly..
Nov 18 2020, 8:03 AM · Restricted Project

Nov 17 2020

gribozavr2 accepted D91601: [clang-tidy] Fix an abseil-redundant-strcat-calls crash on 0-parameter StrCat()..
Nov 17 2020, 1:52 AM · Restricted Project

Nov 11 2020

gribozavr2 accepted D91277: [Syntax] Tablegen literal expressions..
Nov 11 2020, 10:17 AM · Restricted Project

Nov 5 2020

gribozavr2 accepted D90240: [SyntaxTree] Add reverse links to syntax Nodes..
Nov 5 2020, 1:25 AM · Restricted Project

Nov 4 2020

gribozavr2 accepted D90659: [Syntax] Tablegen Sequence classes. NFC.
Nov 4 2020, 3:16 AM · Restricted Project
gribozavr2 accepted D90662: [Syntax] Tablegen operator<<(NodeKind). NFC.
Nov 4 2020, 2:45 AM · Restricted Project
gribozavr2 accepted D90543: [Syntax] Start to move trivial Node class definitions to TableGen. NFC.

e.g. we may introduce abstract bases like "loop" that the grammar doesn't care about in order to model is-a concepts that might make refactorings more expressive. This is less natural in a grammar-like idiom.

Nov 4 2020, 2:45 AM · Restricted Project
gribozavr2 added inline comments to D90540: [Syntax] Add minimal TableGen for syntax nodes. NFC.
Nov 4 2020, 2:30 AM · Restricted Project
gribozavr2 accepted D90540: [Syntax] Add minimal TableGen for syntax nodes. NFC.
Nov 4 2020, 2:23 AM · Restricted Project

Oct 28 2020

gribozavr2 accepted D89995: Make the post-commit review expectations more explicit with respect to revert.
Oct 28 2020, 3:26 PM · Restricted Project
gribozavr2 added a comment to D89995: Make the post-commit review expectations more explicit with respect to revert.

@gribozavr2 the paragraph now starts with "If shortly after landing a commit, a developer expresses concerns ..." ; WDYT?

Oct 28 2020, 12:00 PM · Restricted Project
gribozavr2 added inline comments to D90240: [SyntaxTree] Add reverse links to syntax Nodes..
Oct 28 2020, 5:29 AM · Restricted Project
gribozavr2 added a comment to D88859: APINotes: add APINotesYAMLCompiler.

Fair enough. But I don't think that Clang developers just copied the implementation from GCC or from MSVC.

Oct 28 2020, 5:14 AM · Restricted Project
gribozavr2 added a comment to D89995: Make the post-commit review expectations more explicit with respect to revert.

Generally, I think this patch reflects the existing expectation in the community, when the post-commit feedback is provided promptly.

Oct 28 2020, 3:30 AM · Restricted Project

Oct 27 2020

gribozavr2 added inline comments to D90240: [SyntaxTree] Add reverse links to syntax Nodes..
Oct 27 2020, 8:59 AM · Restricted Project

Oct 26 2020

gribozavr2 added a comment to D88859: APINotes: add APINotesYAMLCompiler.

I am having a hard time to accept "this is how it is implemented in our fork" as a technical argument. Besides, I am not sure how could the Clang community benefit about being backward compatible with a specialized fork and thus making superfluous complications.

Oct 26 2020, 11:52 AM · Restricted Project
gribozavr2 added inline comments to D90023: [Syntax] Add iterators over children of syntax trees..
Oct 26 2020, 9:03 AM · Restricted Project
gribozavr2 accepted D90163: [Syntax] Disallow invalid Node operations.
Oct 26 2020, 8:51 AM · Restricted Project
gribozavr2 added a comment to D90161: [SyntaxTree] Provide iterators for Lists.

Could you add tests that verify the pairing of elements and delimiters?

Oct 26 2020, 8:49 AM · Restricted Project
gribozavr2 accepted D90023: [Syntax] Add iterators over children of syntax trees..
Oct 26 2020, 8:34 AM · Restricted Project
gribozavr2 accepted D89608: Make sure Objective-C category support in IncludeSorter handles top-level imports.
Oct 26 2020, 7:03 AM · Restricted Project, Restricted Project
gribozavr2 accepted D90127: [clang][NFC] Rearrange Comment Token and Lexer fields to reduce padding.
Oct 26 2020, 7:02 AM · Restricted Project
gribozavr2 added inline comments to D90127: [clang][NFC] Rearrange Comment Token and Lexer fields to reduce padding.
Oct 26 2020, 12:07 AM · Restricted Project

Oct 21 2020

gribozavr2 added inline comments to D88553: [clangd] Start using SyntaxTrees for folding ranges feature.
Oct 21 2020, 7:10 AM · Restricted Project

Oct 20 2020

gribozavr2 added inline comments to D88553: [clangd] Start using SyntaxTrees for folding ranges feature.
Oct 20 2020, 5:15 AM · Restricted Project

Oct 17 2020

gribozavr2 accepted D89608: Make sure Objective-C category support in IncludeSorter handles top-level imports.

Any chance of adding a test?

Oct 17 2020, 12:00 AM · Restricted Project, Restricted Project

Oct 16 2020

gribozavr2 added inline comments to D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied..
Oct 16 2020, 11:59 PM · Restricted Project
gribozavr2 added reviewers for D89544: [CodingStandards] Clarify the recommendation to use SmallVector: jdoerfert, rjmccall.

What reasoning was used in the patch that added that wording?

Oct 16 2020, 5:24 AM · Restricted Project
gribozavr2 added a reviewer for D89544: [CodingStandards] Clarify the recommendation to use SmallVector: rsmith.
Oct 16 2020, 5:01 AM · Restricted Project
gribozavr2 added reviewers for D89544: [CodingStandards] Clarify the recommendation to use SmallVector: aaron.ballman, mehdi_amini.
Oct 16 2020, 5:01 AM · Restricted Project

Oct 15 2020

gribozavr2 accepted D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied..
Oct 15 2020, 9:39 PM · Restricted Project

Oct 14 2020

gribozavr2 accepted D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`.
Oct 14 2020, 2:17 AM · Restricted Project

Oct 13 2020

gribozavr2 added inline comments to D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`.
Oct 13 2020, 11:00 AM · Restricted Project
gribozavr2 accepted D89276: Support ObjC in IncludeInserter.
Oct 13 2020, 7:00 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr2 accepted D89314: [SyntaxTree] Bug fix in `MutationsImpl::addAfter`..
Oct 13 2020, 6:58 AM · Restricted Project

Oct 12 2020

gribozavr2 accepted D89270: [clang-tidy] Add an example for misc-unused-alias-decls.
Oct 12 2020, 11:10 PM · Restricted Project
gribozavr2 added inline comments to D88106: [SyntaxTree] Provide iterator-like functions for Lists.
Oct 12 2020, 4:46 AM · Restricted Project

Oct 9 2020

gribozavr2 accepted D89146: [SyntaxTree] Fix rtti for `Expression`..
Oct 9 2020, 12:00 PM · Restricted Project

Oct 8 2020

gribozavr2 accepted D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp.
Oct 8 2020, 8:29 AM · Restricted Project

Oct 6 2020

gribozavr2 added inline comments to D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp.
Oct 6 2020, 7:11 AM · Restricted Project
gribozavr2 accepted D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp.

Thank you! LGTM assuming you only moved the tests into separate cpp files (I didn't verify that the text is exactly the same).

Oct 6 2020, 7:10 AM · Restricted Project
gribozavr2 added a comment to D88400: [llvm-objcopy][MachO] Add support for universal binaries.

Unfortunately I see this change causing ASan failures in llvm-objcopy/MachO/strip-all.test:

Oct 6 2020, 2:32 AM · Restricted Project
gribozavr2 changed the visibility for D88400: [llvm-objcopy][MachO] Add support for universal binaries.
Oct 6 2020, 2:09 AM · Restricted Project

Oct 5 2020

gribozavr2 accepted D88831: [clang-tidy] Remove obsolete checker google-runtime-references.

Google C++ style guide does not have this rule anymore. Thanks for the cleanup!

Oct 5 2020, 8:51 AM · Restricted Project, Restricted Project

Sep 29 2020

gribozavr2 accepted D88403: Migrate Declarators to use the List API.
Sep 29 2020, 11:00 AM · Restricted Project

Sep 28 2020

gribozavr2 added inline comments to D88403: Migrate Declarators to use the List API.
Sep 28 2020, 12:50 PM · Restricted Project

Sep 25 2020

gribozavr2 accepted D88319: [AST] Delete broken, unused template..
Sep 25 2020, 10:37 AM · Restricted Project

Sep 22 2020

gribozavr2 accepted D87839: [SyntaxTree] Test the List API.
Sep 22 2020, 9:31 AM · Restricted Project
gribozavr2 added inline comments to D87839: [SyntaxTree] Test the List API.
Sep 22 2020, 6:12 AM · Restricted Project
gribozavr2 accepted D88077: [SyntaxTree] Add tests for the assignment of the `canModify` tag..
Sep 22 2020, 6:00 AM · Restricted Project
gribozavr2 accepted D88034: [SyntaxTree][Synthesis] Fix: `deepCopy` -> `deepCopyExpandingMacros`..
Sep 22 2020, 1:31 AM · Restricted Project

Sep 21 2020

gribozavr2 accepted D87779: [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf`.
Sep 21 2020, 10:15 AM · Restricted Project
gribozavr2 accepted D88024: [SyntaxTree][Nit] Take `ArrayRef` instead of `std::vector` as argument for `createTree`.
Sep 21 2020, 10:09 AM · Restricted Project
gribozavr2 accepted D88004: [SyntaxTree][NFC] follow naming convention + remove auto on empty vector declaration.
Sep 21 2020, 2:57 AM · Restricted Project
gribozavr2 added inline comments to D87749: [SyntaxTree][Synthesis] Implement `deepCopy`.
Sep 21 2020, 2:56 AM · Restricted Project
gribozavr2 added inline comments to D87749: [SyntaxTree][Synthesis] Implement `deepCopy`.
Sep 21 2020, 12:26 AM · Restricted Project

Sep 18 2020

gribozavr2 added inline comments to D87720: Sema: add support for `__attribute__((__swift_private__))`.
Sep 18 2020, 2:32 PM · Restricted Project
gribozavr2 added inline comments to D87779: [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf`.
Sep 18 2020, 2:26 PM · Restricted Project
gribozavr2 accepted D87534: Sema: introduce `__attribute__((__swift_name__))`.

This introduces the new swift_name attribute that allows annotating
interfaces with an alternate spelling for Swift. This is used as part
of the importing mechanism to allow interfaces to be imported with a new

Sep 18 2020, 2:10 PM · Restricted Project
gribozavr2 accepted D87896: [SyntaxTree][Synthesis] Improve testing `createLeaf`.
Sep 18 2020, 4:37 AM · Restricted Project
gribozavr2 accepted D87895: [SyntaxTree] Test for '\' inside token..
Sep 18 2020, 4:36 AM · Restricted Project

Sep 17 2020

gribozavr2 accepted D87749: [SyntaxTree][Synthesis] Implement `deepCopy`.
Sep 17 2020, 12:47 PM · Restricted Project
gribozavr2 accepted D87820: [SyntaxTree][Synthesis] Fix allocation in `createTree` for more general use.
Sep 17 2020, 5:54 AM · Restricted Project

Sep 15 2020

gribozavr2 added a comment to D87683: [clang-tidy] Crash fix for bugprone-misplaced-pointer-arithmetic-in-alloc.

Please fix the test case first, can't call operator new(unsigned long, void*) with an argument of type void*
The other failures the pre merge bot detected can safely be disregarded

Placement new is defined per standard:

void* operator new  ( std::size_t count, void* ptr );

Here, the problem is that size_t is unsigned long on Linux and it seems that it is unsigned long long on Windows. How should I overcome this?

In CSA, to overcome the platform problem, it is common to add a target triple for the RUN line:
https://github.com/llvm/llvm-project/blob/master/clang/test/Analysis/std-c-library-functions.c#L14

Sep 15 2020, 11:33 AM · Restricted Project, Restricted Project

Sep 14 2020

gribozavr2 accepted D87600: [SyntaxTree][List] `assertInvariants` for `List`s.
Sep 14 2020, 1:53 AM · Restricted Project
gribozavr2 accepted D87599: [SyntaxTree] Provide `List::classof`.
Sep 14 2020, 1:49 AM · Restricted Project
gribozavr2 accepted D87598: [SyntaxTree][List] Fix: `ParameterDeclarationList` is the `List` inside `ParametersAndQualifiers`.
Sep 14 2020, 1:49 AM · Restricted Project

Sep 11 2020

gribozavr2 added a comment to D87482: Fix clang Wrange-loop-analysis in BuildTree.cpp.

Sorry, I didn't realize you don't have commit access. Pushed this patch to git, thanks for the contribution!

Sep 11 2020, 4:10 PM · Restricted Project
gribozavr2 accepted D87395: Sema: add support for `__attribute__((__swift_objc_members__))`.

LGTM!

Sep 11 2020, 3:35 PM · Restricted Project
gribozavr2 accepted D87533: [SyntaxTree][Synthesis] Add support for Tree..
Sep 11 2020, 11:52 AM · Restricted Project
gribozavr2 accepted D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump.
Sep 11 2020, 11:26 AM · Restricted Project
gribozavr2 accepted D87522: [SyntaxTree] Add const qualifiers, from [llvm-qualified-auto].
Sep 11 2020, 10:54 AM · Restricted Project
gribozavr2 added reviewers for D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`: ymandel, gribozavr2.
Sep 11 2020, 10:52 AM · Restricted Project
gribozavr2 accepted D87523: [SyntaxTree] Reduce visibility of `Arena::lexBuffer`..
Sep 11 2020, 10:51 AM · Restricted Project
gribozavr2 accepted D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump.
Sep 11 2020, 10:46 AM · Restricted Project
gribozavr2 added inline comments to D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump.
Sep 11 2020, 5:51 AM · Restricted Project
gribozavr2 accepted D87498: [SyntaxTree][NFC] Rename functions to start with verb.
Sep 11 2020, 2:21 AM · Restricted Project
gribozavr2 added inline comments to D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump.
Sep 11 2020, 1:58 AM · Restricted Project

Sep 10 2020

gribozavr2 added inline comments to D87395: Sema: add support for `__attribute__((__swift_objc_members__))`.
Sep 10 2020, 5:23 PM · Restricted Project
gribozavr2 accepted D87482: Fix clang Wrange-loop-analysis in BuildTree.cpp.
Sep 10 2020, 2:29 PM · Restricted Project
gribozavr2 accepted D87409: [libTooling] Fix use of `char` in comparison..
Sep 10 2020, 2:24 PM · Restricted Project
gribozavr2 added inline comments to D87395: Sema: add support for `__attribute__((__swift_objc_members__))`.
Sep 10 2020, 1:10 PM · Restricted Project
gribozavr2 added inline comments to D87395: Sema: add support for `__attribute__((__swift_objc_members__))`.
Sep 10 2020, 12:57 PM · Restricted Project
gribozavr2 added inline comments to D87395: Sema: add support for `__attribute__((__swift_objc_members__))`.
Sep 10 2020, 12:56 PM · Restricted Project
gribozavr2 accepted D87331: Sema: add support for `__attribute__((__swift_error__))`.
Sep 10 2020, 4:28 AM · Restricted Project
gribozavr2 added inline comments to D87395: Sema: add support for `__attribute__((__swift_objc_members__))`.
Sep 10 2020, 4:22 AM · Restricted Project
gribozavr2 accepted D87374: [SyntaxTree] Specialize `TreeTestBase` for `BuildTreeTest` and `MutationsTest`.
Sep 10 2020, 1:50 AM · Restricted Project

Sep 8 2020

gribozavr2 accepted D87278: [Ignore Expressions] Fix performance regression by inlining `Ignore*SingleStep`.
Sep 8 2020, 6:43 AM · Restricted Project
gribozavr2 accepted D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`.
Sep 8 2020, 1:38 AM · Restricted Project

Sep 7 2020

gribozavr2 accepted D87249: [SyntaxTree] Fix crash on functions with default arguments..
Sep 7 2020, 11:43 PM · Restricted Project
gribozavr2 added a comment to D87249: [SyntaxTree] Fix crash on functions with default arguments..

Please also add tests for calls to constructors without arguments and calls to implicit constructors 1 argument, as requested in https://reviews.llvm.org/D86700.

Sep 7 2020, 11:55 AM · Restricted Project
gribozavr2 added inline comments to D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`.
Sep 7 2020, 11:54 AM · Restricted Project
gribozavr2 accepted D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`.
Sep 7 2020, 10:30 AM · Restricted Project
gribozavr2 accepted D87229: [SyntaxTree] Ignore implicit `CXXFunctionalCastExpr` wrapping constructor.
Sep 7 2020, 9:12 AM · Restricted Project
gribozavr2 accepted D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`.
Sep 7 2020, 9:11 AM · Restricted Project