User Details
- User Since
- Oct 31 2019, 10:15 AM (63 w, 2 d)
Dec 8 2020
Nov 22 2020
Nov 20 2020
Nov 18 2020
Nov 17 2020
Nov 11 2020
Nov 5 2020
Nov 4 2020
e.g. we may introduce abstract bases like "loop" that the grammar doesn't care about in order to model is-a concepts that might make refactorings more expressive. This is less natural in a grammar-like idiom.
Oct 28 2020
Fair enough. But I don't think that Clang developers just copied the implementation from GCC or from MSVC.
Generally, I think this patch reflects the existing expectation in the community, when the post-commit feedback is provided promptly.
Oct 27 2020
Oct 26 2020
I am having a hard time to accept "this is how it is implemented in our fork" as a technical argument. Besides, I am not sure how could the Clang community benefit about being backward compatible with a specialized fork and thus making superfluous complications.
Could you add tests that verify the pairing of elements and delimiters?
Oct 21 2020
Oct 20 2020
Oct 17 2020
Any chance of adding a test?
Oct 16 2020
Oct 15 2020
Oct 14 2020
Oct 13 2020
Oct 12 2020
Oct 9 2020
Oct 8 2020
Oct 6 2020
Thank you! LGTM assuming you only moved the tests into separate cpp files (I didn't verify that the text is exactly the same).
Unfortunately I see this change causing ASan failures in llvm-objcopy/MachO/strip-all.test:
Oct 5 2020
Google C++ style guide does not have this rule anymore. Thanks for the cleanup!
Sep 29 2020
Sep 28 2020
Sep 25 2020
Sep 22 2020
Sep 21 2020
Sep 18 2020
This introduces the new swift_name attribute that allows annotating
interfaces with an alternate spelling for Swift. This is used as part
of the importing mechanism to allow interfaces to be imported with a new
Sep 17 2020
Sep 15 2020
Sep 14 2020
Sep 11 2020
Sorry, I didn't realize you don't have commit access. Pushed this patch to git, thanks for the contribution!
LGTM!
Sep 10 2020
Sep 8 2020
Sep 7 2020
Please also add tests for calls to constructors without arguments and calls to implicit constructors 1 argument, as requested in https://reviews.llvm.org/D86700.