Page MenuHomePhabricator

gribozavr2 (Dmitri Gribenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 31 2019, 10:15 AM (40 w, 3 d)

Recent Activity

Fri, Aug 7

gribozavr2 accepted D85439: [SyntaxTree] Expand support for `NestedNameSpecifier`.
Fri, Aug 7, 6:03 AM · Restricted Project
gribozavr2 accepted D84348: WIP: Add complete id-expression support to syntax trees.
Fri, Aug 7, 5:44 AM · Restricted Project

Thu, Aug 6

gribozavr2 accepted D85427: [SyntaxTree][NFC] remove redundant namespace-specifiers.
Thu, Aug 6, 10:43 AM · Restricted Project
gribozavr2 added a comment to D85440: [SyntaxTree] Implement `NNS` using the `List` base API.

Could you add unit tests for methods in List and NNS? OK if they are in a separate patch.

Thu, Aug 6, 10:07 AM · Restricted Project
gribozavr2 added a comment to D85440: [SyntaxTree] Implement `NNS` using the `List` base API.

Please also add appropriate handling to syntax::List::getDelimiterTokenKind, getTerminationKind, and canBeEmpty.

Thu, Aug 6, 10:05 AM · Restricted Project
gribozavr2 added inline comments to D85295: [SyntaxTree] Implement the List construct..
Thu, Aug 6, 10:05 AM · Restricted Project
gribozavr2 added inline comments to D85295: [SyntaxTree] Implement the List construct..
Thu, Aug 6, 6:05 AM · Restricted Project
gribozavr2 accepted D85427: [SyntaxTree][NFC] remove redundant namespace-specifiers.
Thu, Aug 6, 5:32 AM · Restricted Project

Wed, Aug 5

gribozavr2 added inline comments to D85330: [SyntaxTree] Extend the syntax tree dump.
Wed, Aug 5, 12:34 PM · Restricted Project
gribozavr2 added a comment to D85316: [SyntaxTree] Proposition of new tree dump.

LGTM!

Wed, Aug 5, 10:44 AM · Restricted Project
gribozavr2 added a comment to D85316: [SyntaxTree] Proposition of new tree dump.

I'd suggest to drop the <> quotes (because the AST dump does not add quotes unless it is printing a multi-word thing, and because <> don't exactly scream "role" helping to read the output).

Wed, Aug 5, 9:10 AM · Restricted Project
gribozavr2 added a comment to D85305: [SyntaxTree] Remove dead code on dump functions.

Node::dumpTokens was never used.

Wed, Aug 5, 9:02 AM · Restricted Project
gribozavr2 added a comment to D85295: [SyntaxTree] Implement the List construct..

I feel uneasy about adding this code without tests. Could we maybe port the function parameter list to use this infrastructure, and then add tests that exercise getElementsAsNodesAndDelimiters?

Wed, Aug 5, 5:36 AM · Restricted Project

Tue, Aug 4

gribozavr2 accepted D85185: [SyntaxTree] Add test coverage for `->*` operator.
Tue, Aug 4, 1:29 PM · Restricted Project
gribozavr2 accepted D85186: [SyntaxTree] Add support for `LiteralExpression`.
Tue, Aug 4, 4:44 AM · Restricted Project
gribozavr2 accepted D85146: [SyntaxTree] Fix crash on pointer to member function.
Tue, Aug 4, 4:22 AM · Restricted Project

Mon, Aug 3

gribozavr2 accepted D85146: [SyntaxTree] Fix crash on pointer to member function.
Mon, Aug 3, 11:34 AM · Restricted Project

Thu, Jul 30

gribozavr2 accepted D84973: [clang][Syntax] syntax::Arena doesnt own TokenBuffer.
Thu, Jul 30, 2:07 PM · Restricted Project
gribozavr2 added inline comments to D84975: [clangd][WIP] Make use of SyntaxTrees for SemanticSelection.
Thu, Jul 30, 1:46 PM · Restricted Project
gribozavr2 accepted D84926: [clang-tidy][NFC] Use StringMap for ClangTidyCheckFactories::FacoryMap.
Thu, Jul 30, 4:08 AM · Restricted Project
gribozavr2 accepted D84902: [clang-tidy] Fix ODR violation in unittests..
Thu, Jul 30, 12:50 AM · Restricted Project

Wed, Jul 29

gribozavr2 accepted D84868: [clang-tidy] Use StringMap for ClangTidyOptions::OptionsMap.
Wed, Jul 29, 10:40 AM · Restricted Project
gribozavr2 accepted D84005: Introduce ns_error_domain attribute..
Wed, Jul 29, 6:35 AM · Restricted Project
gribozavr2 added a reviewer for D78574: Do not map read-only data memory sections with EXECUTE flags.: lhames.
Wed, Jul 29, 6:13 AM · Restricted Project
gribozavr2 accepted D84814: [clang-tidy] readability-identifier-naming checks configs for included files.
Wed, Jul 29, 4:35 AM · Restricted Project
gribozavr2 accepted D84831: [clang-tidy] Fix RedundantStringCStrCheck with r values.

Passed test cases but failed in the real world as std::string has a non trivial destructor so creates a CXXBindTemporaryExpr.

Wed, Jul 29, 4:32 AM · Restricted Project
gribozavr2 accepted D84812: [clang-tidy][NFC] Added convienence methods for getting optional options.
Wed, Jul 29, 4:26 AM · Restricted Project

Tue, Jul 28

gribozavr2 added inline comments to D84812: [clang-tidy][NFC] Added convienence methods for getting optional options.
Tue, Jul 28, 9:57 PM · Restricted Project
gribozavr2 added inline comments to D84814: [clang-tidy] readability-identifier-naming checks configs for included files.
Tue, Jul 28, 9:51 PM · Restricted Project

Mon, Jul 27

gribozavr2 accepted D84348: WIP: Add complete id-expression support to syntax trees.
Mon, Jul 27, 10:00 AM · Restricted Project
gribozavr2 accepted D84005: Introduce ns_error_domain attribute..
Mon, Jul 27, 2:36 AM · Restricted Project
gribozavr2 accepted D84623: Remove HAVE_VCS_VERSION_INC, not needed.
Mon, Jul 27, 2:19 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr2 accepted D84315: [libTooling] Add a `between` range-selector combinator..
Mon, Jul 27, 1:15 AM · Restricted Project
gribozavr2 accepted D84005: Introduce ns_error_domain attribute..
Mon, Jul 27, 12:43 AM · Restricted Project

Fri, Jul 24

gribozavr2 added inline comments to D84348: WIP: Add complete id-expression support to syntax trees.
Fri, Jul 24, 12:10 PM · Restricted Project
gribozavr2 added a comment to D84348: WIP: Add complete id-expression support to syntax trees.

What is this diff based on? On the left I see, for example, NamespaceNameSpecifier, which is not in the repository yet.

Fri, Jul 24, 8:57 AM · Restricted Project

Thu, Jul 23

gribozavr2 accepted D84409: [libTooling] Add an `EditGenerator` that applies a rule throughout a bound node..
Thu, Jul 23, 1:06 PM · Restricted Project
gribozavr2 accepted D84310: [libTooling] Add assorted `EditGenerator` combinators..
Thu, Jul 23, 10:58 AM · Restricted Project

Wed, Jul 22

gribozavr2 accepted D81361: Make lit TestRunner.py work in Python 3.

Generally in Python it is preferred to have more strongly typed inputs than stringifying whatever comes in. If you feel like this is the best choice, I don't mind.

Wed, Jul 22, 1:05 AM · Restricted Project

Fri, Jul 17

gribozavr2 added inline comments to D84005: Introduce ns_error_domain attribute..
Fri, Jul 17, 5:39 AM · Restricted Project
gribozavr2 added a comment to D84005: Introduce ns_error_domain attribute..

Did your latest update unintentionally drop the test file clang/test/Analysis/ns_error_enum.m?

Fri, Jul 17, 4:58 AM · Restricted Project
gribozavr2 added inline comments to D84005: Introduce ns_error_domain attribute..
Fri, Jul 17, 2:09 AM · Restricted Project

Thu, Jul 16

gribozavr2 retitled D83966: Enable the test for hasArraySize() AST matcher in all language modes from Enable the test for hasArraySize() in all language modes to Enable the test for hasArraySize() AST matcher in all language modes.
Thu, Jul 16, 10:09 AM · Restricted Project
gribozavr2 added a reviewer for D83966: Enable the test for hasArraySize() AST matcher in all language modes: ymandel.
Thu, Jul 16, 10:07 AM · Restricted Project
gribozavr2 accepted D83887: Add hashing support for std::tuple.
Thu, Jul 16, 3:57 AM · Restricted Project

Wed, Jul 15

gribozavr2 added inline comments to D83887: Add hashing support for std::tuple.
Wed, Jul 15, 1:37 PM · Restricted Project
gribozavr2 added a reviewer for D83868: Use TestClangConfig in AST Matchers tests and run them in more configurations: ymandel.
Wed, Jul 15, 6:22 AM · Restricted Project
gribozavr2 accepted D83820: Change metadata to deferred evalutaion in Clang Transformer..
Wed, Jul 15, 4:58 AM · Restricted Project

Mon, Jul 13

gribozavr2 added reviewers for D83700: Fix test for the hasExternalFormalLinkage matcher: aaron.ballman, rsmith, ymandel.
Mon, Jul 13, 10:53 AM · Restricted Project

Fri, Jul 10

gribozavr2 accepted D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen..
Fri, Jul 10, 1:56 PM · Restricted Project

Jul 10 2020

gribozavr2 accepted D83513: [AST][ObjC] Fix crash when printing invalid objc categories.
Jul 10 2020, 11:04 AM · Restricted Project
gribozavr2 accepted D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen..

Could you take a look at test failures and check if they are relevant? linux > Clang.AST::ast-dump-attr.cpp looks extremely close to the area you're working on.

Jul 10 2020, 9:50 AM · Restricted Project
gribozavr2 accepted D82157: Fix crash on `user defined literals`.
Jul 10 2020, 8:05 AM · Restricted Project

Jul 9 2020

gribozavr2 added inline comments to D82157: Fix crash on `user defined literals`.
Jul 9 2020, 10:54 AM · Restricted Project
gribozavr2 accepted D83301: [clang-tidy] More strict on matching the standard memset function in memset-usage check..
Jul 9 2020, 8:06 AM · Restricted Project
gribozavr2 added inline comments to D83480: Refactored NumericLiteralParser to not require a Preprocessor.
Jul 9 2020, 8:04 AM · Restricted Project
gribozavr2 added a reviewer for D83480: Refactored NumericLiteralParser to not require a Preprocessor: eduucaldas.
Jul 9 2020, 6:01 AM · Restricted Project
gribozavr2 added inline comments to D82157: Fix crash on `user defined literals`.
Jul 9 2020, 2:58 AM · Restricted Project

Jul 8 2020

gribozavr2 accepted D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation.
Jul 8 2020, 6:44 AM · Restricted Project
gribozavr2 added a comment to D82157: Fix crash on `user defined literals`.

Fix crash on user defined literals

Jul 8 2020, 5:54 AM · Restricted Project
gribozavr2 added inline comments to D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation.
Jul 8 2020, 5:39 AM · Restricted Project
gribozavr2 added inline comments to D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation.
Jul 8 2020, 3:14 AM · Restricted Project

Jul 7 2020

gribozavr2 accepted D83293: [clang-tidy] Fix an unused-raii check crash on objective-c++..
Jul 7 2020, 4:15 AM · Restricted Project
gribozavr2 accepted D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation.
Jul 7 2020, 4:13 AM · Restricted Project

Jul 6 2020

gribozavr2 added inline comments to D82937: Fix `isInfixBinaryOp` that returned true for postfix ++.
Jul 6 2020, 12:12 PM · Restricted Project
gribozavr2 added inline comments to D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation.
Jul 6 2020, 10:06 AM · Restricted Project

Jul 3 2020

gribozavr2 retitled D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation from Fix crash on overloaded postfix unary operators due to invalid sloc to Fix crash on overloaded postfix unary operators due to invalid SourceLocation.
Jul 3 2020, 2:39 AM · Restricted Project

Jul 1 2020

gribozavr2 accepted D82960: Add parenthesized expression to SyntaxTree.
Jul 1 2020, 11:54 AM · Restricted Project
gribozavr2 accepted D82901: [libTooling] Fix `maybeExtendRange` to support `CharRange`s..
Jul 1 2020, 11:54 AM · Restricted Project
gribozavr2 updated the summary of D82921: Removed a RecursiveASTVisitor feature to visit operator kinds with different methods.
Jul 1 2020, 4:49 AM · Restricted Project
gribozavr2 added inline comments to D82875: Added tests for RecursiveASTVisitor for AST nodes that are special cased.
Jul 1 2020, 4:49 AM · Restricted Project
gribozavr2 added inline comments to D82787: Make RecursiveASTVisitor call WalkUpFrom for unary and binary operators in post-order traversal mode.
Jul 1 2020, 4:17 AM · Restricted Project
gribozavr2 updated the summary of D82921: Removed a RecursiveASTVisitor feature to visit operator kinds with different methods.
Jul 1 2020, 4:17 AM · Restricted Project

Jun 30 2020

gribozavr2 added reviewers for D82921: Removed a RecursiveASTVisitor feature to visit operator kinds with different methods: rsmith, sammccall, ymandel, aaron.ballman.
Jun 30 2020, 4:50 PM · Restricted Project
gribozavr2 added inline comments to D82889: Make RecursiveASTVisitor call WalkUpFrom for operators when the data recursion queue is absent.
Jun 30 2020, 11:24 AM · Restricted Project
gribozavr2 added reviewers for D82889: Make RecursiveASTVisitor call WalkUpFrom for operators when the data recursion queue is absent: eduucaldas, ymandel, rsmith.
Jun 30 2020, 9:47 AM · Restricted Project
gribozavr2 accepted D82226: Add Metadata to Transformer tooling.
Jun 30 2020, 7:00 AM · Restricted Project
gribozavr2 added inline comments to D82875: Added tests for RecursiveASTVisitor for AST nodes that are special cased.
Jun 30 2020, 7:00 AM · Restricted Project
gribozavr2 added reviewers for D82875: Added tests for RecursiveASTVisitor for AST nodes that are special cased: ymandel, eduucaldas.
Jun 30 2020, 7:00 AM · Restricted Project

Jun 29 2020

gribozavr2 added reviewers for D82787: Make RecursiveASTVisitor call WalkUpFrom for unary and binary operators in post-order traversal mode: ymandel, eduucaldas.
Jun 29 2020, 10:15 AM · Restricted Project
gribozavr2 added a comment to D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor.

I reverted your commit because it seemed to have broken the build:

Jun 29 2020, 8:03 AM · Restricted Project
gribozavr2 added inline comments to D82766: Compile the RecursiveASTVisitor callbacks test with "/bigobj".
Jun 29 2020, 7:31 AM · Restricted Project
gribozavr2 added a reviewer for D82766: Compile the RecursiveASTVisitor callbacks test with "/bigobj": erichkeane.
Jun 29 2020, 6:59 AM · Restricted Project
gribozavr2 added reviewers for D82760: RecursiveASTVisitor: inline a macro that is only used once: eduucaldas, ymandel.
Jun 29 2020, 5:54 AM · Restricted Project
gribozavr2 added reviewers for D82740: [libclang]: check validity before visiting Stmt node: akyrtzi, benlangmuir.
Jun 29 2020, 2:39 AM · Restricted Project
gribozavr2 added inline comments to D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces.
Jun 29 2020, 2:06 AM · Restricted Project
gribozavr2 added a comment to D82179: Move TestClangConfig into libClangTesting and use it in AST Matchers tests.

However, is this worth an RFC to the list?

Jun 29 2020, 2:06 AM · Restricted Project
gribozavr2 added inline comments to D82157: Fix crash on `user defined literals`.
Jun 29 2020, 1:02 AM · Restricted Project

Jun 26 2020

gribozavr2 added a comment to D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces.

Now, in all the test cases we are calling the default implementation. We are not surfacing that WalkUpFrom can not walk up.

Jun 26 2020, 2:41 PM · Restricted Project
gribozavr2 added inline comments to D82486: RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal.
Jun 26 2020, 8:10 AM · Restricted Project
gribozavr2 added a comment to D82654: [libTooling] Improve error message from failure in selection Stencil.

I generally avoid testing error message content in tests, but I know there's a variety of opinions on this subject...

Jun 26 2020, 8:10 AM · Restricted Project
gribozavr2 updated the summary of D82486: RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal.
Jun 26 2020, 7:37 AM · Restricted Project
gribozavr2 added inline comments to D82486: RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal.
Jun 26 2020, 7:37 AM · Restricted Project
gribozavr2 added a comment to D82226: Add Metadata to Transformer tooling.

I think the tradeoff here is
Dynamic typing -- faster compile times, type safety checked at run-time (in tests), lower maintenance cost
Templates -- Faster runtime, type safety checked at compile-time, better user expereience

Jun 26 2020, 7:03 AM · Restricted Project
gribozavr2 accepted D82654: [libTooling] Improve error message from failure in selection Stencil.

Any chance for a test?

Jun 26 2020, 7:03 AM · Restricted Project
gribozavr2 added reviewers for D82636: Work around a bug in MSVC in the syntax tree test: eduucaldas, vvereschaka.
Jun 26 2020, 3:13 AM · Restricted Project
gribozavr2 added a comment to D82312: Add `CharLiteral` to SyntaxTree.

@vvereschaka Sorry about that. It looks like a bug in MSVC. I implemented a workaround in https://reviews.llvm.org/D82636 -- please review if you have time.

Jun 26 2020, 3:13 AM · Restricted Project

Jun 25 2020

gribozavr2 added inline comments to D82310: Add `BoolLiteralExpression` to SyntaxTree.
Jun 25 2020, 5:47 AM · Restricted Project
gribozavr2 added inline comments to D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces.
Jun 25 2020, 4:42 AM · Restricted Project

Jun 24 2020

gribozavr2 added reviewers for D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces: ymandel, eduucaldas.
Jun 24 2020, 11:21 AM · Restricted Project