This is an archive of the discontinued LLVM Phabricator instance.

[Aarch64] Don't truncate PC-relative relocations in ELF EH frames to 32 bits
AcceptedPublic

Authored by • ossy on Mar 11 2015, 8:36 AM.

Reviewers

Summary

It was fixed on x86_64 by http://reviews.llvm.org/D6079 , but we need similar fix on Aarch64 for FTL JIT of WebKit

• ossy retitled this revision from to [Aarch64] Don't truncate PC-relative relocations in ELF EH frames to 32 bits.

• ossy updated this object.

• ossy edited the test plan for this revision. (Show Details)

• ossy set the repository for this revision to rL LLVM.

• ossy added a subscriber: Unknown Object (MLST).Mar 11 2015, 8:37 AM

LGTM, but I'd like to see a comment from the ARM folks. Tim?

This revision is now accepted and ready to land.Aug 13 2015, 6:46 AM

This is a dwarf specific question to which I don't know the answer.

Adding some AArch64 specific people as well as Keith, the Dwarf expert.

I'd welcome Eric's input, too.

cheers,
-renato

Well, it is more a question of what code models aarch64 supports and which of those allow sections to be more than 2GB away from each other.

Path

Size

lib/

MC/

1 line

Context not available.
	case Triple::mips64el:	case Triple::mips64el:
	FDECFIEncoding = dwarf::DW_EH_PE_sdata8;	FDECFIEncoding = dwarf::DW_EH_PE_sdata8;
	break;	break;
		case Triple::aarch64:
	case Triple::x86_64:	case Triple::x86_64:
	FDECFIEncoding = dwarf::DW_EH_PE_pcrel \|	FDECFIEncoding = dwarf::DW_EH_PE_pcrel \|
	((CMModel == CodeModel::Large) ? dwarf::DW_EH_PE_sdata8	((CMModel == CodeModel::Large) ? dwarf::DW_EH_PE_sdata8
Context not available.