Since the current default _ALL_SOURCE causes numerous issues on AIX (e.g., typedef redefinition, unintended macro expansion), this patch changes the configuration to use standard-compatable mode by appending XOPEN_SOURCE=700. This flag is added to cflags for all the C test cases because a considerable number of C tests are affected by the _ALL_SOURCE problem. For one particular C++ test case that was also affected by _ALL_SOURCE, the flag is appended to the cxxflags in its sub-level CMakeLists.
Details
Details
Diff Detail
Diff Detail
- Repository
- rOLDT svn-test-suite
- Build Status
Buildable 61591 Build 74991: arc lint + arc unit
Event Timeline
Comment Actions
LGTM other than minor nit
CMakeLists.txt | ||
---|---|---|
173 | nit: I think we should probably add a comment that this is a work around for system header issues that we are intending to apply only to C, something like: # Use X/OPEN compatibility flag on AIX for C tests to avoid problems with some versions of the system headers. |
Comment Actions
This is failing on Darwin. Looks like for the C++ test too, the flag should be added only if it is AIX.
MultiSource/Benchmarks/DOE-ProxyApps-C++/miniFE/mytimer.cpp:116:19: error: variable has incomplete type 'struct timezone'
Refer to http://green.lab.llvm.org/green/job/test-suite-verify-machineinstrs-aarch64-O0-g/7783/consoleFull.
Comment Actions
The reported failure is fixed in the latest build, http://green.lab.llvm.org/green/job/test-suite-verify-machineinstrs-aarch64-O0-g/7867/consoleFull.
nit: I think we should probably add a comment that this is a work around for system header issues that we are intending to apply only to C, something like: