Page MenuHomePhabricator

[AMDGPU] Remove assertion on S1024 SGPR to VGPR spill
ClosedPublic

Authored by critson on May 29 2020, 2:55 AM.

Details

Summary

Replace an assertion that blocks S1024 SGPR to VGPR spill.
The assertion pre-dates S1024 and is not wave size dependent.

Diff Detail

Event Timeline

critson created this revision.May 29 2020, 2:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 29 2020, 2:55 AM
arsenm accepted this revision.May 29 2020, 6:12 AM
This revision is now accepted and ready to land.May 29 2020, 6:12 AM
This revision was automatically updated to reflect the committed changes.

arc adds many unneeded tags from Phabricator. You can drop Reviewers: Subscribers: Tags: and the text Summary: with the following script:

arcfilter () {
  arc amend
  git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
}

Reviewed By: is considered important by some people (https://lists.llvm.org/pipermail/llvm-dev/2020-January/137889.html). You should keep the tag. (I started to use --date=now because some people find author date != committer date annoying. The committer date is usually what people care.))