This is an archive of the discontinued LLVM Phabricator instance.

[globalisel][cse] Merge debug locations when CSE'ing
ClosedPublic

Authored by dsanders on Apr 17 2020, 10:51 AM.

Diff Detail

Event Timeline

dsanders created this revision.Apr 17 2020, 10:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2020, 10:51 AM

I currently don't have an in-tree test case for this but it should be possible to construct one. Essentially it needs CSE enabled, and needs two instructions that need legalization and emit a common instruction during their legalizations with identical constraints (to avoid the copy) and have conflicting debug locations. I'll try to make an AArch64 test case when I get chance.

This revision is now accepted and ready to land.Apr 17 2020, 11:22 AM
This revision was landed with ongoing or failed builds.Jul 28 2020, 2:25 PM
This revision was automatically updated to reflect the committed changes.