Page MenuHomePhabricator

NFC: modernize / clean up some loop transform utils, affine analysis utils
ClosedPublic

Authored by bondhugula on Mar 12 2020, 10:59 PM.

Details

Summary
  • remove stale declarations on flat affine constraints
  • avoid allocating small vectors where possible
  • clean up code comments, rename some variables

Signed-off-by: Uday Bondhugula <uday@polymagelabs.com>

Diff Detail

Event Timeline

bondhugula created this revision.Mar 12 2020, 10:59 PM
bondhugula edited the summary of this revision. (Show Details)Mar 12 2020, 11:01 PM

Update commit message

rriddle accepted this revision.Mar 12 2020, 11:27 PM
rriddle added inline comments.
mlir/include/mlir/Analysis/AffineStructures.h
317

Please use /// for top level comments.

mlir/lib/Analysis/AffineStructures.cpp
1204

Same here

This revision is now accepted and ready to land.Mar 12 2020, 11:27 PM

Address review comment - doc string.

Thanks for the review @rriddle - could you please commit this for me?

andydavis1 accepted this revision.Mar 13 2020, 7:29 AM

Nice clean up!

flaub accepted this revision.Mar 13 2020, 11:19 AM

LGTM

LGTM

@flaub Could you please commit this if you have access?

Sorry for the delay, I was mostly out today. Committed in bf0cc6b328ca7fe8b938acb379eb56d7e74ad019.

Have you considered requesting commit access?

This revision was automatically updated to reflect the committed changes.

Sorry for the delay, I was mostly out today. Committed in bf0cc6b328ca7fe8b938acb379eb56d7e74ad019.

Have you considered requesting commit access?

Done - I have it now. (I was under the impression that it required contributions to llvm/clang proper.)