User Details
- User Since
- Jan 7 2020, 4:33 PM (66 w, 4 d)
Jan 12 2021
Thanks Diego! The changes look good to me. Please wait for Uday to have another look before submitting. Thanks!
Dec 16 2020
Adding one more comment...
Dec 10 2020
Thanks for working on this Diego!
Dec 4 2020
Thanks!
Nov 18 2020
Thanks Diego. Looks great!
Oct 14 2020
Looks good. Let's see if Nicolas has some feedback...
Oct 13 2020
Aug 4 2020
Thanks Diego!
Jun 23 2020
Jun 22 2020
Thanks for addressing this issue! Let's see if Uday has any more comments before committing, but your latest changes look good to me...
Thanks for your contribution!
Jun 15 2020
Jun 12 2020
Jun 11 2020
Thanks for improving this. Looks good to me...
Jun 2 2020
Jun 1 2020
Can you please add bondhugula@ as a reviewer too?
May 15 2020
May 12 2020
Thanks for doing this Diego! Will be very nice to have this. Especially for affine loop fusion and dma generation....
May 6 2020
Thanks Uday! Looks good...
Thanks Alex!
May 5 2020
Rebase
Thanks for doing this Alex. The test coverage is great. Thanks!
addressing review comments
Thanks Alex! Will rebase this with changes in a bit...
May 1 2020
Apr 30 2020
Apr 27 2020
Thanks Uday...
Apr 20 2020
Apr 15 2020
Apr 13 2020
Apr 10 2020
Apr 8 2020
rebase
Apr 7 2020
Adressing comments and rebasing.
addressing comments
Thanks PTAL...
Apr 6 2020
Apr 3 2020
Apr 2 2020
Apr 1 2020
Mar 31 2020
rebasing
Mar 30 2020
PTAL. Let me know if there are any more comments...Thanks!
Thanks for fixing this bug Uday!
Mar 27 2020
addressing feedback
Thanks. I've addressed comments and will update with a new patch soon...
Mar 26 2020
Mar 25 2020
Mar 23 2020
Mar 20 2020
Thanks Aart. Yes, if its not too much work, I'd love to see this op take a permutation of dimensions of an N-D vector.
Mar 19 2020
Thanks Aart. How hard would this be to generalize this op to make it N-D transpose op, instead of limit to 2D cases? For example, I may want to transpose the inner two dimensions of a N-D vector
Mar 13 2020
Nice clean up!
Mar 12 2020
Aart. This looks good to me, but please wait for Nicolas' feedback as well. I think the two of you have chatted more about the outer-product stuff...
Mar 9 2020
Mar 5 2020
Feb 24 2020
Thanks Alex!
Feb 20 2020
Looks good, thanks Aart! One question, is the unrolling here deterministic in that the same op will always produce the same sequence of reductions after unrolling? Context is numerical stability across test runs....
Feb 19 2020
Thanks Aart!
Feb 18 2020
Feb 11 2020
addressing review comments
addressing comments.
addressing comments.
rebasing with head
addressing comments
Feb 10 2020
Feb 6 2020
Thanks. A fix is on the way...
Feb 5 2020
Looks good from my perspective.
rebasing
rebasing with head
rebasing with head.