This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Move test passes out of lib/Analysis
ClosedPublic

Authored by stephenneuendorffer on Feb 5 2020, 9:24 AM.

Details

Summary

This breaks a cyclic library dependency where MLIRPass used the verifier
in MLIRAnalysis, but MLIRAnalysis also contained passes used for testing.
The presence of the test passes here is archaeology, predating
test/lib/Transform.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2020, 9:24 AM

Unit tests: unknown.

clang-tidy: pass.

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

bmahjour removed a subscriber: bmahjour.Feb 5 2020, 9:45 AM
rriddle accepted this revision.Feb 5 2020, 9:55 AM

Can you summarize why you are doing this in the revision summary?

This revision is now accepted and ready to land.Feb 5 2020, 9:55 AM
stephenneuendorffer retitled this revision from [MLIR] Move test passes out of lib/Analysis r=rriddle to [MLIR] Move test passes out of lib/Analysis.
stephenneuendorffer edited the summary of this revision. (Show Details)

Unit tests: pass. 62514 tests passed, 0 failed and 844 were skipped.

clang-tidy: pass.

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

This revision was automatically updated to reflect the committed changes.
mlir/test/lib/Transforms/TestMemRefDependenceCheck.cpp