Page MenuHomePhabricator

[NFC] Add SUPPORT_PLUGINS to add_llvm_executable()
ClosedPublic

Authored by daltenty on Oct 30 2019, 1:30 PM.

Details

Summary

this allows us to move logic about when it is appropriate set
LLVM_NO_DEAD_STRIP out of each tool and into add_llvm_executable,
which will enable future platform specific handling.

This is a follow on to the reverted D69356

Diff Detail

Event Timeline

daltenty created this revision.Oct 30 2019, 1:30 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 30 2019, 1:30 PM
daltenty edited the summary of this revision. (Show Details)Oct 30 2019, 1:33 PM

A few comments inline.

clang/tools/driver/CMakeLists.txt
39

This is now a behavior change because you're always passing this.

You'll want to bring back the conditional statement with a body like:

set(support_plugins SUPPORT_PLUGINS)

Then instead of passing SUPPORT_PLUGINS here you pass ${support_plugins}

llvm/cmake/modules/AddLLVM.cmake
787

By convention in LLVM we use On rather than 1

daltenty updated this revision to Diff 227461.Nov 1 2019, 8:57 AM
  • Address review comments round 1
daltenty updated this revision to Diff 227463.Nov 1 2019, 9:00 AM
daltenty marked an inline comment as done.
  • Rebase
daltenty marked an inline comment as done.Nov 1 2019, 9:01 AM
beanz accepted this revision.Nov 1 2019, 2:57 PM

LGTM

This revision is now accepted and ready to land.Nov 1 2019, 2:57 PM
This revision was automatically updated to reflect the committed changes.