Page MenuHomePhabricator

lhames (Lang Hames)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 27 2013, 2:34 PM (388 w, 3 d)

Recent Activity

Wed, Aug 5

lhames committed rGba8683f29290: [JITLink][MachO][AArch64] More PAGEOFF12 relocation fixes. (authored by lhames).
[JITLink][MachO][AArch64] More PAGEOFF12 relocation fixes.
Wed, Aug 5, 9:47 PM
lhames committed rG47cfffe893f3: [JITLink][AArch64] Handle addends on PAGE21 / PAGEOFF12 relocations. (authored by lhames).
[JITLink][AArch64] Handle addends on PAGE21 / PAGEOFF12 relocations.
Wed, Aug 5, 8:52 AM
lhames committed rGd561d1bf9635: [JITLink][AArch64] Improve debug output for addend relocations. (authored by lhames).
[JITLink][AArch64] Improve debug output for addend relocations.
Wed, Aug 5, 8:52 AM

Mon, Aug 3

lhames committed rG777824b49d5d: [llvm-jitlink] Add support for static archives and MachO universal archives. (authored by lhames).
[llvm-jitlink] Add support for static archives and MachO universal archives.
Mon, Aug 3, 1:01 PM

Sun, Aug 2

lhames added a comment to D78574: Do not map read-only data memory sections with EXECUTE flags..

@digit -- Do you have commit access to land this, or would you like me to commit on your behalf?

Sun, Aug 2, 10:34 AM · Restricted Project

Sat, Aug 1

lhames committed rG0f5b70769d15: [llvm-jitlink] Add -phony-externals option to suppress unresolved externals. (authored by lhames).
[llvm-jitlink] Add -phony-externals option to suppress unresolved externals.
Sat, Aug 1, 6:34 PM
lhames committed rGe12a028ed3ed: [llvm-jitlink] Support promotion of ODR weak symbols in -harness mode. (authored by lhames).
[llvm-jitlink] Support promotion of ODR weak symbols in -harness mode.
Sat, Aug 1, 6:34 PM

Thu, Jul 30

lhames committed rGc8fef0cc54fa: [JITLink] Use correct Addressable constructor. (authored by lhames).
[JITLink] Use correct Addressable constructor.
Thu, Jul 30, 11:12 PM
lhames accepted D84390: RuntimeDyldELF: report_fatal_error instead of asserting for unimplemented relocations (PR46816).

Sorry for the delay! LGTM.

Thu, Jul 30, 8:28 PM · Restricted Project
lhames committed rG8ce8cee1e1d4: [llvm-jitlink] Add -harness option to llvm-jitlink. (authored by lhames).
[llvm-jitlink] Add -harness option to llvm-jitlink.
Thu, Jul 30, 3:26 PM
lhames committed rG9f1dcdca71c4: [JITLink] Allow JITLinkContext::notifyResolved to return an Error. (authored by lhames).
[JITLink] Allow JITLinkContext::notifyResolved to return an Error.
Thu, Jul 30, 3:26 PM

Wed, Jul 29

lhames accepted D78574: Do not map read-only data memory sections with EXECUTE flags..

I don't see any reason for RODataMem to be mapped executable. I don't think this will break anything, but if it does the fix would be to update RuntimeDyld to ensure any code that needs executing ends up in CodeMem.

Wed, Jul 29, 8:13 AM · Restricted Project

Sun, Jul 26

lhames committed rG47a40eda178e: [ORC] Remove a redundant call to getTargetMemory. (authored by lhames).
[ORC] Remove a redundant call to getTargetMemory.
Sun, Jul 26, 5:36 PM

Sat, Jul 25

lhames committed rGa01c4ee71cb2: [ORC] Rename TargetProcessControl DynamicLibraryHandle and loadLibrary. (authored by lhames).
[ORC] Rename TargetProcessControl DynamicLibraryHandle and loadLibrary.
Sat, Jul 25, 3:22 PM
lhames committed rG11d5316afd10: [ORC] Don't require PageSize or Triple during TargetProcessControl construction (authored by lhames).
[ORC] Don't require PageSize or Triple during TargetProcessControl construction
Sat, Jul 25, 3:22 PM

Thu, Jul 23

lhames committed rG69091eb1c40a: [ORC] Enable use of TargetProcessControl::getMemMgr with ObjectLinkingLayer. (authored by lhames).
[ORC] Enable use of TargetProcessControl::getMemMgr with ObjectLinkingLayer.
Thu, Jul 23, 4:37 PM

Wed, Jul 22

lhames committed rG13ad00be98e1: [ORC] Add a TargetProcessControl-based dynamic library search generator. (authored by lhames).
[ORC] Add a TargetProcessControl-based dynamic library search generator.
Wed, Jul 22, 4:31 PM

Mon, Jul 20

lhames committed rG574713c3076c: [ExecutionEngine] Initialize near block hint in SectionMemoryManager. (authored by lhames).
[ExecutionEngine] Initialize near block hint in SectionMemoryManager.
Mon, Jul 20, 9:19 PM

Sun, Jul 19

lhames committed rG0d944e00ea14: [ORC] Refactor TrampolinePool to reduce virtual function calls. (authored by lhames).
[ORC] Refactor TrampolinePool to reduce virtual function calls.
Sun, Jul 19, 10:42 PM
lhames committed rGcdd10ca28063: [JITLink][MachO] Tidy up debugging output for relocation parsing. (authored by lhames).
[JITLink][MachO] Tidy up debugging output for relocation parsing.
Sun, Jul 19, 7:46 PM
lhames committed rGf7a571537a14: [JITLink][MachO] Fix handling of non-extern UNSIGNED pair of SUBTRACTOR relocs. (authored by lhames).
[JITLink][MachO] Fix handling of non-extern UNSIGNED pair of SUBTRACTOR relocs.
Sun, Jul 19, 10:48 AM

Fri, Jul 17

lhames committed rG3b55bfad2a3b: [llvm-jitlink] Add suppport for testing GOT entries and stubs for ELF. (authored by lhames).
[llvm-jitlink] Add suppport for testing GOT entries and stubs for ELF.
Fri, Jul 17, 5:56 PM

Thu, Jul 16

lhames committed rG10056238ac07: [ORC] Switch from initializer lists to named arguments to work around MSVC. (authored by lhames).
[ORC] Switch from initializer lists to named arguments to work around MSVC.
Thu, Jul 16, 3:59 PM
lhames committed rGb0bc77380d8c: [ORC] Add more explicit casts to fix a narrowing conversion errors. (authored by lhames).
[ORC] Add more explicit casts to fix a narrowing conversion errors.
Thu, Jul 16, 3:38 PM
lhames committed rG121302ac6286: [ORC] Add explicit cast to fix a narrowing conversion error. (authored by lhames).
[ORC] Add explicit cast to fix a narrowing conversion error.
Thu, Jul 16, 3:33 PM
lhames committed rG0e940d55f8a9: [ORC] Add TargetProcessControl and TPCIndirectionUtils APIs. (authored by lhames).
[ORC] Add TargetProcessControl and TPCIndirectionUtils APIs.
Thu, Jul 16, 3:11 PM

Wed, Jul 15

lhames added inline comments to D83748: Adding support for PCRel32GOTLoad in ELF x86 for the jitlinker.
Wed, Jul 15, 1:22 PM · Restricted Project
lhames added inline comments to D83748: Adding support for PCRel32GOTLoad in ELF x86 for the jitlinker.
Wed, Jul 15, 12:12 PM · Restricted Project
lhames added inline comments to D83748: Adding support for PCRel32GOTLoad in ELF x86 for the jitlinker.
Wed, Jul 15, 9:58 AM · Restricted Project

Tue, Jul 14

lhames accepted D83748: Adding support for PCRel32GOTLoad in ELF x86 for the jitlinker.

LGTM -- Thanks very much Jared!

Tue, Jul 14, 11:00 PM · Restricted Project
GitHub <noreply@github.com> committed rGae8fff42d996: Merge pull request #1354 from lhames/reenable-jitlink-for-lljit-by-default-on… (authored by lhames).
Merge pull request #1354 from lhames/reenable-jitlink-for-lljit-by-default-on…
Tue, Jul 14, 4:55 PM
lhames committed rGf87c51cc4ded: Re-apply "[ORC] Always use ObjectLinkingLayer/JITLink for MachO on x86-64..." (authored by lhames).
Re-apply "[ORC] Always use ObjectLinkingLayer/JITLink for MachO on x86-64..."
Tue, Jul 14, 4:55 PM
GitHub <noreply@github.com> committed rG04a1a0b5ee94: Merge pull request #1348 from lhames/add-linker-private-global-support-to-jit (authored by lhames).
Merge pull request #1348 from lhames/add-linker-private-global-support-to-jit
Tue, Jul 14, 4:55 PM
lhames committed rG0c83542ae08f: [JITLink][MachO] Re-apply b64afadf306, MachO linker-private support, with fixes. (authored by lhames).
[JITLink][MachO] Re-apply b64afadf306, MachO linker-private support, with fixes.
Tue, Jul 14, 4:55 PM
lhames committed rGdf5a274079e8: [RuntimeDyld] Add missing include. (authored by lhames).
[RuntimeDyld] Add missing include.
Tue, Jul 14, 4:55 PM
lhames committed rG5382fefebe02: [RuntimeDyld] Add dependence on Core. (authored by lhames).
[RuntimeDyld] Add dependence on Core.
Tue, Jul 14, 4:55 PM
lhames committed rG210ba8aecb66: [ORC] Honor linker private global prefix on symbol names. (authored by lhames).
[ORC] Honor linker private global prefix on symbol names.
Tue, Jul 14, 4:55 PM
GitHub <noreply@github.com> committed rGc3071d8c75e2: Merge pull request #1330 from lhames/revert-lljit-by-default (authored by lhames).
Merge pull request #1330 from lhames/revert-lljit-by-default
Tue, Jul 14, 4:54 PM
lhames added a reverting change for rG03a1fc722e64: [ORC] Always use ObjectLinkingLayer/JITLink for MachO on x86-64 and arm64.: rG1f510b4eb408: Revert "[ORC] Always use ObjectLinkingLayer/JITLink for MachO on x86-64 and….
Tue, Jul 14, 4:54 PM
lhames committed rG1f510b4eb408: Revert "[ORC] Always use ObjectLinkingLayer/JITLink for MachO on x86-64 and… (authored by lhames).
Revert "[ORC] Always use ObjectLinkingLayer/JITLink for MachO on x86-64 and…
Tue, Jul 14, 4:54 PM
GitHub <noreply@github.com> committed rG5659f837b4d5: Merge pull request #1322 from lhames/always-use-jitlink-for-lljit-on-darwin (authored by lhames).
Merge pull request #1322 from lhames/always-use-jitlink-for-lljit-on-darwin
Tue, Jul 14, 4:54 PM
lhames committed rG7d26ddacbef4: [JITLink] Skip debug sections in MachO objects. (authored by lhames).
[JITLink] Skip debug sections in MachO objects.
Tue, Jul 14, 4:54 PM
lhames committed rG03a1fc722e64: [ORC] Always use ObjectLinkingLayer/JITLink for MachO on x86-64 and arm64. (authored by lhames).
[ORC] Always use ObjectLinkingLayer/JITLink for MachO on x86-64 and arm64.
Tue, Jul 14, 4:54 PM
GitHub <noreply@github.com> committed rGf46625d2d2d4: Merge pull request #1292 from lhames/lljit-construction-logging (authored by lhames).
Merge pull request #1292 from lhames/lljit-construction-logging
Tue, Jul 14, 4:53 PM
lhames committed rG77c611ac481e: [ORC] Add debugging output for LLJIT construction. (authored by lhames).
[ORC] Add debugging output for LLJIT construction.
Tue, Jul 14, 4:53 PM
lhames committed rG2406bb4d63e2: [ORC] Skip ST_File symbols in MaterializationUnit interfaces / resolution. (authored by lhames).
[ORC] Skip ST_File symbols in MaterializationUnit interfaces / resolution.
Tue, Jul 14, 4:31 PM
GitHub <noreply@github.com> committed rGeefed175ce6d: Merge pull request #875 from lhames/st-file-symbols-fix (authored by lhames).
Merge pull request #875 from lhames/st-file-symbols-fix
Tue, Jul 14, 4:31 PM
lhames committed rG3d931e85f1ca: [ORC] Don't take ownership of the trampoline pool in LazyReexportsManager. (authored by lhames).
[ORC] Don't take ownership of the trampoline pool in LazyReexportsManager.
Tue, Jul 14, 10:59 AM

Mon, Jul 13

lhames committed rG66550c36f43b: [ORC] Fix typo in parameter name. (authored by lhames).
[ORC] Fix typo in parameter name.
Mon, Jul 13, 4:20 PM
lhames committed rG31b5b121299c: [ORC] Remove a spurious reinterpret_cast. (authored by lhames).
[ORC] Remove a spurious reinterpret_cast.
Mon, Jul 13, 12:43 PM
lhames committed rG51b20152e66c: [JITLink] Apply MSVCPError workaround to a1fc26030a42. (authored by lhames).
[JITLink] Apply MSVCPError workaround to a1fc26030a42.
Mon, Jul 13, 11:56 AM
lhames committed rGfb7ef0bb0b9c: [ORC] Generalize emit re-entry, stub, etc. APIs for working addr != link addr. (authored by lhames).
[ORC] Generalize emit re-entry, stub, etc. APIs for working addr != link addr.
Mon, Jul 13, 10:15 AM
lhames committed rGa1fc26030a42: [JITLink] Add a synchronous version of finalize for convenience. (authored by lhames).
[JITLink] Add a synchronous version of finalize for convenience.
Mon, Jul 13, 10:15 AM

Jul 8 2020

lhames committed rG670915094462: [ORC] Modify LazyCallThroughManager to support asynchronous resolution. (authored by lhames).
[ORC] Modify LazyCallThroughManager to support asynchronous resolution.
Jul 8 2020, 9:14 PM

Jun 29 2020

lhames accepted D82211: [SVE] Remove calls to VectorType::getNumElements from ExecutionEngine.

LGTM, pending addressing of sdesmalen's comments.

Jun 29 2020, 5:13 PM · Restricted Project

Jun 24 2020

lhames added a comment to D70628: [Support] Enable file + line info in LLVM stack traces on Darwin..

Yep. I'd actually settled on the idea of teaching llvm-symbolizer how to chase down the debug info in the individual objects, but I'm not sure when I'll have time to actually do the work.

Jun 24 2020, 4:52 PM · Restricted Project

Jun 19 2020

lhames committed rG22d7a01dd728: [JITLink] Allow zero-length symbols at the end of blocks. (authored by lhames).
[JITLink] Allow zero-length symbols at the end of blocks.
Jun 19 2020, 10:20 AM
lhames committed rGbf783a6aa890: [JITLink] Display host -> target address mapping in debugging output. (authored by lhames).
[JITLink] Display host -> target address mapping in debugging output.
Jun 19 2020, 10:20 AM

Jun 15 2020

lhames committed rG5682f192bd93: [RuntimeDyld] Add dependence on Core. (authored by lhames).
[RuntimeDyld] Add dependence on Core.
Jun 15 2020, 11:34 AM
lhames committed rG498dd745f55b: [ORC] Honor linker private global prefix on symbol names. (authored by lhames).
[ORC] Honor linker private global prefix on symbol names.
Jun 15 2020, 10:57 AM

Jun 5 2020

lhames committed rGe429cffd4f22: [ORC] Always use ObjectLinkingLayer/JITLink for MachO on x86-64 and arm64. (authored by lhames).
[ORC] Always use ObjectLinkingLayer/JITLink for MachO on x86-64 and arm64.
Jun 5 2020, 9:09 PM

Jun 3 2020

lhames committed rGd27cbf03cf9c: [JITLink] Skip debug sections in MachO objects. (authored by lhames).
[JITLink] Skip debug sections in MachO objects.
Jun 3 2020, 11:33 AM

May 29 2020

lhames accepted D80613: Getting R_X86_64_PC32 working as our first relocation.

LGTM!

May 29 2020, 5:30 PM · Restricted Project

May 28 2020

lhames committed rGff92d3c672e2: [ORC] Add debugging output for LLJIT construction. (authored by lhames).
[ORC] Add debugging output for LLJIT construction.
May 28 2020, 8:52 PM
lhames committed rGa6deaeec370e: [JITLink] Improve llvm-jitlink regression testing support for ELF. (authored by lhames).
[JITLink] Improve llvm-jitlink regression testing support for ELF.
May 28 2020, 8:51 PM
lhames committed rG9eafcbfca1b0: [JITLink] Fix 80-column rule violation. (authored by lhames).
[JITLink] Fix 80-column rule violation.
May 28 2020, 8:51 PM
lhames added a comment to D80613: Getting R_X86_64_PC32 working as our first relocation.

a6deaeec370ec5e34f9e5aa3fad3bc73770d4895 adds basic support for llvm-jitlink -check tests for ELF. That should allow you to test this.

May 28 2020, 8:51 PM · Restricted Project

May 27 2020

lhames requested changes to D80613: Getting R_X86_64_PC32 working as our first relocation.

Oh, wait: this still needs a test case before it lands. The llvm/test/ExecutionEngine/JITLink/X86/ELF_x86-64_relocations.s test should be updated to include a check for the new relocation.

May 27 2020, 4:23 PM · Restricted Project
lhames accepted D80613: Getting R_X86_64_PC32 working as our first relocation.

This looks great!

May 27 2020, 3:16 PM · Restricted Project

May 21 2020

lhames committed rG2e40cf06df0c: [JITLink] Initial implementation of ELF / x86-64 support for JITLink. (authored by lhames).
[JITLink] Initial implementation of ELF / x86-64 support for JITLink.
May 21 2020, 10:11 PM
lhames closed D79832: Initial commit for the elf x86 implementation for jitlink .
May 21 2020, 10:11 PM · Restricted Project

May 16 2020

lhames accepted D79832: Initial commit for the elf x86 implementation for jitlink .

Ok. This looks good to me!

May 16 2020, 9:12 PM · Restricted Project

May 14 2020

lhames added a comment to D79832: Initial commit for the elf x86 implementation for jitlink .

Just got a chance to look at the build messages for this. There are a few warnings (noted inline). I also noticed that this patch is against 2e42cc7a50e which is from late January. I don't think the JITLink APIs have changed too much: if you're happy to rebase against top of tree then go for it, otherwise I'm happy to do that before committing.

May 14 2020, 8:39 PM · Restricted Project

May 13 2020

lhames added a comment to D79832: Initial commit for the elf x86 implementation for jitlink .

This is great stuff -- thanks Jared!

May 13 2020, 9:47 PM · Restricted Project

May 12 2020

lhames updated the diff for D79312: [ORC] Preliminary support for removable code..

Update for changes in 41379f1ec46.

May 12 2020, 4:09 PM · Restricted Project

May 10 2020

lhames committed rG689486dc2a8a: [examples] Fix the SpeculativeJIT and ThinLtoJIT examples for 41379f1ec46. (authored by lhames).
[examples] Fix the SpeculativeJIT and ThinLtoJIT examples for 41379f1ec46.
May 10 2020, 5:37 PM
lhames committed rG41379f1ec465: [ORC] Share ownership of JITDylibs between ExecutionSession and… (authored by lhames).
[ORC] Share ownership of JITDylibs between ExecutionSession and…
May 10 2020, 5:01 PM

May 9 2020

lhames created D79685: [Support] Use unique_function for ThreadPool..
May 9 2020, 10:20 PM · Restricted Project

May 4 2020

lhames committed rGc66f89005f6d: [ORC] Rename SearchOrder operations on JITDylib to LinkOrder. (authored by lhames).
[ORC] Rename SearchOrder operations on JITDylib to LinkOrder.
May 4 2020, 5:14 PM
lhames committed rG990eb9446755: [JITLink] Fix missing ADDITIONAL_HEADER_DIRS for the LLVMJITLink component. (authored by lhames).
[JITLink] Fix missing ADDITIONAL_HEADER_DIRS for the LLVMJITLink component.
May 4 2020, 1:27 PM
lhames committed rG7ac0c3b47516: [JITLink] Fix a typo in a comment. (authored by lhames).
[JITLink] Fix a typo in a comment.
May 4 2020, 1:27 PM
lhames created D79312: [ORC] Preliminary support for removable code..
May 4 2020, 12:29 AM · Restricted Project

May 1 2020

lhames committed rGdbc601e25b6d: [examples] Fix an incomplete comment. (authored by lhames).
[examples] Fix an incomplete comment.
May 1 2020, 5:26 PM
lhames committed rG30b28766d62d: [examples] Call setProcessAllSections to ensure debug sections aren't droppped. (authored by lhames).
[examples] Call setProcessAllSections to ensure debug sections aren't droppped.
May 1 2020, 5:25 PM

Apr 28 2020

lhames accepted D78813: [AIX] Skip unsupported ORC JIT RemoteObjectLayerTest on AIX.

LGTM. RemoteObjectLayer is deprecated and will be removed soon, so anything that makes the builders happy is fine by me.

Apr 28 2020, 10:11 AM · Restricted Project

Apr 27 2020

lhames committed rG7113a9a65445: [JITLink] Fix endianness bug fedd32e2fa36. (authored by lhames).
[JITLink] Fix endianness bug fedd32e2fa36.
Apr 27 2020, 10:45 AM
lhames added a comment to rGfedd32e2fa36: [JITLink] Read MachO Header CPU field only in jitLink_MachO..

Hi Anirudh,

Apr 27 2020, 10:44 AM

Apr 22 2020

lhames committed rG3ceea67c091d: [JITLink] Fix edge removal iterator invalidation. (authored by lhames).
[JITLink] Fix edge removal iterator invalidation.
Apr 22 2020, 2:42 PM
lhames committed rGfedd32e2fa36: [JITLink] Read MachO Header CPU field only in jitLink_MachO. (authored by lhames).
[JITLink] Read MachO Header CPU field only in jitLink_MachO.
Apr 22 2020, 2:42 PM

Apr 21 2020

lhames accepted D78032: [llvm-objdump] Default to the "apple-latest" mcpu when disassembling arm64 Mach-O binaries.

This looks good to me. Unless anyone else has any other feedback I think this should go in, minus the whole-file reformatting.

Apr 21 2020, 12:26 PM · Restricted Project

Apr 20 2020

lhames added a comment to D78032: [llvm-objdump] Default to the "apple-latest" mcpu when disassembling arm64 Mach-O binaries.

I would prefer to keep this change in the tool for now (as this patch does).

Apr 20 2020, 3:12 PM · Restricted Project

Apr 18 2020

lhames committed rGa7a03d647f19: [ORC] Add example showing how to initialize/deinitialize a JITDylib with LLJIT. (authored by lhames).
[ORC] Add example showing how to initialize/deinitialize a JITDylib with LLJIT.
Apr 18 2020, 3:38 PM
lhames committed rGc6ade39ba083: [ORC] Replace LLJIT::defineAbsolute with an LLJIT::define convenience method. (authored by lhames).
[ORC] Replace LLJIT::defineAbsolute with an LLJIT::define convenience method.
Apr 18 2020, 3:38 PM
lhames committed rG702b3f01ddb8: [ORC] Add a convenience method to create a JITEvaluatedSymbol from a pointer. (authored by lhames).
[ORC] Add a convenience method to create a JITEvaluatedSymbol from a pointer.
Apr 18 2020, 3:38 PM

Apr 16 2020

lhames committed rGa6f19762c6d9: [llvm-objcopy][MachO] Correctly identify object file endianness. (authored by lhames).
[llvm-objcopy][MachO] Correctly identify object file endianness.
Apr 16 2020, 10:10 PM
lhames committed rGcc0ec3fdb9d1: [llvm-objcopy][MachO] Fix MachO::relocation_info use after 386f1c114d5. (authored by lhames).
[llvm-objcopy][MachO] Fix MachO::relocation_info use after 386f1c114d5.
Apr 16 2020, 6:57 PM
lhames committed rG386f1c114d59: [Object] Remove conditional layout of bitfields in MachO::relocation_info. (authored by lhames).
[Object] Remove conditional layout of bitfields in MachO::relocation_info.
Apr 16 2020, 4:44 PM
lhames added inline comments to D77844: [ObjectYAML][MachO] Add support for relocations.
Apr 16 2020, 4:43 PM · Restricted Project
lhames added inline comments to D77844: [ObjectYAML][MachO] Add support for relocations.
Apr 16 2020, 11:08 AM · Restricted Project

Apr 15 2020

lhames committed rGa9ade27a5721: [docs] Fix an RST error introduced in e823068306e. (authored by lhames).
[docs] Fix an RST error introduced in e823068306e.
Apr 15 2020, 2:56 PM